diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 08:50:58 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 09:54:25 +0200 |
| commit | 24eae7bd702f3f6dd790be7ac38ac16e9fe6a375 (patch) | |
| tree | 56398264184709e84517c2e843aa3a0894cc1c51 /cui | |
| parent | fad919eb0d30b2303193e1c00ba765514957652c (diff) | |
clang-tidy performance-unnecessary-value-param
Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8
Reviewed-on: https://gerrit.libreoffice.org/60068
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui')
| -rw-r--r-- | cui/source/dialogs/SignSignatureLineDialog.cxx | 3 | ||||
| -rw-r--r-- | cui/source/dialogs/SignatureLineDialog.cxx | 4 | ||||
| -rw-r--r-- | cui/source/dialogs/SignatureLineDialogBase.cxx | 3 |
3 files changed, 7 insertions, 3 deletions
diff --git a/cui/source/dialogs/SignSignatureLineDialog.cxx b/cui/source/dialogs/SignSignatureLineDialog.cxx index 29b26f4f645e..9b3be762b2d9 100644 --- a/cui/source/dialogs/SignSignatureLineDialog.cxx +++ b/cui/source/dialogs/SignSignatureLineDialog.cxx @@ -18,6 +18,7 @@ #include <comphelper/processfactory.hxx> #include <tools/stream.hxx> #include <unotools/streamwrap.hxx> +#include <utility> #include <vcl/weld.hxx> #include <sfx2/objsh.hxx> @@ -48,7 +49,7 @@ using namespace css::graphic; using namespace css::security; SignSignatureLineDialog::SignSignatureLineDialog(weld::Widget* pParent, Reference<XModel> xModel) - : SignatureLineDialogBase(pParent, xModel, "cui/ui/signsignatureline.ui", + : SignatureLineDialogBase(pParent, std::move(xModel), "cui/ui/signsignatureline.ui", "SignSignatureLineDialog") , m_xEditName(m_xBuilder->weld_entry("edit_name")) , m_xEditComment(m_xBuilder->weld_text_view("edit_comment")) diff --git a/cui/source/dialogs/SignatureLineDialog.cxx b/cui/source/dialogs/SignatureLineDialog.cxx index 335a33fd7395..c582df2d8d59 100644 --- a/cui/source/dialogs/SignatureLineDialog.cxx +++ b/cui/source/dialogs/SignatureLineDialog.cxx @@ -13,6 +13,7 @@ #include <comphelper/xmltools.hxx> #include <tools/stream.hxx> #include <unotools/streamwrap.hxx> +#include <utility> #include <vcl/weld.hxx> #include <com/sun/star/beans/XPropertySet.hpp> @@ -48,7 +49,8 @@ using namespace css::graphic; SignatureLineDialog::SignatureLineDialog(weld::Widget* pParent, Reference<XModel> xModel, bool bEditExisting) - : SignatureLineDialogBase(pParent, xModel, "cui/ui/signatureline.ui", "SignatureLineDialog") + : SignatureLineDialogBase(pParent, std::move(xModel), "cui/ui/signatureline.ui", + "SignatureLineDialog") , m_xEditName(m_xBuilder->weld_entry("edit_name")) , m_xEditTitle(m_xBuilder->weld_entry("edit_title")) , m_xEditEmail(m_xBuilder->weld_entry("edit_email")) diff --git a/cui/source/dialogs/SignatureLineDialogBase.cxx b/cui/source/dialogs/SignatureLineDialogBase.cxx index 3028d2941a37..a4806bdf1c01 100644 --- a/cui/source/dialogs/SignatureLineDialogBase.cxx +++ b/cui/source/dialogs/SignatureLineDialogBase.cxx @@ -9,6 +9,7 @@ #include <SignatureLineDialogBase.hxx> +#include <utility> #include <vcl/weld.hxx> using namespace css; @@ -18,7 +19,7 @@ using namespace css::frame; SignatureLineDialogBase::SignatureLineDialogBase(weld::Widget* pParent, Reference<XModel> xModel, const OUString& rUIFile, const OString& rDialogId) : GenericDialogController(pParent, rUIFile, rDialogId) - , m_xModel(xModel) + , m_xModel(std::move(xModel)) { } |