Drop std::as_const from css::uno::Sequence iterations

Obsoleted by commit 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove
non-const Sequence::begin()/end() in internal code, 2021-10-15) and
commit fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const
Sequence::operator[] in internal code, 2021-11-05).

Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

6 files changed, 20 insertions, 20 deletions

diff --git a/cui/source/customize/SvxConfigPageHelper.cxx b/cui/source/customize/SvxConfigPageHelper.cxx
index c14cb3560c9f..59a2cdb64017 100644
--- a/cui/source/customize/SvxConfigPageHelper.cxx
+++ b/cui/source/customize/SvxConfigPageHelper.cxx
@@ -248,7 +248,7 @@ OUString SvxConfigPageHelper::GetUIModuleName(
 
         if (a >>= aSeq)
         {
-            for (css::beans::PropertyValue const& rProp : std::as_const(aSeq))
+            for (css::beans::PropertyValue const& rProp : aSeq)
             {
                 if (rProp.Name == "ooSetupFactoryUIName")
                 {
@@ -282,7 +282,7 @@ bool SvxConfigPageHelper::GetMenuItemData(
         css::uno::Sequence<css::beans::PropertyValue> aProps;
         if (rItemContainer->getByIndex(nIndex) >>= aProps)
         {
-            for (css::beans::PropertyValue const& rProp : std::as_const(aProps))
+            for (css::beans::PropertyValue const& rProp : aProps)
             {
                 if (rProp.Name == ITEM_DESCRIPTOR_COMMANDURL)
                 {
@@ -325,7 +325,7 @@ bool SvxConfigPageHelper::GetToolbarItemData(
         css::uno::Sequence<css::beans::PropertyValue> aProps;
         if (rItemContainer->getByIndex(nIndex) >>= aProps)
         {
-            for (css::beans::PropertyValue const& rProp : std::as_const(aProps))
+            for (css::beans::PropertyValue const& rProp : aProps)
             {
                 if (rProp.Name == ITEM_DESCRIPTOR_COMMANDURL)
                 {
diff --git a/cui/source/customize/SvxNotebookbarConfigPage.cxx b/cui/source/customize/SvxNotebookbarConfigPage.cxx
index f44bc70d3dc0..d41ecf389e59 100644
--- a/cui/source/customize/SvxNotebookbarConfigPage.cxx
+++ b/cui/source/customize/SvxNotebookbarConfigPage.cxx
@@ -217,7 +217,7 @@ void SvxConfigPage::InsertEntryIntoNotebookbarTabUI(std::u16string_view sClassId
     }
 
     OUString aLabel;
-    for (auto const& prop : std::as_const(aPropSeq))
+    for (auto const& prop : aPropSeq)
         if (prop.Name == "Name")
             prop.Value >>= aLabel;
 
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index f8b452193c0a..ff5702121755 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -492,7 +492,7 @@ void SaveInData::LoadSubMenus( const uno::Reference< container::XIndexAccess >&
                     if ( a >>= aPropSeq )
                     {
                         OUString aMenuLabel;
-                        for ( const beans::PropertyValue& prop : std::as_const(aPropSeq) )
+                        for (const beans::PropertyValue& prop : aPropSeq)
                         {
                             if ( bContextMenu )
                             {
@@ -723,7 +723,7 @@ OUString ContextMenuSaveInData::GetUIName( const OUString& rResourceURL )
         catch ( const css::uno::Exception& )
         {}
 
-        for ( const auto& aProp : std::as_const(aProps) )
+        for (const auto& aProp : aProps)
         {
             if ( aProp.Name == ITEM_DESCRIPTOR_UINAME )
             {
@@ -751,7 +751,7 @@ SvxEntries* ContextMenuSaveInData::GetEntries()
         catch ( const css::lang::IllegalArgumentException& )
         {}
 
-        for ( const auto& aElement : std::as_const(aElementsInfo) )
+        for (const auto& aElement : aElementsInfo)
         {
             OUString aUrl;
             for ( const auto& aElementProp : aElement )
@@ -799,7 +799,7 @@ SvxEntries* ContextMenuSaveInData::GetEntries()
         catch ( const css::lang::IllegalArgumentException& )
         {}
 
-        for ( const auto& aElement : std::as_const(aParentElementsInfo) )
+        for (const auto& aElement : aParentElementsInfo)
         {
             OUString aUrl;
             for ( const auto& aElementProp : aElement )
@@ -1203,7 +1203,7 @@ void SvxConfigPage::Reset( const SfxItemSet* )
                 DBG_UNHANDLED_EXCEPTION("cui.customize");
             }
 
-            for ( uno::Reference < frame::XFrame > const & xf : std::as_const(aFrameList) )
+            for (uno::Reference<frame::XFrame> const& xf : aFrameList)
             {
                 if ( xf.is() && xf != m_xFrame )
                 {
@@ -2001,7 +2001,7 @@ sal_Int32 ToolbarSaveInData::GetSystemStyle( const OUString& rResourceURL )
 
             if ( a >>= aProps )
             {
-                for ( beans::PropertyValue const & prop : std::as_const(aProps) )
+                for (beans::PropertyValue const& prop : aProps)
                 {
                     if ( prop.Name == ITEM_DESCRIPTOR_STYLE )
                     {
@@ -2128,7 +2128,7 @@ OUString ToolbarSaveInData::GetSystemUIName( const OUString& rResourceURL )
 
             if ( a >>= aProps )
             {
-                for ( beans::PropertyValue const & prop : std::as_const(aProps) )
+                for (beans::PropertyValue const& prop : aProps)
                 {
                     if ( prop.Name == ITEM_DESCRIPTOR_UINAME )
                     {
@@ -2155,7 +2155,7 @@ OUString ToolbarSaveInData::GetSystemUIName( const OUString& rResourceURL )
             uno::Sequence< beans::PropertyValue > aPropSeq;
             if ( a >>= aPropSeq )
             {
-                for ( beans::PropertyValue const & prop : std::as_const(aPropSeq) )
+                for (beans::PropertyValue const& prop : aPropSeq)
                 {
                     if ( prop.Name == ITEM_DESCRIPTOR_LABEL )
                     {
@@ -2657,7 +2657,7 @@ void ToolbarSaveInData::LoadToolbar(
                     uno::Sequence< beans::PropertyValue > aPropSeq;
                     if ( a >>= aPropSeq )
                     {
-                        for ( beans::PropertyValue const & prop : std::as_const(aPropSeq) )
+                        for (beans::PropertyValue const& prop : aPropSeq)
                         {
                             if ( prop.Name == "Name" )
                             {
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index 54cdc56d26e1..67bb456b7d61 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -147,7 +147,7 @@ void SvxScriptOrgDialog::Init( std::u16string_view language  )
     }
 
     Reference<XModel> xDocumentModel;
-    for ( const Reference< browse::XBrowseNode >& childNode : std::as_const(children) )
+    for (const Reference<browse::XBrowseNode>& childNode : children)
     {
         bool app = false;
         OUString uiName = childNode->getName();
@@ -178,7 +178,7 @@ void SvxScriptOrgDialog::Init( std::u16string_view language  )
                 } catch(const uno::Exception&)
                     {}
 
-                for ( const beans::PropertyValue& prop : std::as_const(moduleDescr))
+                for (const beans::PropertyValue& prop : moduleDescr)
                 {
                     if ( prop.Name == "ooSetupFactoryEmptyDocumentURL" )
                     {
@@ -278,7 +278,7 @@ void SvxScriptOrgDialog::RequestSubEntries(const weld::TreeIter& rRootEntry, Ref
         // if we catch an exception in getChildNodes then no entries are added
     }
 
-    for ( const Reference< browse::XBrowseNode >& childNode : std::as_const(children) )
+    for (const Reference<browse::XBrowseNode>& childNode : children)
     {
         OUString name( childNode->getName() );
         if (  childNode->getType() !=  browse::BrowseNodeTypes::SCRIPT)
@@ -751,7 +751,7 @@ void SvxScriptOrgDialog::createEntry(const weld::TreeIter& rEntry)
                 if(extnPos>0)
                     extn = nodeName.copy(extnPos);
             }
-            for( const Reference< browse::XBrowseNode >& n : std::as_const(childNodes) )
+            for (const Reference<browse::XBrowseNode>& n : childNodes)
             {
                 if (Concat2View(aNewName+extn) == n->getName())
                 {
@@ -778,7 +778,7 @@ void SvxScriptOrgDialog::createEntry(const weld::TreeIter& rEntry)
             {
                 OUString aUserSuppliedName = aNewDlg.GetObjectName();
                 bValid = true;
-                for( const Reference< browse::XBrowseNode >& n : std::as_const(childNodes) )
+                for (const Reference<browse::XBrowseNode>& n : childNodes)
                 {
                     if (Concat2View(aUserSuppliedName+extn) == n->getName())
                     {
diff --git a/cui/source/options/certpath.cxx b/cui/source/options/certpath.cxx
index 91526e587cbd..5cccccf1995c 100644
--- a/cui/source/options/certpath.cxx
+++ b/cui/source/options/certpath.cxx
@@ -60,7 +60,7 @@ void CertPathDialog::Init()
             "thunderbird"
         };
 
-        for (const auto& rNSSProfile : std::as_const(aProductList))
+        for (const auto& rNSSProfile : aProductList)
         {
             if (rNSSProfile.Type == mozilla::MozillaProductType_Default)
             {
diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index f95015c03025..4ec9bd987462 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -647,7 +647,7 @@ SvxLinguData_Impl::SvxLinguData_Impl() :
     }
 
     Sequence< OUString > aCfgSvcs;
-    for(auto const & locale : std::as_const(aAllServiceLocales))
+    for (auto const& locale : aAllServiceLocales)
     {
         LanguageType nLang = LanguageTag::convertToLanguageType( locale );