diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 09:07:25 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 23:42:26 +0000 |
| commit | 309574394bd4ae3e9e10e5ff0d64bdd7bbbc8b83 (patch) | |
| tree | f8b8cea0a81bc74ca34e8bda2d0dfce939b28ce0 /cui | |
| parent | 20deac4903fc0697477e855feeff482b3da234f9 (diff) | |
callcatcher: large newly detected unused methods post de-virtualization
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
Diffstat (limited to 'cui')
| -rw-r--r-- | cui/source/factory/dlgfact.cxx | 9 | ||||
| -rw-r--r-- | cui/source/factory/dlgfact.hxx | 5 |
2 files changed, 1 insertions, 13 deletions
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx index 63d3c7140a8a..69ebc3a696c2 100644 --- a/cui/source/factory/dlgfact.cxx +++ b/cui/source/factory/dlgfact.cxx @@ -1273,15 +1273,6 @@ AbstractSvxHlinkDlgMarkWnd* AbstractDialogFactory_Impl::CreateSvxHlinkDlgMarkWnd return 0; } -SfxAbstractDialog* AbstractDialogFactory_Impl::CreateSfxDialog( sal_uInt32, - vcl::Window* pParent, - const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XFrame >& , - const SfxItemSet* pAttrSet ) -{ - SfxModalDialog* pDlg = new SvxCharacterMap( pParent, true, pAttrSet ); - return new CuiAbstractSfxDialog_Impl( pDlg ); -} - SfxAbstractTabDialog* AbstractDialogFactory_Impl::CreateTabItemDialog(vcl::Window* pParent, const SfxItemSet& rSet) { diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx index 0f12a217a8af..6737b94803b0 100644 --- a/cui/source/factory/dlgfact.hxx +++ b/cui/source/factory/dlgfact.hxx @@ -511,10 +511,7 @@ class AbstractDialogFactory_Impl : public SvxAbstractDialogFactory public: virtual VclAbstractDialog* CreateVclDialog( vcl::Window* pParent, sal_uInt32 nResId ) SAL_OVERRIDE; virtual VclAbstractDialog* CreateSfxDialog( vcl::Window* pParent, const SfxBindings& rBindings, sal_uInt32 nResId ) SAL_OVERRIDE; - SfxAbstractDialog* CreateSfxDialog( sal_uInt32 nResId, - vcl::Window* pParent, - const ::com::sun::star::uno::Reference< ::com::sun::star::frame::XFrame >& xViewFrame, - const SfxItemSet* pAttrSet=0 ); + virtual SfxAbstractDialog* CreateSfxDialog( vcl::Window* pParent, const SfxItemSet& rAttr, const SdrView* pView, |