diff options
| author | Noel Grandin <noel@peralex.com> | 2016-03-17 15:21:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-03-18 08:33:50 +0000 |
| commit | dd351c8524b270d1fd0f61998e10dba0ccd624b6 (patch) | |
| tree | 9258389b18dfa876636cf4cc468672f79c95a0a9 /dbaccess/source/core/api/SingleSelectQueryComposer.cxx | |
| parent | 4f250922ac59142e6e35e5663ffeefcc14052073 (diff) | |
loplugin:constantparam in dbaccess
Change-Id: Icfe7d3d4630f4b5b3b2491ba56245257bad31bb8
Reviewed-on: https://gerrit.libreoffice.org/23349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'dbaccess/source/core/api/SingleSelectQueryComposer.cxx')
| -rw-r--r-- | dbaccess/source/core/api/SingleSelectQueryComposer.cxx | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx index f97daac96524..693e589621c9 100644 --- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx +++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx @@ -508,7 +508,7 @@ OUString OSingleSelectQueryComposer::impl_getColumnRealName_throw(const Referenc return aNewName; } -OUString OSingleSelectQueryComposer::impl_getColumnName_throw(const Reference< XPropertySet >& column, bool bOrderBy) +OUString OSingleSelectQueryComposer::impl_getColumnNameOrderBy_throw(const Reference< XPropertySet >& column) { ::connectivity::checkDisposed(OSubComponent::rBHelper.bDisposed); @@ -537,8 +537,7 @@ OUString OSingleSelectQueryComposer::impl_getColumnName_throw(const Reference< X // Nope, it is an unrelated column. // Is that supported? - if ( bOrderBy && - !m_xMetaData->supportsOrderByUnrelated() ) + if ( !m_xMetaData->supportsOrderByUnrelated() ) { OUString sError(DBACORE_RESSTRING(RID_STR_COLUMN_MUST_VISIBLE)); throw SQLException(sError.replaceAll("%name", aName),*this,SQLSTATE_GENERAL,1000,Any() ); @@ -551,7 +550,7 @@ OUString OSingleSelectQueryComposer::impl_getColumnName_throw(const Reference< X void SAL_CALL OSingleSelectQueryComposer::appendOrderByColumn( const Reference< XPropertySet >& column, sal_Bool ascending ) throw(SQLException, RuntimeException, std::exception) { ::osl::MutexGuard aGuard( m_aMutex ); - OUString sColumnName( impl_getColumnName_throw(column, true) ); + OUString sColumnName( impl_getColumnNameOrderBy_throw(column) ); OUString sOrder = getOrder(); if ( !(sOrder.isEmpty() || sColumnName.isEmpty()) ) sOrder += COMMA; |