diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-28 15:09:33 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-29 09:05:18 +0200 |
| commit | 4c91b89d8ce9c34179f31854dc88bd0a9fa84cba (patch) | |
| tree | 1fe9cc9db455779d33c24320fedc1e25888b3e5c /dbaccess/source/ext | |
| parent | a1f31211920bfae1a21ea375fa5280c9c6595e15 (diff) | |
new loplugin:oustringbuffer
look for places where we are appending the temporary result of adding
strings together, to an OUStringBuffer, where we could rather call
append repeatedly and avoid the temporary creation
Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82
Reviewed-on: https://gerrit.libreoffice.org/59708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess/source/ext')
| -rw-r--r-- | dbaccess/source/ext/macromigration/migrationlog.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/dbaccess/source/ext/macromigration/migrationlog.cxx b/dbaccess/source/ext/macromigration/migrationlog.cxx index 6a0b71b12bfe..13953894bf8b 100644 --- a/dbaccess/source/ext/macromigration/migrationlog.cxx +++ b/dbaccess/source/ext/macromigration/migrationlog.cxx @@ -382,8 +382,8 @@ namespace dbmm OUString sBackedUp( DBA_RES( STR_SAVED_COPY_TO ) ); sBackedUp = sBackedUp.replaceAll( "$location$", m_pData->sBackupLocation ); - aBuffer.append( "=== " + DBA_RES( STR_DATABASE_DOCUMENT ) - + " ===\n" + sBackedUp + "\n\n"); + aBuffer.append( "=== " ).append( DBA_RES( STR_DATABASE_DOCUMENT ) ) + .append( " ===\n" ).append( sBackedUp ).append("\n\n"); } if ( !m_pData->aFailures.empty() ) @@ -405,7 +405,7 @@ namespace dbmm OUString sDocTitle( DBA_RES( rDoc.eType == eForm ? STR_FORM : STR_REPORT ) ); sDocTitle = sDocTitle.replaceAll( "$name$", rDoc.sName ); - aBuffer.append( "=== " + sDocTitle + " ===\n" ); + aBuffer.append( "=== " ).append( sDocTitle ).append( " ===\n" ); for (auto const& elem : rDoc.aMovedLibraries) { @@ -414,7 +414,7 @@ namespace dbmm sMovedLib = sMovedLib.replaceAll( "$old$", elem.sOldName ); sMovedLib = sMovedLib.replaceAll( "$new$", elem.sNewName ); - aBuffer.append( sMovedLib + "\n" ); + aBuffer.append( sMovedLib ).append( "\n" ); } aBuffer.append( '\n' ); |