diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-03 14:55:29 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-03 14:13:57 +0100 |
| commit | 2a3f5d11522cd69f0ce221cde3a63b7e85e94b53 (patch) | |
| tree | 51a9483a42769f64fff5b329af6604cdf5a5f7ff /dbaccess/source/ui/app | |
| parent | e73bf95c00168bbf7d312cd11c40d0581ebd928e (diff) | |
tdf#120703 PVS: V547 Expression is always true/false
Change-Id: I856345576ff5c10a41509a97ad4539272bd55568
Reviewed-on: https://gerrit.libreoffice.org/62803
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'dbaccess/source/ui/app')
| -rw-r--r-- | dbaccess/source/ui/app/AppDetailPageHelper.cxx | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/dbaccess/source/ui/app/AppDetailPageHelper.cxx b/dbaccess/source/ui/app/AppDetailPageHelper.cxx index 496e5f1de0ac..afeafa35d8cf 100644 --- a/dbaccess/source/ui/app/AppDetailPageHelper.cxx +++ b/dbaccess/source/ui/app/AppDetailPageHelper.cxx @@ -854,23 +854,13 @@ void OAppDetailPageHelper::elementRemoved( ElementType _eType,const OUString& _r static_cast< OTableTreeListBox* >( pTreeView )->removedTable( _rName ); break; case E_QUERY: - if ( pTreeView ) - { - SvTreeListEntry* pEntry = lcl_findEntry_impl(*pTreeView,_rName,pTreeView->First()); - if ( pEntry ) - pTreeView->GetModel()->Remove(pEntry); - } + if (auto pEntry = lcl_findEntry_impl(*pTreeView, _rName, pTreeView->First())) + pTreeView->GetModel()->Remove(pEntry); break; case E_FORM: case E_REPORT: - { - if ( pTreeView ) - { - SvTreeListEntry* pEntry = lcl_findEntry(*pTreeView,_rName,pTreeView->First()); - if ( pEntry ) - pTreeView->GetModel()->Remove(pEntry); - } - } + if (auto pEntry = lcl_findEntry(*pTreeView, _rName, pTreeView->First())) + pTreeView->GetModel()->Remove(pEntry); break; default: OSL_FAIL("Invalid element type"); |