diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-04 14:34:07 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-11 09:48:10 +0200 |
commit | 49eb02f07a5af44da59008a238e828b4a9532bef (patch) | |
tree | 43c4b4eaacd79fe0bff784a4ef71f4c1080c3912 /dbaccess/source/ui/dlg/generalpage.cxx | |
parent | 5823ecd54b16974ffe8821a5ae061cd0ecc4cf84 (diff) |
new loplugin:unusedvariablemore
collection of heuristics to look for local variables that are never read
from i.e. do not contribute to the surrounding logic
This is an expensive plugin, since it walks up the parent tree,
so it is off by default.
Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06
Reviewed-on: https://gerrit.libreoffice.org/52450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess/source/ui/dlg/generalpage.cxx')
-rw-r--r-- | dbaccess/source/ui/dlg/generalpage.cxx | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/dbaccess/source/ui/dlg/generalpage.cxx b/dbaccess/source/ui/dlg/generalpage.cxx index d62403e56da8..6dbfbe6d1285 100644 --- a/dbaccess/source/ui/dlg/generalpage.cxx +++ b/dbaccess/source/ui/dlg/generalpage.cxx @@ -238,17 +238,6 @@ namespace dbaui getFlags( _rSet, bValid, bReadonly ); // if the selection is invalid, disable everything - OUString sName,sConnectURL; - if ( bValid ) - { - // collect some items and some values - const SfxStringItem* pNameItem = _rSet.GetItem<SfxStringItem>(DSID_NAME); - const SfxStringItem* pUrlItem = _rSet.GetItem<SfxStringItem>(DSID_CONNECTURL); - assert( pUrlItem ); - assert( pNameItem ); - sName = pNameItem->GetValue(); - sConnectURL = pUrlItem->GetValue(); - } implSetCurrentType( OUString() ); @@ -281,15 +270,12 @@ namespace dbaui getFlags( _rSet, bValid, bReadonly ); // if the selection is invalid, disable everything - OUString sName,sConnectURL; + OUString sConnectURL; if ( bValid ) { // collect some items and some values - const SfxStringItem* pNameItem = _rSet.GetItem<SfxStringItem>(DSID_NAME); const SfxStringItem* pUrlItem = _rSet.GetItem<SfxStringItem>(DSID_CONNECTURL); assert( pUrlItem ); - assert( pNameItem ); - sName = pNameItem->GetValue(); sConnectURL = pUrlItem->GetValue(); } |