Simplify containers iterations in dbaccess

Use range-based loop or replace with STL functions

Change-Id: I01b4d97fa77ef8daf88e8e006b9523a6b71786cf
Reviewed-on: https://gerrit.libreoffice.org/68286
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 2 insertions, 7 deletions

diff --git a/dbaccess/source/ui/dlg/indexfieldscontrol.cxx b/dbaccess/source/ui/dlg/indexfieldscontrol.cxx
index 3b0d83ed2403..27beb4654d78 100644
--- a/dbaccess/source/ui/dlg/indexfieldscontrol.cxx
+++ b/dbaccess/source/ui/dlg/indexfieldscontrol.cxx
@@ -166,13 +166,8 @@ static constexpr auto BROWSER_STANDARD_FLAGS = BrowserMode::COLUMNSELECTION | Br
     {
         // do not just copy the array, we may have empty field names (which should not be copied)
         _rFields.resize(m_aFields.size());
-        IndexFields::iterator aDest = _rFields.begin();
-        for (auto const& source : m_aFields)
-            if (!source.sFieldName.isEmpty())
-            {
-                *aDest = source;
-                ++aDest;
-            }
+        IndexFields::iterator aDest = std::copy_if(m_aFields.begin(), m_aFields.end(), _rFields.begin(),
+            [](const OIndexField& source) { return !source.sFieldName.isEmpty(); });
 
         _rFields.resize(aDest - _rFields.begin());
     }