clang-tidy modernize-pass-by-value in dbaccess

Change-Id: I8f89ec8a73f82fd93320a710165df17180939f96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135731
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 28 insertions, 21 deletions

diff --git a/dbaccess/source/ui/dlg/CollectionView.cxx b/dbaccess/source/ui/dlg/CollectionView.cxx
index 2e02fda505e0..56fd5f6f5b93 100644
--- a/dbaccess/source/ui/dlg/CollectionView.cxx
+++ b/dbaccess/source/ui/dlg/CollectionView.cxx
@@ -42,6 +42,7 @@
 #include <ucbhelper/commandenvironment.hxx>
 #include <ucbhelper/content.hxx>
 #include <connectivity/dbexception.hxx>
+#include <utility>
 
 namespace dbaui
 {
@@ -58,10 +59,10 @@ using namespace comphelper;
 OCollectionView::OCollectionView(weld::Window* pParent,
                                  const Reference< XContent>& _xContent,
                                  const OUString& _sDefaultName,
-                                 const css::uno::Reference< css::uno::XComponentContext >& _rxContext)
+                                 css::uno::Reference< css::uno::XComponentContext > _xContext)
     : GenericDialogController(pParent, "dbaccess/ui/collectionviewdialog.ui", "CollectionView")
     , m_xContent(_xContent)
-    , m_xContext(_rxContext)
+    , m_xContext(std::move(_xContext))
     , m_bCreateForm(true)
     , m_xFTCurrentPath(m_xBuilder->weld_label("currentPathLabel"))
     , m_xNewFolder(m_xBuilder->weld_button("newFolderButton"))
diff --git a/dbaccess/source/ui/dlg/dbfindex.cxx b/dbaccess/source/ui/dlg/dbfindex.cxx
index 89f74ab72b97..061486e91201 100644
--- a/dbaccess/source/ui/dlg/dbfindex.cxx
+++ b/dbaccess/source/ui/dlg/dbfindex.cxx
@@ -29,6 +29,7 @@
 #include <ucbhelper/content.hxx>
 #include <svl/filenotation.hxx>
 #include <rtl/strbuf.hxx>
+#include <utility>
 
 namespace dbaui
 {
@@ -39,9 +40,9 @@ using namespace ::svt;
 constexpr OStringLiteral aGroupIdent("dBase III");
 
 
-ODbaseIndexDialog::ODbaseIndexDialog(weld::Window * pParent, const OUString& aDataSrcName)
+ODbaseIndexDialog::ODbaseIndexDialog(weld::Window * pParent, OUString aDataSrcName)
     : GenericDialogController(pParent, "dbaccess/ui/dbaseindexdialog.ui", "DBaseIndexDialog")
-    , m_aDSN(aDataSrcName)
+    , m_aDSN(std::move(aDataSrcName))
     , m_xPB_OK(m_xBuilder->weld_button("ok"))
     , m_xCB_Tables(m_xBuilder->weld_combo_box("table"))
     , m_xIndexes(m_xBuilder->weld_widget("frame"))
diff --git a/dbaccess/source/ui/dlg/dbfindex.hxx b/dbaccess/source/ui/dlg/dbfindex.hxx
index 53b75640e6f4..0db7ea7b04a6 100644
--- a/dbaccess/source/ui/dlg/dbfindex.hxx
+++ b/dbaccess/source/ui/dlg/dbfindex.hxx
@@ -19,6 +19,7 @@
 
 #pragma once
 
+#include <utility>
 #include <vcl/weld.hxx>
 #include <deque>
 
@@ -34,7 +35,7 @@ private:
 
 public:
     OTableIndex() { }
-    explicit OTableIndex( const OUString& rFileName ) : aIndexFileName( rFileName ) { }
+    explicit OTableIndex( OUString aFileName ) : aIndexFileName(std::move( aFileName )) { }
 
     const OUString& GetIndexFileName() const { return aIndexFileName; }
 };
@@ -53,7 +54,7 @@ private:
     TableIndexList aIndexList;
 
 public:
-    explicit OTableInfo( const OUString& rName ) : aTableName(rName) { }
+    explicit OTableInfo( OUString aName ) : aTableName(std::move(aName)) { }
 
     void WriteInfFile( const OUString& rDSN ) const;
 };
@@ -101,7 +102,7 @@ protected:
     void checkButtons();
 
 public:
-    ODbaseIndexDialog(weld::Window * pParent, const OUString& rDataSrcName);
+    ODbaseIndexDialog(weld::Window * pParent, OUString aDataSrcName);
     virtual ~ODbaseIndexDialog() override;
 };
 
diff --git a/dbaccess/source/ui/dlg/dbwizsetup.cxx b/dbaccess/source/ui/dlg/dbwizsetup.cxx
index f687740dd696..bf794ac3892c 100644
--- a/dbaccess/source/ui/dlg/dbwizsetup.cxx
+++ b/dbaccess/source/ui/dlg/dbwizsetup.cxx
@@ -63,6 +63,7 @@
 #include <tools/diagnose_ex.h>
 #include <osl/diagnose.h>
 #include <connectivity/DriversConfig.hxx>
+#include <utility>
 
 namespace dbaui
 {
@@ -858,7 +859,7 @@ bool ODbTypeWizDialogSetup::SaveDatabaseDocument()
             OAsynchronousLink                    m_aAsyncCaller;
 
         public:
-            AsyncLoader( const Reference< XComponentContext >& _rxORB, const OUString& _rURL );
+            AsyncLoader( const Reference< XComponentContext >& _xORB, OUString _aURL );
 
             void doLoadAsync();
 
@@ -872,8 +873,8 @@ bool ODbTypeWizDialogSetup::SaveDatabaseDocument()
             DECL_LINK( OnOpenDocument, void*, void );
         };
 
-        AsyncLoader::AsyncLoader( const Reference< XComponentContext >& _rxORB, const OUString& _rURL )
-            :m_sURL( _rURL )
+        AsyncLoader::AsyncLoader( const Reference< XComponentContext >& _rxORB, OUString _aURL )
+            :m_sURL(std::move( _aURL ))
             ,m_aAsyncCaller( LINK( this, AsyncLoader, OnOpenDocument ) )
         {
             try
diff --git a/dbaccess/source/ui/dlg/dlgsave.cxx b/dbaccess/source/ui/dlg/dlgsave.cxx
index ce5d16881f1d..18c8a1512cb6 100644
--- a/dbaccess/source/ui/dlg/dlgsave.cxx
+++ b/dbaccess/source/ui/dlg/dlgsave.cxx
@@ -27,6 +27,7 @@
 #include <SqlNameEdit.hxx>
 #include <com/sun/star/sdbc/XDatabaseMetaData.hpp>
 #include <objectnamecheck.hxx>
+#include <utility>
 #include <tools/diagnose_ex.h>
 
 using namespace dbaui;
@@ -64,11 +65,11 @@ public:
 
     OSaveAsDlgImpl( weld::Builder* pParent, sal_Int32 _rType,
                     const css::uno::Reference< css::sdbc::XConnection>& _xConnection,
-                    const OUString& rDefault,
+                    OUString sDefault,
                     const IObjectNameCheck& _rObjectNameCheck,
                     SADFlags _nFlags);
     OSaveAsDlgImpl( weld::Builder* pParent,
-                    const OUString& rDefault,
+                    OUString sDefault,
                     const IObjectNameCheck& _rObjectNameCheck,
                     SADFlags _nFlags);
 };
@@ -86,12 +87,12 @@ IMPL_LINK(OSaveAsDlgImpl, TextFilterHdl, OUString&, rTest, bool)
 OSaveAsDlgImpl::OSaveAsDlgImpl(weld::Builder* pBuilder,
                                sal_Int32 _rType,
                                const Reference< XConnection>& _xConnection,
-                               const OUString& rDefault,
+                               OUString sDefault,
                                const IObjectNameCheck& _rObjectNameCheck,
                                SADFlags _nFlags)
     : m_aQryLabel(DBA_RES(STR_QRY_LABEL))
     , m_sTblLabel(DBA_RES(STR_TBL_LABEL))
-    , m_aName(rDefault)
+    , m_aName(std::move(sDefault))
     , m_rObjectNameCheck( _rObjectNameCheck )
     , m_nType(_rType)
     , m_nFlags(_nFlags)
@@ -120,12 +121,12 @@ OSaveAsDlgImpl::OSaveAsDlgImpl(weld::Builder* pBuilder,
 }
 
 OSaveAsDlgImpl::OSaveAsDlgImpl(weld::Builder* pBuilder,
-                               const OUString& rDefault,
+                               OUString sDefault,
                                const IObjectNameCheck& _rObjectNameCheck,
                                SADFlags _nFlags)
     : m_aQryLabel(DBA_RES(STR_QRY_LABEL))
     , m_sTblLabel(DBA_RES(STR_TBL_LABEL))
-    , m_aName(rDefault)
+    , m_aName(std::move(sDefault))
     , m_rObjectNameCheck( _rObjectNameCheck )
     , m_nType(CommandType::COMMAND)
     , m_nFlags(_nFlags)
diff --git a/dbaccess/source/ui/dlg/generalpage.cxx b/dbaccess/source/ui/dlg/generalpage.cxx
index 5809b7bd7088..f2a11bfc9b24 100644
--- a/dbaccess/source/ui/dlg/generalpage.cxx
+++ b/dbaccess/source/ui/dlg/generalpage.cxx
@@ -25,6 +25,7 @@
 #include <dsitems.hxx>
 #include <sfx2/filedlghelper.hxx>
 #include <sfx2/docfilt.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
 #include <svl/stritem.hxx>
@@ -76,7 +77,7 @@ namespace dbaui
             OUString eType;
             OUString sDisplayName;
 
-            DisplayedType( const OUString& _eType, const OUString& _rDisplayName ) : eType( _eType ), sDisplayName( _rDisplayName ) { }
+            DisplayedType( OUString _eType, OUString _sDisplayName ) : eType(std::move( _eType )), sDisplayName(std::move( _sDisplayName )) { }
         };
         typedef std::vector< DisplayedType > DisplayedTypes;
 
diff --git a/dbaccess/source/ui/dlg/sqlmessage.cxx b/dbaccess/source/ui/dlg/sqlmessage.cxx
index eacc5908328d..81fa5100d0ef 100644
--- a/dbaccess/source/ui/dlg/sqlmessage.cxx
+++ b/dbaccess/source/ui/dlg/sqlmessage.cxx
@@ -22,6 +22,7 @@
 #include <strings.hrc>
 #include <com/sun/star/sdbc/SQLException.hpp>
 #include <com/sun/star/sdb/SQLContext.hpp>
+#include <utility>
 #include <vcl/stdtext.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
@@ -50,8 +51,8 @@ namespace
         OUString m_defaultImageID;
 
     public:
-        explicit ImageProvider(const OUString& defaultImageID)
-            : m_defaultImageID(defaultImageID)
+        explicit ImageProvider(OUString defaultImageID)
+            : m_defaultImageID(std::move(defaultImageID))
         {
         }
 
@@ -555,9 +556,9 @@ void OSQLMessageBox::Construct(weld::Window* pParent, MessBoxStyle _nStyle, Mess
     impl_addDetailsButton();
 }
 
-OSQLMessageBox::OSQLMessageBox(weld::Window* pParent, const SQLExceptionInfo& rException, MessBoxStyle nStyle, const OUString& rHelpURL)
+OSQLMessageBox::OSQLMessageBox(weld::Window* pParent, const SQLExceptionInfo& rException, MessBoxStyle nStyle, OUString sHelpURL)
     : m_pImpl(new SQLMessageBox_Impl(rException))
-    , m_sHelpURL(rHelpURL)
+    , m_sHelpURL(std::move(sHelpURL))
 {
     Construct(pParent, nStyle, AUTO);
 }