loplugin:stringviewparam extend to comparison operators

which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"

Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 15 insertions, 15 deletions

diff --git a/dbaccess/source/ui/inc/FieldDescControl.hxx b/dbaccess/source/ui/inc/FieldDescControl.hxx
index c467d4ca5402..f321276827b0 100644
--- a/dbaccess/source/ui/inc/FieldDescControl.hxx
+++ b/dbaccess/source/ui/inc/FieldDescControl.hxx
@@ -145,7 +145,7 @@ namespace dbaui
         virtual bool                            isAutoIncrementValueEnabled() const = 0;
         virtual OUString                        getAutoIncrementValue() const = 0;
 
-        OUString                                BoolStringPersistent(const OUString& rUIString) const;
+        OUString                                BoolStringPersistent(std::u16string_view rUIString) const;
         OUString                                BoolStringUI(const OUString& rPersistentString) const;
 
         const OPropColumnEditCtrl*              getColumnCtrl() const { return m_xColumnName.get(); }
diff --git a/dbaccess/source/ui/inc/QueryDesignView.hxx b/dbaccess/source/ui/inc/QueryDesignView.hxx
index 8bcb0f58e1a0..efef444e8670 100644
--- a/dbaccess/source/ui/inc/QueryDesignView.hxx
+++ b/dbaccess/source/ui/inc/QueryDesignView.hxx
@@ -105,12 +105,12 @@ namespace dbaui
         const OUString&               getDecimalSeparator() const { return m_sDecimalSep;}
 
         SqlParseError   InsertField( const OTableFieldDescRef& rInfo, bool bActivate = true);
-        bool            HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef const & rInfo) const;
+        bool            HasFieldByAliasName(std::u16string_view rFieldName, OTableFieldDescRef const & rInfo) const;
         // called when a table from tabview was deleted
         void TableDeleted(const OUString& rAliasName);
 
         sal_Int32 getColWidth( sal_uInt16 _nColPos) const;
-        void fillValidFields(const OUString& strTableName, weld::ComboBox& rFieldList);
+        void fillValidFields(std::u16string_view strTableName, weld::ComboBox& rFieldList);
 
         void SaveUIConfig();
         void stopTimer();
diff --git a/dbaccess/source/ui/inc/TableCopyHelper.hxx b/dbaccess/source/ui/inc/TableCopyHelper.hxx
index 3d39d368307e..92ddceb37507 100644
--- a/dbaccess/source/ui/inc/TableCopyHelper.hxx
+++ b/dbaccess/source/ui/inc/TableCopyHelper.hxx
@@ -96,7 +96,7 @@ namespace dbaui
                 The name of the dest data source.
         */
         void pasteTable( const TransferableDataHelper& _rTransData
-                        ,const OUString& _sDestDataSourceName
+                        ,std::u16string_view _sDestDataSourceName
                         ,const SharedConnection& _xConnection);
 
         /** pastes a table into the data source
@@ -109,7 +109,7 @@ namespace dbaui
         */
         void pasteTable( SotClipboardFormatId _nFormatId
                         ,const TransferableDataHelper& _rTransData
-                        ,const OUString& _sDestDataSourceName
+                        ,std::u16string_view _sDestDataSourceName
                         ,const SharedConnection& _xConnection);
 
         /** copies a table which was constructed by tags like HTML or RTF
@@ -133,7 +133,7 @@ namespace dbaui
                 The connection
         */
         void asyncCopyTagTable(  DropDescriptor& _rDesc
-                                ,const OUString& _sDestDataSourceName
+                                ,std::u16string_view _sDestDataSourceName
                                 ,const SharedConnection& _xConnection);
 
         /** copies a table which was constructed by tags like HTML or RTF
@@ -164,21 +164,21 @@ namespace dbaui
         */
         void pasteTable(
             const svx::ODataAccessDescriptor& _rPasteData,
-            const OUString& _sDestDataSourceName,
+            std::u16string_view _sDestDataSourceName,
             const SharedConnection& _xDestConnection
         );
 
         /** insert a table into the data source. The source can either be a table or a query
         */
         void insertTable(
-            const OUString& i_rSourceDataSource,
+            std::u16string_view i_rSourceDataSource,
             const css::uno::Reference< css::sdbc::XConnection>& i_rSourceConnection,
             const OUString& i_rCommand,
             const sal_Int32 i_nCommandType,
             const css::uno::Reference< css::sdbc::XResultSet >& i_rSourceRows,
             const css::uno::Sequence< css::uno::Any >& i_rSelection,
             const bool i_bBookmarkSelection,
-            const OUString& i_rDestDataSource,
+            std::u16string_view i_rDestDataSource,
             const css::uno::Reference< css::sdbc::XConnection>& i_rDestConnection
         );
 
diff --git a/dbaccess/source/ui/inc/WColumnSelect.hxx b/dbaccess/source/ui/inc/WColumnSelect.hxx
index 405ac7f31c2b..706ccfd0371c 100644
--- a/dbaccess/source/ui/inc/WColumnSelect.hxx
+++ b/dbaccess/source/ui/inc/WColumnSelect.hxx
@@ -64,7 +64,7 @@ namespace dbaui
         void enableButtons();
 
         sal_Int32 adjustColumnPosition(weld::TreeView const * _pLeft,
-                                    const OUString&  _sColumnName,
+                                    std::u16string_view  _sColumnName,
                                     ODatabaseExport::TColumnVector::size_type nCurrentPos,
                                     const ::comphelper::UStringMixEqual& _aCase);
 
diff --git a/dbaccess/source/ui/inc/dbtreelistbox.hxx b/dbaccess/source/ui/inc/dbtreelistbox.hxx
index af68b9e9b8d7..4838e5c74d10 100644
--- a/dbaccess/source/ui/inc/dbtreelistbox.hxx
+++ b/dbaccess/source/ui/inc/dbtreelistbox.hxx
@@ -90,7 +90,7 @@ namespace dbaui
         TreeListBox(std::unique_ptr<weld::TreeView> xTreeView, bool bSQLType);
         virtual ~TreeListBox();
 
-        std::unique_ptr<weld::TreeIter> GetEntryPosByName(const OUString& rName,
+        std::unique_ptr<weld::TreeIter> GetEntryPosByName(std::u16string_view rName,
                                                           const weld::TreeIter* pStart = nullptr,
                                                           const IEntryFilter* pFilter = nullptr) const;
 
diff --git a/dbaccess/source/ui/inc/queryfilter.hxx b/dbaccess/source/ui/inc/queryfilter.hxx
index 258dcc51ec08..396778f22997 100644
--- a/dbaccess/source/ui/inc/queryfilter.hxx
+++ b/dbaccess/source/ui/inc/queryfilter.hxx
@@ -75,13 +75,13 @@ namespace dbaui
         std::unique_ptr<weld::ComboBox> m_xLB_WHERECOMP3;
         std::unique_ptr<weld::Entry> m_xET_WHEREVALUE3;
 
-        static void SelectField(weld::ComboBox& rBox, const OUString& rField);
+        static void SelectField(weld::ComboBox& rBox, std::u16string_view rField);
         DECL_LINK(ListSelectHdl, weld::ComboBox&, void);
         DECL_LINK(ListSelectCompHdl, weld::ComboBox&, void);
 
         void            SetLine( int nIdx, const css::beans::PropertyValue& _rItem, bool _bOr );
         void            EnableLines();
-        sal_Int32       GetOSQLPredicateType( const OUString& _rSelectedPredicate ) const;
+        sal_Int32       GetOSQLPredicateType( std::u16string_view _rSelectedPredicate ) const;
         static sal_Int32  GetSelectionPos(sal_Int32 eType, const weld::ComboBox& rListBox);
         bool            getCondition(const weld::ComboBox& _rField, const weld::ComboBox& _rComp, const weld::Entry& _rValue, css::beans::PropertyValue& _rFilter) const;
         void            fillLines(int &i, const css::uno::Sequence< css::uno::Sequence< css::beans::PropertyValue > >& _aValues);
diff --git a/dbaccess/source/ui/inc/unodatbr.hxx b/dbaccess/source/ui/inc/unodatbr.hxx
index e147b44b9e02..637f173da20e 100644
--- a/dbaccess/source/ui/inc/unodatbr.hxx
+++ b/dbaccess/source/ui/inc/unodatbr.hxx
@@ -268,7 +268,7 @@ namespace dbaui
         void    implAddDatasource( const OUString& _rDataSourceName, const SharedConnection& _rxConnection );
 
         /// removes (and cleans up) the entry for the given data source
-        void        impl_cleanupDataSourceEntry( const OUString& _rDataSourceName );
+        void        impl_cleanupDataSourceEntry( std::u16string_view _rDataSourceName );
 
         /// clears the tree list box
         void clearTreeModel();
@@ -430,7 +430,7 @@ namespace dbaui
             @return
                     <TRUE/> if it is the currently displayed otherwise <FALSE/>
         */
-        bool isCurrentlyDisplayedChanged(const OUString& rName, const weld::TreeIter& rContainer);
+        bool isCurrentlyDisplayedChanged(std::u16string_view rName, const weld::TreeIter& rContainer);
 
         /** called whenever the content of the browser is used for preview, as the very last action
             of the load process