diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-28 11:28:52 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-28 17:22:52 +0200 |
commit | d407304544cdb2edc3cbdb4e56d49f3ceda79c38 (patch) | |
tree | 765668628540687b669d67b14d824adb893c1308 /dbaccess/source/ui/misc/WCopyTable.cxx | |
parent | fa87224130a4ab6c4b79f993cc990adc4be0465b (diff) |
loplugin:stringloop cui,dbaccess
Change-Id: I32b63d2435d36b869823ea022ebd7f8347a46ea0
Reviewed-on: https://gerrit.libreoffice.org/58211
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess/source/ui/misc/WCopyTable.cxx')
-rw-r--r-- | dbaccess/source/ui/misc/WCopyTable.cxx | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/dbaccess/source/ui/misc/WCopyTable.cxx b/dbaccess/source/ui/misc/WCopyTable.cxx index ca58612c2c81..35b9df1de937 100644 --- a/dbaccess/source/ui/misc/WCopyTable.cxx +++ b/dbaccess/source/ui/misc/WCopyTable.cxx @@ -158,7 +158,7 @@ void ObjectCopySource::copyFilterAndSortingTo( const Reference< XConnection >& _ const OUString sTargetName = ::dbtools::composeTableNameForSelect(_xConnection,_rxObject); const OUString sTargetNameTemp = sTargetName + "."; - OUString sStatement = "SELECT * FROM " + sTargetName + " WHERE 0=1"; + OUStringBuffer sStatement = "SELECT * FROM " + sTargetName + " WHERE 0=1"; for (const std::pair<OUString,OUString> & aPropertie : aProperties) { @@ -168,17 +168,17 @@ void ObjectCopySource::copyFilterAndSortingTo( const Reference< XConnection >& _ m_xObject->getPropertyValue( aPropertie.first ) >>= sFilter; if ( !sFilter.isEmpty() ) { - sStatement += aPropertie.second; + sStatement.append(aPropertie.second); OUString sReplace = sFilter; sReplace = sReplace.replaceFirst(sSourceName,sTargetNameTemp); sFilter = sReplace; _rxObject->setPropertyValue( aPropertie.first, makeAny(sFilter) ); - sStatement += sFilter; + sStatement.append(sFilter); } } } - _xConnection->createStatement()->executeQuery(sStatement); + _xConnection->createStatement()->executeQuery(sStatement.makeStringAndClear()); if ( m_xObjectPSI->hasPropertyByName( PROPERTY_APPLYFILTER ) ) _rxObject->setPropertyValue( PROPERTY_APPLYFILTER, m_xObject->getPropertyValue( PROPERTY_APPLYFILTER ) ); @@ -1384,8 +1384,7 @@ OUString OCopyTableWizard::convertColumnName(const TColumnFindFunctor& _rCmpFu while(_rCmpFunctor(sName)) { - sName = sAlias; - sName += OUString::number(++nPos); + sName = sAlias + OUString::number(++nPos); } sAlias = sName; // we have to check again, it could happen that the name is already to long @@ -1521,8 +1520,7 @@ OUString OCopyTableWizard::createUniqueName(const OUString& _sName) sal_Int32 nPos = 0; while(m_vSourceColumns.find(sName) != m_vSourceColumns.end()) { - sName = _sName; - sName += OUString::number(++nPos); + sName = _sName + OUString::number(++nPos); } } } |