diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2017-12-17 23:00:24 +0300 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-18 07:36:32 +0100 |
| commit | 4e144751f12a06e358e4f7efa7c8f13954e6cfd7 (patch) | |
| tree | c6df66d58d02ecaf5caa437a944665fe83959402 /dbaccess/source/ui/misc | |
| parent | 39c618caf5aa19da95285bec6cab7108bee3984c (diff) | |
loplugin:unusedindex
Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146
Reviewed-on: https://gerrit.libreoffice.org/46652
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess/source/ui/misc')
| -rw-r--r-- | dbaccess/source/ui/misc/UITools.cxx | 14 | ||||
| -rw-r--r-- | dbaccess/source/ui/misc/stringlistitem.cxx | 7 |
2 files changed, 8 insertions, 13 deletions
diff --git a/dbaccess/source/ui/misc/UITools.cxx b/dbaccess/source/ui/misc/UITools.cxx index 00c2eaf5dddf..bae06ba9c1ca 100644 --- a/dbaccess/source/ui/misc/UITools.cxx +++ b/dbaccess/source/ui/misc/UITools.cxx @@ -879,8 +879,8 @@ bool callColumnFormatDialog(vcl::Window* _pParent, { const sal_uInt32* pDeletedKeys = pInfoItem->GetDelArray(); - for (sal_uInt32 i=0; i< pInfoItem->GetDelCount(); ++i, ++pDeletedKeys) - _pFormatter->DeleteEntry(*pDeletedKeys); + for (sal_uInt32 i=0; i< pInfoItem->GetDelCount(); ++i) + _pFormatter->DeleteEntry(pDeletedKeys[i]); } } } @@ -916,16 +916,14 @@ bool appendToFilter(const Reference<XConnection>& _xConnection, xProp->getPropertyValue(PROPERTY_TABLEFILTER) >>= aFilter; // first check if we have something like SCHEMA.% bool bHasToInsert = true; - const OUString* pBegin = aFilter.getConstArray(); - const OUString* pEnd = pBegin + aFilter.getLength(); - for (;pBegin != pEnd; ++pBegin) + for (const OUString& rItem : aFilter) { - if(pBegin->indexOf('%') != -1) + if(rItem.indexOf('%') != -1) { sal_Int32 nLen; - if((nLen = pBegin->lastIndexOf('.')) != -1 && !pBegin->compareTo(_sName,nLen)) + if((nLen = rItem.lastIndexOf('.')) != -1 && !rItem.compareTo(_sName,nLen)) bHasToInsert = false; - else if(pBegin->getLength() == 1) + else if(rItem.getLength() == 1) bHasToInsert = false; } } diff --git a/dbaccess/source/ui/misc/stringlistitem.cxx b/dbaccess/source/ui/misc/stringlistitem.cxx index 32649443b14e..fb865df54bb4 100644 --- a/dbaccess/source/ui/misc/stringlistitem.cxx +++ b/dbaccess/source/ui/misc/stringlistitem.cxx @@ -44,11 +44,8 @@ bool OStringListItem::operator==(const SfxPoolItem& _rItem) const return false; // compare all strings individually - const OUString* pMyStrings = m_aList.getConstArray(); - const OUString* pCompareStrings = pCompare->m_aList.getConstArray(); - - for (sal_Int32 i=0; i<m_aList.getLength(); ++i, ++pMyStrings, ++pCompareStrings) - if (*pMyStrings != *pCompareStrings) + for (sal_Int32 i=0; i<m_aList.getLength(); ++i) + if (m_aList[i] != pCompare->m_aList[i]) return false; return true; |