loplugin:unusedfields look for classes where we can make all the..

fields private

Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27
Reviewed-on: https://gerrit.libreoffice.org/68302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 12 insertions, 19 deletions

diff --git a/dbaccess/source/ui/dlg/ConnectionPageSetup.hxx b/dbaccess/source/ui/dlg/ConnectionPageSetup.hxx
index c66ba64f3259..a21364cc45a6 100644
--- a/dbaccess/source/ui/dlg/ConnectionPageSetup.hxx
+++ b/dbaccess/source/ui/dlg/ConnectionPageSetup.hxx
@@ -37,7 +37,6 @@ namespace dbaui
     class OConnectionTabPageSetup : public OConnectionHelper
     {
         friend class VclPtr<OConnectionTabPageSetup>;
-    protected:
 
         std::unique_ptr<weld::Label> m_xHelpText;
         std::unique_ptr<weld::Label> m_xHeaderText;
diff --git a/dbaccess/source/ui/dlg/DBSetupConnectionPages.hxx b/dbaccess/source/ui/dlg/DBSetupConnectionPages.hxx
index fdc36ff6db16..b5fbbb8e5a9b 100644
--- a/dbaccess/source/ui/dlg/DBSetupConnectionPages.hxx
+++ b/dbaccess/source/ui/dlg/DBSetupConnectionPages.hxx
@@ -55,9 +55,6 @@ namespace dbaui
     class OTextConnectionPageSetup : public OConnectionTabPageSetup
     {
     public:
-        std::unique_ptr<weld::Widget> m_xSubContainer;
-        std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
-
         virtual bool        FillItemSet ( SfxItemSet* _rCoreAttrs ) override;
         static VclPtr<OGenericAdministrationPage> CreateTextTabPage(TabPageParent pParent, const SfxItemSet& _rAttrSet );
         OTextConnectionPageSetup(TabPageParent pParent, const SfxItemSet& _rCoreAttrs);
@@ -69,9 +66,10 @@ namespace dbaui
         virtual void fillControls(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
         virtual void fillWindows(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
         bool    checkTestConnection() override;
-
     private:
         DECL_LINK(ImplGetExtensionHdl, OTextConnectionHelper*, void);
+        std::unique_ptr<weld::Widget> m_xSubContainer;
+        std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
     };
 
     // OLDAPConnectionPageSetup
@@ -255,15 +253,6 @@ namespace dbaui
         virtual bool        FillItemSet ( SfxItemSet* _rCoreAttrs ) override;
         static VclPtr<OGenericAdministrationPage> CreateFinalDBTabPageSetup( vcl::Window* pParent, const SfxItemSet& _rAttrSet);
 
-        VclPtr<FixedText>   m_pFTFinalHeader;
-        VclPtr<FixedText>   m_pFTFinalHelpText;
-        VclPtr<RadioButton> m_pRBRegisterDataSource;
-        VclPtr<RadioButton> m_pRBDontregisterDataSource;
-        VclPtr<FixedText>   m_pFTAdditionalSettings;
-        VclPtr<CheckBox>    m_pCBOpenAfterwards;
-        VclPtr<CheckBox>    m_pCBStartTableWizard;
-        VclPtr<FixedText>   m_pFTFinalText;
-
         OFinalDBPageSetup(vcl::Window* pParent, const SfxItemSet& _rCoreAttrs);
         virtual ~OFinalDBPageSetup() override;
         virtual void dispose() override;
@@ -277,6 +266,15 @@ namespace dbaui
         virtual void implInitControls(const SfxItemSet& _rSet, bool _bSaveValue) override;
         virtual void fillControls(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
         virtual void fillWindows(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
+    private:
+        VclPtr<FixedText>   m_pFTFinalHeader;
+        VclPtr<FixedText>   m_pFTFinalHelpText;
+        VclPtr<RadioButton> m_pRBRegisterDataSource;
+        VclPtr<RadioButton> m_pRBDontregisterDataSource;
+        VclPtr<FixedText>   m_pFTAdditionalSettings;
+        VclPtr<CheckBox>    m_pCBOpenAfterwards;
+        VclPtr<CheckBox>    m_pCBStartTableWizard;
+        VclPtr<FixedText>   m_pFTFinalText;
     };
 
 }   // namespace dbaui
diff --git a/dbaccess/source/ui/dlg/detailpages.hxx b/dbaccess/source/ui/dlg/detailpages.hxx
index 47ba2089850a..8de9f2f3e757 100644
--- a/dbaccess/source/ui/dlg/detailpages.hxx
+++ b/dbaccess/source/ui/dlg/detailpages.hxx
@@ -51,8 +51,6 @@ namespace dbaui
     */
     class OCommonBehaviourTabPage : public OGenericAdministrationPage
     {
-    protected:
-
         OCommonBehaviourTabPageFlags m_nControlFlags;
 
         std::unique_ptr<weld::Label> m_xOptionsLabel;
@@ -244,8 +242,6 @@ namespace dbaui
 
         OTextDetailsPage(TabPageParent pParent, const SfxItemSet& rCoreAttrs);
 
-        std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
-
     protected:
         virtual ~OTextDetailsPage() override;
         virtual void dispose() override;
@@ -256,6 +252,7 @@ namespace dbaui
         virtual void fillWindows(std::vector< std::unique_ptr<ISaveValueWrapper> >& _rControlList) override;
 
     private:
+        std::unique_ptr<OTextConnectionHelper> m_xTextConnectionHelper;
     };
 
 }   // namespace dbaui
diff --git a/dbaccess/source/ui/inc/GeneralUndo.hxx b/dbaccess/source/ui/inc/GeneralUndo.hxx
index c869babc7651..3a7365c1da9c 100644
--- a/dbaccess/source/ui/inc/GeneralUndo.hxx
+++ b/dbaccess/source/ui/inc/GeneralUndo.hxx
@@ -29,7 +29,6 @@ namespace dbaui
 
     class OCommentUndoAction : public SfxUndoAction
     {
-    protected:
         OUString         m_strComment; // undo, redo comment
 
     public: