diff options
author | Jelle van der Waa <jelle@vdwaa.nl> | 2013-06-17 20:01:18 +0200 |
---|---|---|
committer | Noel Power <noel.power@suse.com> | 2013-06-17 19:45:38 +0000 |
commit | 9a95669e5035758fc115f4c7be3e0a00651fe993 (patch) | |
tree | e93a00153714d9d78d1f6e33627ba013f5ef77ec /dbaccess/source/ui | |
parent | 55343abdef77793ea1559408fb565a6241f1dadd (diff) |
fdo#43460 dbaccess: use isEmpty()
Change-Id: Ie27a81f4e59c48ef5aa03fb82ab38e920c0646a1
Reviewed-on: https://gerrit.libreoffice.org/4321
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
Diffstat (limited to 'dbaccess/source/ui')
-rw-r--r-- | dbaccess/source/ui/querydesign/QueryDesignView.cxx | 18 | ||||
-rw-r--r-- | dbaccess/source/ui/uno/copytablewizard.cxx | 2 |
2 files changed, 10 insertions, 10 deletions
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx b/dbaccess/source/ui/querydesign/QueryDesignView.cxx index a07b18e45ebc..99f24d3d7201 100644 --- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx +++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx @@ -307,7 +307,7 @@ namespace for(;aIter != aEnd;++aIter) { OConnectionLineDataRef pLineData = *aIter; - if(aCondition.getLength()) + if(!aCondition.isEmpty()) aCondition.append(C_AND); aCondition.append(quoteTableAlias(sal_True,pData->GetAliasName(JTCS_FROM),aQuote)); aCondition.append(::dbtools::quoteName(aQuote, pLineData->GetFieldName(JTCS_FROM) )); @@ -723,7 +723,7 @@ namespace aFieldListStr.append(sFieldSeparator); } } - if(aFieldListStr.getLength()) + if(!aFieldListStr.isEmpty()) aFieldListStr.setLength(aFieldListStr.getLength()-2); } catch(SQLException&) @@ -881,7 +881,7 @@ namespace if (!aWhereStr.isEmpty()) { aWhereStr += OUString(')'); // close bracket for the AND branch - if (rRetStr.getLength()) // are there conditions on the field? + if (!rRetStr.isEmpty()) // are there conditions on the field? rRetStr.append(C_OR); else // open bracket for the OR branch rRetStr.append(sal_Unicode('(')); @@ -890,7 +890,7 @@ namespace if (!aHavingStr.isEmpty()) { aHavingStr += OUString(')'); // close bracket for the AND branch - if (rHavingStr.getLength()) // are there conditions on the field? + if (!rHavingStr.isEmpty()) // are there conditions on the field? rHavingStr.append(C_OR); else // Open bracket for the OR branch rHavingStr.append(sal_Unicode('(')); @@ -898,9 +898,9 @@ namespace } } - if (rRetStr.getLength()) + if (!rRetStr.isEmpty()) rRetStr.append(sal_Unicode(')')); // close bracket for the OR branch - if (rHavingStr.getLength()) + if (!rHavingStr.isEmpty()) rHavingStr.append(sal_Unicode(')')); // close bracket for the OR branch } catch(SQLException&) @@ -2933,7 +2933,7 @@ OUString OQueryDesignView::getStatement() OUString aTmp("( "); aTmp += aJoinCrit; aTmp += OUString(" )"); - if(aCriteriaListStr.getLength()) + if(!aCriteriaListStr.isEmpty()) { aTmp += C_AND; aTmp += aCriteriaListStr.makeStringAndClear(); @@ -2948,7 +2948,7 @@ OUString OQueryDesignView::getStatement() aSqlCmd.append(OUString(" FROM ")); aSqlCmd.append(aTableListStr); - if (aCriteriaListStr.getLength()) + if (!aCriteriaListStr.isEmpty()) { aSqlCmd.append(OUString(" WHERE ")); aSqlCmd.append(aCriteriaListStr.makeStringAndClear()); @@ -2963,7 +2963,7 @@ OUString OQueryDesignView::getStatement() aSqlCmd.append(GenerateGroupBy(this,rFieldList,bUseAlias)); // ----------------- attache having ------------ - if(aHavingStr.getLength()) + if(!aHavingStr.isEmpty()) { aSqlCmd.append(OUString(" HAVING ")); aSqlCmd.append(aHavingStr.makeStringAndClear()); diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx b/dbaccess/source/ui/uno/copytablewizard.cxx index 7af883ed9105..9bb4591f68f8 100644 --- a/dbaccess/source/ui/uno/copytablewizard.cxx +++ b/dbaccess/source/ui/uno/copytablewizard.cxx @@ -1503,7 +1503,7 @@ OUString CopyTableWizard::impl_getServerSideCopyStatement_throw(const Reference< { if ( COLUMN_POSITION_NOT_FOUND != aPosIter->second ) { - if ( sColumns.getLength() ) + if ( !sColumns.isEmpty() ) sColumns.append(","); sColumns.append(sQuote + aDestColumnNames[aPosIter->second - 1] + sQuote); } |