diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2015-10-05 17:10:47 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2015-10-05 20:30:59 +0100 |
| commit | 56a5734b06e0f252722153d2e6af680fd9e6e429 (patch) | |
| tree | f5e6653d3cfdc0e51baf962cec98f05ccb04e640 /dbaccess | |
| parent | 91ff5501892f8c3b11d4d5381e2f3efb5f289da6 (diff) | |
cppcheck: noExplicitConstructor
Change-Id: I80950aaf1385bd76b012eab7866fd16848751f45
Diffstat (limited to 'dbaccess')
| -rw-r--r-- | dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx | 6 | ||||
| -rw-r--r-- | dbaccess/source/ui/misc/dsmeta.cxx | 8 |
2 files changed, 7 insertions, 7 deletions
diff --git a/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx b/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx index bf48cdaa0aa1..343b840738f4 100644 --- a/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx +++ b/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx @@ -89,7 +89,7 @@ namespace dbaui { } - DataSourceHolder( const Reference< XDataSource >& _rxDataSource ) + explicit DataSourceHolder(const Reference< XDataSource >& _rxDataSource) { m_xDataSource = _rxDataSource; Reference< XDocumentDataSource > xDocDS( m_xDataSource, UNO_QUERY ); @@ -143,7 +143,7 @@ namespace dbaui bool m_bModified; // is the data modified bool m_bNotAttached; - DBSubComponentController_Impl( ::osl::Mutex& i_rMutex ) + explicit DBSubComponentController_Impl(osl::Mutex& i_rMutex) :m_aDocScriptSupport() ,m_aModifyListeners( i_rMutex ) ,m_nDocStartNumber(0) @@ -261,7 +261,7 @@ namespace dbaui xDS = Reference< XDataSource >( xConnAsChild->getParent(), UNO_QUERY ); // (take the indirection through XDataSource to ensure we have a correct object ....) - m_pImpl->m_aDataSource = xDS; + m_pImpl->m_aDataSource = DataSourceHolder(xDS); } SAL_WARN_IF( !m_pImpl->m_aDataSource.is(), "dbaccess.ui", "DBSubComponentController::initializeConnection: unable to obtain the data source object!" ); diff --git a/dbaccess/source/ui/misc/dsmeta.cxx b/dbaccess/source/ui/misc/dsmeta.cxx index c6837b91b51c..3e9645fed631 100644 --- a/dbaccess/source/ui/misc/dsmeta.cxx +++ b/dbaccess/source/ui/misc/dsmeta.cxx @@ -41,7 +41,7 @@ namespace dbaui { } - FeatureSupport( AuthenticationMode _Auth ) + explicit FeatureSupport(AuthenticationMode _Auth) :eAuthentication( _Auth ) { } @@ -134,9 +134,9 @@ namespace dbaui OUString sAuth; aMetaData.get("Authentication") >>= sAuth; if ( sAuth == "UserPassword" ) - aInit = AuthUserPwd; + aInit = FeatureSupport(AuthUserPwd); else if ( sAuth == "Password" ) - aInit = AuthPwd; + aInit = FeatureSupport(AuthPwd); } s_aSupport.insert(std::make_pair(*pIter,aInit)); } @@ -149,7 +149,7 @@ namespace dbaui class DataSourceMetaData_Impl { public: - DataSourceMetaData_Impl( const OUString& _sURL ); + explicit DataSourceMetaData_Impl(const OUString& rURL); OUString getType() const { return m_sURL; } |