clarify that set_visible(true/false) is just show/hide

ditch duplicate method

Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b
Reviewed-on: https://gerrit.libreoffice.org/69302
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

4 files changed, 19 insertions, 19 deletions

diff --git a/dbaccess/source/ui/control/curledit.cxx b/dbaccess/source/ui/control/curledit.cxx
index 7c8df5e88e21..6ae44b05f0cd 100644
--- a/dbaccess/source/ui/control/curledit.cxx
+++ b/dbaccess/source/ui/control/curledit.cxx
@@ -56,7 +56,7 @@ void OConnectionURLEdit::SetText(const OUString& _rStr)
 
 void OConnectionURLEdit::SetText(const OUString& _rStr, const Selection& /*_rNewSelection*/)
 {
-    m_xForcedPrefix->show(m_bShowPrefix);
+    m_xForcedPrefix->set_visible(m_bShowPrefix);
 
     bool bIsEmpty = _rStr.isEmpty();
     // calc the prefix
@@ -85,7 +85,7 @@ OUString OConnectionURLEdit::GetText() const
 void OConnectionURLEdit::ShowPrefix(bool _bShowPrefix)
 {
     m_bShowPrefix = _bShowPrefix;
-    m_xForcedPrefix->show(m_bShowPrefix);
+    m_xForcedPrefix->set_visible(m_bShowPrefix);
 }
 
 }   // namespace dbaui
diff --git a/dbaccess/source/ui/dlg/ConnectionHelper.cxx b/dbaccess/source/ui/dlg/ConnectionHelper.cxx
index 48605ccf84ea..a336a398fd7c 100644
--- a/dbaccess/source/ui/dlg/ConnectionHelper.cxx
+++ b/dbaccess/source/ui/dlg/ConnectionHelper.cxx
@@ -124,10 +124,10 @@ namespace dbaui
         m_xConnectionURL->ShowPrefix( ::dbaccess::DST_JDBC == m_pCollection->determineType(m_eType) );
 
         bool bEnableBrowseButton = m_pCollection->supportsBrowsing( m_eType );
-        m_xPB_Connection->show( bEnableBrowseButton );
+        m_xPB_Connection->set_visible( bEnableBrowseButton );
 
         bool bEnableCreateButton = m_pCollection->supportsDBCreation( m_eType );
-        m_xPB_CreateDB->show( bEnableCreateButton );
+        m_xPB_CreateDB->set_visible( bEnableCreateButton );
 
         const SfxStringItem* pUrlItem = _rSet.GetItem<SfxStringItem>(DSID_CONNECTURL);
 
diff --git a/dbaccess/source/ui/dlg/ConnectionPage.cxx b/dbaccess/source/ui/dlg/ConnectionPage.cxx
index d11f83269de9..0138f3d70db4 100644
--- a/dbaccess/source/ui/dlg/ConnectionPage.cxx
+++ b/dbaccess/source/ui/dlg/ConnectionPage.cxx
@@ -197,10 +197,10 @@ namespace dbaui
         bool bShowUser = ( eAuthMode == AuthUserPwd );
 
         m_xPB_Connection->set_help_id(HID_DSADMIN_BROWSECONN);
-        m_xFL2->show( bShowUserAuthenfication );
-        m_xUserNameLabel->show( bShowUser && bShowUserAuthenfication );
-        m_xUserName->show( bShowUser && bShowUserAuthenfication );
-        m_xPasswordRequired->show( bShowUserAuthenfication );
+        m_xFL2->set_visible( bShowUserAuthenfication );
+        m_xUserNameLabel->set_visible( bShowUser && bShowUserAuthenfication );
+        m_xUserName->set_visible( bShowUser && bShowUserAuthenfication );
+        m_xPasswordRequired->set_visible( bShowUserAuthenfication );
 
         // collect the items
         const SfxStringItem* pUidItem = _rSet.GetItem<SfxStringItem>(DSID_USER);
@@ -228,11 +228,11 @@ namespace dbaui
             else
                 m_xJavaDriver->set_text(pJdbcDrvItem->GetValue());
 
-            m_xJavaDriverLabel->show(bEnableJDBC);
-            m_xJavaDriver->show(bEnableJDBC);
-            m_xTestJavaDriver->show(bEnableJDBC);
+            m_xJavaDriverLabel->set_visible(bEnableJDBC);
+            m_xJavaDriver->set_visible(bEnableJDBC);
+            m_xTestJavaDriver->set_visible(bEnableJDBC);
             m_xTestJavaDriver->set_sensitive( !m_xJavaDriver->get_text().trim().isEmpty() );
-            m_xFL3->show(bEnableJDBC);
+            m_xFL3->set_visible(bEnableJDBC);
 
             checkTestConnection();
 
diff --git a/dbaccess/source/ui/dlg/detailpages.cxx b/dbaccess/source/ui/dlg/detailpages.cxx
index 60408c5e7b4b..a9c19e8d2e27 100644
--- a/dbaccess/source/ui/dlg/detailpages.cxx
+++ b/dbaccess/source/ui/dlg/detailpages.cxx
@@ -205,7 +205,7 @@ namespace dbaui
         if ( bValid )
         {
             m_xShowDeleted->set_active(pDeletedItem->GetValue());
-            m_xFT_Message->show(m_xShowDeleted->get_active());
+            m_xFT_Message->set_visible(m_xShowDeleted->get_active());
         }
 
         OCommonBehaviourTabPage::implInitControls(_rSet, _bSaveValue);
@@ -228,7 +228,7 @@ namespace dbaui
         }
         else
         {
-            m_xFT_Message->show(m_xShowDeleted->get_active());
+            m_xFT_Message->set_visible(m_xShowDeleted->get_active());
             // it was one of the checkboxes -> we count as modified from now on
             callModifiedHdl();
         }
@@ -395,13 +395,13 @@ namespace dbaui
         else
         {
             m_bUseClass = false;
-            m_xFTDriverClass->show(false);
-            m_xEDDriverClass->show(false);
-            m_xTestJavaDriver->show(false);
+            m_xFTDriverClass->hide();
+            m_xEDDriverClass->hide();
+            m_xTestJavaDriver->hide();
         }
 
-        m_xFTSocket->show(bShowSocket && !m_bUseClass);
-        m_xEDSocket->show(bShowSocket && !m_bUseClass);
+        m_xFTSocket->set_visible(bShowSocket && !m_bUseClass);
+        m_xEDSocket->set_visible(bShowSocket && !m_bUseClass);
 
         m_xEDHostname->connect_changed(LINK(this,OGenericAdministrationPage,OnControlEntryModifyHdl));
         m_xNFPortNumber->connect_value_changed(LINK(this,OGenericAdministrationPage,OnControlSpinButtonModifyHdl));