clang-analyzer-deadcode.DeadStores

In 8b9e4e393eff8b89a37a5932548700c0b50bcab8 "initial import" the assignment to
bCheck was in a for loop that used bCheck in its condition,

sal_Int32 nPos = m_nStartPos+1;
for(; aIter != m_pMatrix->end() && bCheck;)
{
if(!aIter->isValid())
...
m_pCacheSet->fillValueRow(*aIter++,nPos++);
bCheck = m_pCacheSet->next();
}

that loop was then replaced with

sal_Int32 nPos = m_nStartPos;
bCheck = fill(aIter,m_pMatrix->end(),nPos,bCheck);

(without further use of bCheck) in 2facbebb88fe72614d566c3187c8f86c5c61f8bd
"MWS_SRX644: migrate branch mws_srx644 -> HEAD" (and the braces around

{
ORowSetMatrix::iterator aIter(aEnd);
sal_Int32 nPos = m_nStartPos + 1;
bCheck = fill(aIter, m_pMatrix->end(), nPos, bCheck);
}

introduced in 1234d599d4ee67bd725f0513431b2d4c56c9e09d "ORowSetCache: overhaul
internals," presumably to limit the scope of that aIter introduced there).

Change-Id: I1cf4a22fbd1b76d524251a82c3ab4e6ca7a9eca1

1 files changed, 1 insertions, 1 deletions

diff --git a/dbaccess/source/core/api/RowSetCache.cxx b/dbaccess/source/core/api/RowSetCache.cxx
index fe21eaee362f..bbc30b3fd5cb 100644
--- a/dbaccess/source/core/api/RowSetCache.cxx
+++ b/dbaccess/source/core/api/RowSetCache.cxx
@@ -926,7 +926,7 @@ bool ORowSetCache::moveWindow()
                 {
                     ORowSetMatrix::iterator aIter(aEnd);
                     sal_Int32 nPos = m_nStartPos + 1;
-                    bCheck = fill(aIter, aNewEnd, nPos, bCheck);
+                    fill(aIter, aNewEnd, nPos, bCheck);
                 }
 
                 ::std::rotate(m_pMatrix->begin(), aEnd, aNewEnd);