diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-01-16 11:11:32 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-01-16 10:52:19 +0100 |
commit | 8041a9b1fd26b64494ecb4c23022f39bd168a24f (patch) | |
tree | 2ad86004de35a56859919b18f551b1dd92806eac /dbaccess | |
parent | ef5812deb142d043e58965bf8f4829b50acffcee (diff) |
return nullptr from Create*Context methods in nullptr subclasses
the calling class handles this nicely, and also tells us when we are not
handling some part of the XML file
Change-Id: Ic51a42b9d2dec96243e7f83b528d7455d4bc0504
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86906
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
-rw-r--r-- | dbaccess/source/filter/xml/xmlfilter.cxx | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/dbaccess/source/filter/xml/xmlfilter.cxx b/dbaccess/source/filter/xml/xmlfilter.cxx index fa57e133bba3..96a34742fba0 100644 --- a/dbaccess/source/filter/xml/xmlfilter.cxx +++ b/dbaccess/source/filter/xml/xmlfilter.cxx @@ -542,7 +542,7 @@ public: } SvXMLImportContext* ODBFilter::CreateFastContext(sal_Int32 nElement, - const ::css::uno::Reference< ::css::xml::sax::XFastAttributeList >& xAttrList ) + const ::css::uno::Reference< ::css::xml::sax::XFastAttributeList >& /*xAttrList*/ ) { SvXMLImportContext *pContext = nullptr; @@ -561,13 +561,8 @@ SvXMLImportContext* ODBFilter::CreateFastContext(sal_Int32 nElement, case XML_ELEMENT(OOO, XML_DOCUMENT_CONTENT): pContext = new DBXMLDocumentContentContext(*this); break; - default: - break; } - if ( !pContext ) - pContext = SvXMLImport::CreateFastContext( nElement, xAttrList ); - return pContext; } |