loplugin:unusedfields make some fields private

this is one of the secondary analyses this plugin performs

Change-Id: Iaa4424c2396470c6f1df85b0290fbffdda35fa08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143177
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 5 insertions, 7 deletions

diff --git a/dbaccess/source/core/inc/TableDeco.hxx b/dbaccess/source/core/inc/TableDeco.hxx
index e40fac80290c..93a974dac4a4 100644
--- a/dbaccess/source/core/inc/TableDeco.hxx
+++ b/dbaccess/source/core/inc/TableDeco.hxx
@@ -61,7 +61,6 @@ namespace dbaccess
                             ,public ODBTableDecorator_PROP
     {
         void fillPrivileges() const;
-    protected:
         css::uno::Reference< css::container::XContainerListener > m_xColumnMediator;
         css::uno::Reference< css::sdbcx::XColumnsSupplier >       m_xTable;
         css::uno::Reference< css::container::XNameAccess >        m_xColumnDefinitions;
@@ -75,6 +74,7 @@ namespace dbaccess
         // note: this thing uses the ref-count of "this", see OCollection::acquire()!
         std::unique_ptr<::connectivity::sdbcx::OCollection>       m_pColumns;
 
+    protected:
         // IColumnFactory
         virtual rtl::Reference<OColumn> createColumn(const OUString& _rName) const override;
         virtual css::uno::Reference< css::beans::XPropertySet > createColumnDescriptor() override;
diff --git a/dbaccess/source/core/inc/column.hxx b/dbaccess/source/core/inc/column.hxx
index ca533b5b1793..eae96fba3fd6 100644
--- a/dbaccess/source/core/inc/column.hxx
+++ b/dbaccess/source/core/inc/column.hxx
@@ -128,7 +128,6 @@ namespace dbaccess
     {
         OContainerMediator*     m_pMediator;
 
-    protected:
         // comes from the driver can be null
         css::uno::Reference< css::container::XNameAccess >    m_xDrvColumns;
         css::uno::WeakReference< css::uno::XInterface >       m_xParent;
@@ -139,6 +138,7 @@ namespace dbaccess
         bool                                    m_bAddColumn    : 1;
         bool                                    m_bDropColumn   : 1;
 
+    protected:
         virtual void impl_refresh() override;
         virtual connectivity::sdbcx::ObjectType createObject(const OUString& _rName) override;
         virtual css::uno::Reference< css::beans::XPropertySet > createDescriptor() override;
diff --git a/dbaccess/source/core/inc/databasecontext.hxx b/dbaccess/source/core/inc/databasecontext.hxx
index e15585c819d1..89662ad2281d 100644
--- a/dbaccess/source/core/inc/databasecontext.hxx
+++ b/dbaccess/source/core/inc/databasecontext.hxx
@@ -84,7 +84,6 @@ private:
     BasicDLL m_aBasicDLL;
 #endif
 
-protected:
     ::osl::Mutex                    m_aMutex;
     css::uno::Reference< css::uno::XComponentContext >
                                     m_aContext;
diff --git a/dbaccess/source/core/inc/table.hxx b/dbaccess/source/core/inc/table.hxx
index 8c29bff44772..84bcf2470ec6 100644
--- a/dbaccess/source/core/inc/table.hxx
+++ b/dbaccess/source/core/inc/table.hxx
@@ -44,7 +44,6 @@ namespace dbaccess
     private:
         ::rtl::Reference< OContainerMediator >                m_pColumnMediator;
 
-    protected:
         css::uno::Reference< css::container::XNameAccess >    m_xColumnDefinitions;
         css::uno::Reference< css::container::XNameAccess >    m_xDriverColumns;
 
@@ -52,6 +51,7 @@ namespace dbaccess
         sal_Int32                                             m_nPrivileges;
     // </properties>
 
+    protected:
         virtual ::cppu::IPropertyArrayHelper* createArrayHelper( sal_Int32 _nId) const override;
         virtual ::cppu::IPropertyArrayHelper & SAL_CALL getInfoHelper() override;
 
diff --git a/dbaccess/source/ui/dlg/dbfindex.hxx b/dbaccess/source/ui/dlg/dbfindex.hxx
index 0db7ea7b04a6..938339314ecc 100644
--- a/dbaccess/source/ui/dlg/dbfindex.hxx
+++ b/dbaccess/source/ui/dlg/dbfindex.hxx
@@ -64,7 +64,6 @@ typedef std::deque< OTableInfo >   TableInfoList;
 // IndexDialog
 class ODbaseIndexDialog : public weld::GenericDialogController
 {
-protected:
     OUString            m_aDSN;
     TableInfoList       m_aTableInfoList;
     TableIndexList      m_aFreeIndexList;
@@ -88,6 +87,7 @@ protected:
     DECL_LINK( OKClickHdl, weld::Button&, void );
     DECL_LINK( OnListEntrySelected, weld::TreeView&, void );
 
+protected:
     void        Init();
     void        SetCtrls();
 
diff --git a/dbaccess/source/ui/inc/TableWindowData.hxx b/dbaccess/source/ui/inc/TableWindowData.hxx
index 33fb4a958100..0160ea723316 100644
--- a/dbaccess/source/ui/inc/TableWindowData.hxx
+++ b/dbaccess/source/ui/inc/TableWindowData.hxx
@@ -34,7 +34,7 @@ namespace dbaui
         mutable ::osl::Mutex    m_aMutex;
 
         void listen();
-    protected:
+
         // the columns of the table
         css::uno::Reference< css::beans::XPropertySet >       m_xTable; // can either be a table or a query
         css::uno::Reference< css::container::XIndexAccess>    m_xKeys;
diff --git a/dbaccess/source/ui/inc/indexcollection.hxx b/dbaccess/source/ui/inc/indexcollection.hxx
index d677eed06c5f..3d227b0b3869 100644
--- a/dbaccess/source/ui/inc/indexcollection.hxx
+++ b/dbaccess/source/ui/inc/indexcollection.hxx
@@ -29,7 +29,6 @@ namespace dbaui
     // OIndexCollection
     class OIndexCollection
     {
-    protected:
         css::uno::Reference< css::container::XNameAccess >
                     m_xIndexes;