loplugin:constparams improve handling of pointer params

Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 12 insertions, 12 deletions

diff --git a/dbaccess/source/ui/browser/unodatbr.cxx b/dbaccess/source/ui/browser/unodatbr.cxx
index 3d0fd95acc43..d4e7ed28acdb 100644
--- a/dbaccess/source/ui/browser/unodatbr.cxx
+++ b/dbaccess/source/ui/browser/unodatbr.cxx
@@ -2477,7 +2477,7 @@ IMPL_LINK_NOARG(SbaTableQueryBrowser, OnSelectionChange, LinkParamNone*, void)
     implSelect(xSelection.get());
 }
 
-std::unique_ptr<weld::TreeIter> SbaTableQueryBrowser::implGetConnectionEntry(weld::TreeIter& rEntry) const
+std::unique_ptr<weld::TreeIter> SbaTableQueryBrowser::implGetConnectionEntry(const weld::TreeIter& rEntry) const
 {
     weld::TreeView& rTreeView = m_pTreeView->GetWidget();
     std::unique_ptr<weld::TreeIter> xCurrentEntry(rTreeView.make_iterator(&rEntry));
@@ -2973,7 +2973,7 @@ void SbaTableQueryBrowser::disposeConnection(const weld::TreeIter* pDSEntry)
     }
 }
 
-void SbaTableQueryBrowser::closeConnection(weld::TreeIter& rDSEntry, bool _bDisposeConnection)
+void SbaTableQueryBrowser::closeConnection(const weld::TreeIter& rDSEntry, bool _bDisposeConnection)
 {
     OSL_ENSURE(impl_isDataSourceEntry(&rDSEntry), "SbaTableQueryBrowser::closeConnection: invalid entry (not top-level)!");
 
@@ -3435,7 +3435,7 @@ int SbaTableQueryBrowser::OnTreeEntryCompare(const weld::TreeIter& rLHS, const w
     return nCompareResult;
 }
 
-void SbaTableQueryBrowser::implAdministrate(weld::TreeIter& rApplyTo)
+void SbaTableQueryBrowser::implAdministrate(const weld::TreeIter& rApplyTo)
 {
     try
     {
diff --git a/dbaccess/source/ui/control/tabletree.cxx b/dbaccess/source/ui/control/tabletree.cxx
index 32a62da248e7..2c3f0976fe60 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -463,7 +463,7 @@ std::unique_ptr<weld::TreeIter> OTableTreeListBox::implAddEntry(
     return nullptr;
 }
 
-NamedDatabaseObject OTableTreeListBox::describeObject(weld::TreeIter& rEntry)
+NamedDatabaseObject OTableTreeListBox::describeObject(const weld::TreeIter& rEntry)
 {
     NamedDatabaseObject aObject;
 
@@ -511,7 +511,7 @@ bool OTableTreeListBox::impl_getAndAssertMetaData( Reference< XDatabaseMetaData
     return _out_rMetaData.is();
 }
 
-OUString OTableTreeListBox::getQualifiedTableName(weld::TreeIter& rEntry) const
+OUString OTableTreeListBox::getQualifiedTableName(const weld::TreeIter& rEntry) const
 {
     OSL_PRECOND( !isFolderEntry(rEntry), "OTableTreeListBox::getQualifiedTableName: folder entries not allowed here!" );
 
@@ -625,7 +625,7 @@ void OTableTreeListBox::CheckButtons()
     } while (m_xTreeView->iter_next_sibling(*xEntry));
 }
 
-TriState OTableTreeListBox::implDetermineState(weld::TreeIter& rEntry)
+TriState OTableTreeListBox::implDetermineState(const weld::TreeIter& rEntry)
 {
     if (!m_bShowToggles)
         return TRISTATE_FALSE;
diff --git a/dbaccess/source/ui/inc/tabletree.hxx b/dbaccess/source/ui/inc/tabletree.hxx
index 941ba2a1a80c..ebfbf7d29c4a 100644
--- a/dbaccess/source/ui/inc/tabletree.hxx
+++ b/dbaccess/source/ui/inc/tabletree.hxx
@@ -104,7 +104,7 @@ public:
 
     void            checkedButton_noBroadcast(const weld::TreeIter& rEntry);
 private:
-    TriState implDetermineState(weld::TreeIter& rEntry);
+    TriState implDetermineState(const weld::TreeIter& rEntry);
 
     void implEmphasize(const weld::TreeIter& rEntry, bool _bChecked, bool _bUpdateDescendants = true, bool _bUpdateAncestors = true);
 
@@ -139,13 +139,13 @@ public:
     /** returns a NamedDatabaseObject record which describes the given entry
     */
     css::sdb::application::NamedDatabaseObject
-            describeObject(weld::TreeIter& rEntry);
+            describeObject(const weld::TreeIter& rEntry);
 
     /** returns the fully qualified name of a table entry
         @param _pEntry
             the entry whose name is to be obtained. Must not denote a folder entry.
     */
-    OUString getQualifiedTableName(weld::TreeIter& rEntry) const;
+    OUString getQualifiedTableName(const weld::TreeIter& rEntry) const;
 
     std::unique_ptr<weld::TreeIter> getEntryByQualifiedName(const OUString& rName);
 };
diff --git a/dbaccess/source/ui/inc/unodatbr.hxx b/dbaccess/source/ui/inc/unodatbr.hxx
index 7899fed5fec6..07240e843378 100644
--- a/dbaccess/source/ui/inc/unodatbr.hxx
+++ b/dbaccess/source/ui/inc/unodatbr.hxx
@@ -290,7 +290,7 @@ namespace dbaui
 
         /** close the connection (and collapse the list entries) of the given list entries
         */
-        void        closeConnection(weld::TreeIter& rEntry, bool bDisposeConnection = true);
+        void        closeConnection(const weld::TreeIter& rEntry, bool bDisposeConnection = true);
 
         void        populateTree(const css::uno::Reference< css::container::XNameAccess>& xNameAccess, const weld::TreeIter& rParent, EntryType eEntryType);
         void        initializeTreeModel();
@@ -309,7 +309,7 @@ namespace dbaui
         */
         std::unique_ptr<ImageProvider> getImageProviderFor(const weld::TreeIter* pAnyEntry);
 
-        void    implAdministrate(weld::TreeIter& rApplyTo);
+        void    implAdministrate(const weld::TreeIter& rApplyTo);
 
         bool implCopyObject(ODataClipboard& rExchange, const weld::TreeIter& rApplyTo, sal_Int32 nCommandType);
 
@@ -350,7 +350,7 @@ namespace dbaui
             bool _bSelectDirect
         );
 
-        std::unique_ptr<weld::TreeIter> implGetConnectionEntry(weld::TreeIter& rEntry) const;
+        std::unique_ptr<weld::TreeIter> implGetConnectionEntry(const weld::TreeIter& rEntry) const;
         /// inserts an entry into the tree
         std::unique_ptr<weld::TreeIter> implAppendEntry(
             const weld::TreeIter* pParent,