diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-09-24 15:41:53 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2018-09-24 17:22:05 +0200 |
| commit | 928b1b04adc1cd49cc5d00069084e03675a320f3 (patch) | |
| tree | 8710687a4a66a628bd12c5482d7d93cc27f8996a /dbaccess | |
| parent | ec709a8d5e808b970a8930a389c0a5a6f61fe8c7 (diff) | |
loplugin:external (clang-cl)
Including:
* expanding STDAPI to its definition (as per
<https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add
__declspec(dllexport) into its middle, in
extensions/source/activex/so_activex.cxx; as discussed in the comments at
<https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in
setup_native, use __declspec(dllexport)", having a function both listed in a
.def file EXPORTS and marking it dllexport is OK, and the latter helps the
heuristics of loplugin:external; however, the relevant functions in
extensions/source/activex/so_activex.cxx probably don't even need to be
exported in the first place?
* follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx
Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191
Reviewed-on: https://gerrit.libreoffice.org/60938
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'dbaccess')
| -rw-r--r-- | dbaccess/win32/source/odbcconfig/odbcconfig.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/dbaccess/win32/source/odbcconfig/odbcconfig.cxx b/dbaccess/win32/source/odbcconfig/odbcconfig.cxx index 7874bb4c056f..71cb8286ff86 100644 --- a/dbaccess/win32/source/odbcconfig/odbcconfig.cxx +++ b/dbaccess/win32/source/odbcconfig/odbcconfig.cxx @@ -32,7 +32,7 @@ typedef SQLRETURN (SQL_API* TSQLManageDataSource) (SQLHWND hwndParent); // displays the error text for the last error (GetLastError), and returns this error value -int displayLastError() +static int displayLastError() { DWORD dwError = GetLastError(); @@ -58,7 +58,7 @@ int displayLastError() /** registers the window class for our application's main window */ -BOOL registerWindowClass( HINSTANCE _hAppInstance ) +static BOOL registerWindowClass( HINSTANCE _hAppInstance ) { WNDCLASSEXW wcx; @@ -79,7 +79,7 @@ BOOL registerWindowClass( HINSTANCE _hAppInstance ) } /// initializes the application instances -HWND initInstance( HINSTANCE _hAppInstance ) +static HWND initInstance( HINSTANCE _hAppInstance ) { HWND hWindow = CreateWindowW( L"ODBCConfigMainClass", // name of window class |