diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-06-26 16:16:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-06-27 13:10:44 +0200 |
| commit | e266d448f45348f27f8291ea5d0542747d7c8168 (patch) | |
| tree | 0d6d14e94d9bf25aeeb4ef21630ee72c10681645 /dbaccess | |
| parent | 05c6cdb144d1732ca51d463845fa6ddef7c08265 (diff) | |
loplugin:stringstatic look for more strings
that can be initialised at compile-time instead of runtime
Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
| -rw-r--r-- | dbaccess/source/ui/dlg/dbadmin.cxx | 4 | ||||
| -rw-r--r-- | dbaccess/source/ui/dlg/dbfindex.cxx | 4 | ||||
| -rw-r--r-- | dbaccess/source/ui/misc/WCopyTable.cxx | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/dbaccess/source/ui/dlg/dbadmin.cxx b/dbaccess/source/ui/dlg/dbadmin.cxx index 1744f6929c35..105f9ab6b286 100644 --- a/dbaccess/source/ui/dlg/dbadmin.cxx +++ b/dbaccess/source/ui/dlg/dbadmin.cxx @@ -271,14 +271,14 @@ void ODbAdminDialog::createItemSet(std::unique_ptr<SfxItemSet>& _rpSet, rtl::Ref _rpPool = nullptr; _rpDefaults = nullptr; - const OUString sFilterAll( "%" ); + static constexpr OUStringLiteral sFilterAll( u"%" ); // create and initialize the defaults _rpDefaults = new std::vector<SfxPoolItem*>(DSID_LAST_ITEM_ID - DSID_FIRST_ITEM_ID + 1); SfxPoolItem** pCounter = _rpDefaults->data(); // want to modify this without affecting the out param _rppDefaults *pCounter++ = new SfxStringItem(DSID_NAME, OUString()); *pCounter++ = new SfxStringItem(DSID_ORIGINALNAME, OUString()); *pCounter++ = new SfxStringItem(DSID_CONNECTURL, OUString()); - *pCounter++ = new OStringListItem(DSID_TABLEFILTER, Sequence< OUString >(&sFilterAll, 1)); + *pCounter++ = new OStringListItem(DSID_TABLEFILTER, Sequence< OUString >{sFilterAll}); *pCounter++ = new DbuTypeCollectionItem(DSID_TYPECOLLECTION, _pTypeCollection); *pCounter++ = new SfxBoolItem(DSID_INVALID_SELECTION, false); *pCounter++ = new SfxBoolItem(DSID_READONLY, false); diff --git a/dbaccess/source/ui/dlg/dbfindex.cxx b/dbaccess/source/ui/dlg/dbfindex.cxx index 061486e91201..e5f62afc6be3 100644 --- a/dbaccess/source/ui/dlg/dbfindex.cxx +++ b/dbaccess/source/ui/dlg/dbfindex.cxx @@ -254,8 +254,8 @@ void ODbaseIndexDialog::Init() // first assume for all indexes they're free - OUString const aIndexExt("ndx"); - OUString const aTableExt("dbf"); + static constexpr OUStringLiteral aIndexExt(u"ndx"); + static constexpr OUStringLiteral aTableExt(u"dbf"); std::vector< OUString > aUsedIndexes; diff --git a/dbaccess/source/ui/misc/WCopyTable.cxx b/dbaccess/source/ui/misc/WCopyTable.cxx index 590b3f9adce5..40b8c0edd4c8 100644 --- a/dbaccess/source/ui/misc/WCopyTable.cxx +++ b/dbaccess/source/ui/misc/WCopyTable.cxx @@ -992,7 +992,7 @@ void OCopyTableWizard::loadData( const ICopyTableSourceObject& _rSourceObject, _rColumns.clear(); OFieldDescription* pActFieldDescr = nullptr; - OUString const sCreateParam("x"); + static constexpr OUStringLiteral sCreateParam(u"x"); // ReadOnly-Flag // On drop no line must be editable. // On add only empty lines must be editable. |