More -Werror,-Wunused-private-field

...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628

9 files changed, 0 insertions, 17 deletions

diff --git a/dbaccess/source/core/api/RowSet.hxx b/dbaccess/source/core/api/RowSet.hxx
index 67d9423ed119..35baaf9a834b 100644
--- a/dbaccess/source/core/api/RowSet.hxx
+++ b/dbaccess/source/core/api/RowSet.hxx
@@ -109,7 +109,6 @@ namespace dbaccess
         OUString                               m_aGroupBy;
         OUString                               m_aOrder;
         OUString                               m_aActiveCommand;
-        OUString                               m_aCursorName;
         OUString                               m_aUpdateCatalogName; // is set by a query
         OUString                               m_aUpdateSchemaName; // is set by a query
         OUString                               m_aUpdateTableName; // is set by a query
diff --git a/dbaccess/source/filter/xml/xmlStyleImport.cxx b/dbaccess/source/filter/xml/xmlStyleImport.cxx
index 1dab32ffd331..1671f2f99c26 100644
--- a/dbaccess/source/filter/xml/xmlStyleImport.cxx
+++ b/dbaccess/source/filter/xml/xmlStyleImport.cxx
@@ -54,7 +54,6 @@ OTableStyleContext::OTableStyleContext( ODBFilter& rImport,
         const Reference< XAttributeList > & xAttrList,
         SvXMLStylesContext& rStyles, sal_uInt16 nFamily, bool bDefaultStyle )
     :XMLPropStyleContext( rImport, nPrfx, rLName, xAttrList, rStyles, nFamily, bDefaultStyle )
-    ,sNumberFormat(OUString("NumberFormat"))
     ,pStyles(&rStyles)
     ,m_nNumberFormat(-1)
 {
diff --git a/dbaccess/source/filter/xml/xmlStyleImport.hxx b/dbaccess/source/filter/xml/xmlStyleImport.hxx
index 1f9440c4b81c..f25f0dcb1e36 100644
--- a/dbaccess/source/filter/xml/xmlStyleImport.hxx
+++ b/dbaccess/source/filter/xml/xmlStyleImport.hxx
@@ -40,9 +40,7 @@ namespace dbaxml
     {
         OUString             m_sDataStyleName;
         OUString             sPageStyle;
-        const OUString         sNumberFormat;
         SvXMLStylesContext*         pStyles;
-        com::sun::star::uno::Any    aConditionalFormat;
         sal_Int32                   m_nNumberFormat;
 
         ODBFilter& GetOwnImport();
diff --git a/dbaccess/source/ui/dlg/detailpages.hxx b/dbaccess/source/ui/dlg/detailpages.hxx
index 229b466384fa..d70246976339 100644
--- a/dbaccess/source/ui/dlg/detailpages.hxx
+++ b/dbaccess/source/ui/dlg/detailpages.hxx
@@ -253,11 +253,6 @@ namespace dbaui
         OTextDetailsPage( vcl::Window* pParent, const SfxItemSet& _rCoreAttrs );
         OTextConnectionHelper*  m_pTextConnectionHelper;
 
-    private:
-
-        OUString      m_aFieldSeparatorList;
-        OUString      m_aTextSeparatorList;
-        OUString      m_aTextNone;
     protected:
         virtual ~OTextDetailsPage();
         virtual bool prepareLeave() SAL_OVERRIDE;
diff --git a/dbaccess/source/ui/dlg/tablespage.hxx b/dbaccess/source/ui/dlg/tablespage.hxx
index fe217b06f703..37db79c853a9 100644
--- a/dbaccess/source/ui/dlg/tablespage.hxx
+++ b/dbaccess/source/ui/dlg/tablespage.hxx
@@ -42,8 +42,6 @@ namespace dbaui
         OUString         m_sCatalogSeparator;
         bool                m_bCatalogAtStart : 1;
 
-        ::osl::Mutex            m_aNotifierMutex;
-
         ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >
                                 m_xCurrentConnection;   /// valid as long as the page is active
         ::com::sun::star::uno::Reference< ::com::sun::star::i18n::XCollator >
diff --git a/dbaccess/source/ui/inc/CollectionView.hxx b/dbaccess/source/ui/inc/CollectionView.hxx
index 80dc9bbaa45e..704ea76c6068 100644
--- a/dbaccess/source/ui/inc/CollectionView.hxx
+++ b/dbaccess/source/ui/inc/CollectionView.hxx
@@ -42,8 +42,6 @@ namespace dbaui
         PushButton*     m_pPB_OK;
         ::com::sun::star::uno::Reference< ::com::sun::star::ucb::XContent>                  m_xContent;
         ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >        m_xContext;
-        Size            m_aDlgSize;
-        Size            m_a6Size;
         bool        m_bCreateForm;
 
         DECL_LINK(Up_Click,void*);
diff --git a/dbaccess/source/ui/inc/brwctrlr.hxx b/dbaccess/source/ui/inc/brwctrlr.hxx
index f28f54185f1a..87c0fd3cd8ee 100644
--- a/dbaccess/source/ui/inc/brwctrlr.hxx
+++ b/dbaccess/source/ui/inc/brwctrlr.hxx
@@ -96,8 +96,6 @@ namespace dbaui
         TransferableClipboardListener*
                                 m_pClipbordNotifier;    // notifier for changes in the clipboard
 
-        ::osl::Mutex            m_aAsyncLoadSafety;     // for multi-thread access to our members
-
         OAsyncronousLink        m_aAsyncGetCellFocus;
         OAsyncronousLink        m_aAsyncDisplayError;
         ::dbtools::SQLExceptionInfo m_aCurrentError;
diff --git a/dbaccess/source/ui/inc/opendoccontrols.hxx b/dbaccess/source/ui/inc/opendoccontrols.hxx
index 24d475cb8c3d..b51b6c6ec04f 100644
--- a/dbaccess/source/ui/inc/opendoccontrols.hxx
+++ b/dbaccess/source/ui/inc/opendoccontrols.hxx
@@ -53,7 +53,6 @@ namespace dbaui
         typedef ::std::pair< OUString, OUString >       StringPair;
         typedef ::std::map< sal_uInt16, StringPair >    MapIndexToStringPair;
 
-        OUString         m_sModule;
         MapIndexToStringPair    m_aURLs;
 
     public:
diff --git a/dbaccess/source/ui/uno/DBTypeWizDlgSetup.hxx b/dbaccess/source/ui/uno/DBTypeWizDlgSetup.hxx
index 8ed555e4014a..45f0c7b50e8c 100644
--- a/dbaccess/source/ui/uno/DBTypeWizDlgSetup.hxx
+++ b/dbaccess/source/ui/uno/DBTypeWizDlgSetup.hxx
@@ -29,7 +29,6 @@ class ODBTypeWizDialogSetup
         :public ODatabaseAdministrationDialog
         ,public ::comphelper::OPropertyArrayUsageHelper< ODBTypeWizDialogSetup >
 {
-    OUString m_sExistingDocToOpen;
     bool        m_bOpenDatabase;
     bool        m_bStartTableWizard;