loplugin:const* make some params and methods const

Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

16 files changed, 24 insertions, 24 deletions

diff --git a/dbaccess/source/ui/app/AppDetailPageHelper.cxx b/dbaccess/source/ui/app/AppDetailPageHelper.cxx
index 1d1a023445ae..aef0eaba350f 100644
--- a/dbaccess/source/ui/app/AppDetailPageHelper.cxx
+++ b/dbaccess/source/ui/app/AppDetailPageHelper.cxx
@@ -401,7 +401,7 @@ void OAppDetailPageHelper::selectElements(const Sequence< OUString>& _aNames)
     }
 }
 
-OUString OAppDetailPageHelper::getQualifiedName(weld::TreeIter* _pEntry) const
+OUString OAppDetailPageHelper::getQualifiedName(const weld::TreeIter* _pEntry) const
 {
     int nPos = getVisibleControlIndex();
     OUString sComposedName;
@@ -633,7 +633,7 @@ namespace
 }
 
 void OAppDetailPageHelper::fillNames( const Reference< XNameAccess >& _xContainer, const ElementType _eType,
-                                      const OUString& rImageId, weld::TreeIter* _pParent )
+                                      const OUString& rImageId, const weld::TreeIter* _pParent )
 {
     OSL_ENSURE(_xContainer.is(),"Data source is NULL! -> GPF");
     OSL_ENSURE( ( _eType >= E_TABLE ) && ( _eType < E_ELEMENT_TYPE_COUNT ), "OAppDetailPageHelper::fillNames: invalid type!" );
diff --git a/dbaccess/source/ui/app/AppDetailPageHelper.hxx b/dbaccess/source/ui/app/AppDetailPageHelper.hxx
index 6268f713eb43..03107f5ecf8b 100644
--- a/dbaccess/source/ui/app/AppDetailPageHelper.hxx
+++ b/dbaccess/source/ui/app/AppDetailPageHelper.hxx
@@ -125,7 +125,7 @@ namespace dbaui
         void fillNames( const css::uno::Reference< css::container::XNameAccess >& _xContainer,
                         const ElementType _eType,
                         const OUString& rImageId,
-                        weld::TreeIter* _pParent );
+                        const weld::TreeIter* _pParent );
 
         /** sets the detail page
             @param  rTreeView
@@ -240,7 +240,7 @@ namespace dbaui
             @return
                 the qualified name
         */
-        OUString getQualifiedName( weld::TreeIter* _pEntry ) const;
+        OUString getQualifiedName( const weld::TreeIter* _pEntry ) const;
 
         /// return the element of currently select entry
         ElementType getElementType() const;
diff --git a/dbaccess/source/ui/app/AppDetailView.cxx b/dbaccess/source/ui/app/AppDetailView.cxx
index 23011330a7e8..57a4f3038448 100644
--- a/dbaccess/source/ui/app/AppDetailView.cxx
+++ b/dbaccess/source/ui/app/AppDetailView.cxx
@@ -325,7 +325,7 @@ const TaskPaneData& OApplicationDetailView::impl_getTaskPaneData( ElementType _e
     return rData;
 }
 
-OUString OApplicationDetailView::getQualifiedName(weld::TreeIter* _pEntry) const
+OUString OApplicationDetailView::getQualifiedName(const weld::TreeIter* _pEntry) const
 {
     return GetControlHelper()->getQualifiedName( _pEntry );
 }
diff --git a/dbaccess/source/ui/app/AppDetailView.hxx b/dbaccess/source/ui/app/AppDetailView.hxx
index 977bd015be02..58b382800865 100644
--- a/dbaccess/source/ui/app/AppDetailView.hxx
+++ b/dbaccess/source/ui/app/AppDetailView.hxx
@@ -146,7 +146,7 @@ namespace dbaui
             @return
                 the qualified name
         */
-        OUString getQualifiedName(weld::TreeIter* _pEntry) const;
+        OUString getQualifiedName(const weld::TreeIter* _pEntry) const;
 
         /** returns if an entry is a leaf
             @param rTreeView
diff --git a/dbaccess/source/ui/app/AppTitleWindow.cxx b/dbaccess/source/ui/app/AppTitleWindow.cxx
index dbe4e77abd53..be384b2d9076 100644
--- a/dbaccess/source/ui/app/AppTitleWindow.cxx
+++ b/dbaccess/source/ui/app/AppTitleWindow.cxx
@@ -51,7 +51,7 @@ weld::Container* OTitleWindow::getChildContainer()
     return m_xChildContainer.get();
 }
 
-void OTitleWindow::setChildWindow(std::shared_ptr<OChildWindow>& rChild)
+void OTitleWindow::setChildWindow(const std::shared_ptr<OChildWindow>& rChild)
 {
     m_xChild = rChild;
 }
diff --git a/dbaccess/source/ui/app/AppTitleWindow.hxx b/dbaccess/source/ui/app/AppTitleWindow.hxx
index c00bf99df1cb..161e21e5c3fe 100644
--- a/dbaccess/source/ui/app/AppTitleWindow.hxx
+++ b/dbaccess/source/ui/app/AppTitleWindow.hxx
@@ -46,7 +46,7 @@ namespace dbaui
             @param  _pChild
                 The child window.
         */
-        void setChildWindow(std::shared_ptr<OChildWindow>& rChild);
+        void setChildWindow(const std::shared_ptr<OChildWindow>& rChild);
 
         /** gets the child window.
 
diff --git a/dbaccess/source/ui/app/AppView.cxx b/dbaccess/source/ui/app/AppView.cxx
index 59ba64f0b0ea..5873bc712404 100644
--- a/dbaccess/source/ui/app/AppView.cxx
+++ b/dbaccess/source/ui/app/AppView.cxx
@@ -237,7 +237,7 @@ void OApplicationView::paste()
         pTest->paste();
 }
 
-OUString OApplicationView::getQualifiedName(weld::TreeIter* _pEntry) const
+OUString OApplicationView::getQualifiedName(const weld::TreeIter* _pEntry) const
 {
     OSL_ENSURE(m_pWin && getDetailView(),"Detail view is NULL! -> GPF");
     return getDetailView()->getQualifiedName( _pEntry );
diff --git a/dbaccess/source/ui/app/AppView.hxx b/dbaccess/source/ui/app/AppView.hxx
index 4cc68c04ef4a..b3a5706c54b5 100644
--- a/dbaccess/source/ui/app/AppView.hxx
+++ b/dbaccess/source/ui/app/AppView.hxx
@@ -134,7 +134,7 @@ namespace dbaui
             @return
                 the qualified name
         */
-        OUString getQualifiedName(weld::TreeIter* _pEntry) const;
+        OUString getQualifiedName(const weld::TreeIter* _pEntry) const;
 
         /** returns if an entry is a leaf
             @param rTreeView
diff --git a/dbaccess/source/ui/browser/dsEntriesNoExp.cxx b/dbaccess/source/ui/browser/dsEntriesNoExp.cxx
index 6e5b73e06db5..d98f9dedadc2 100644
--- a/dbaccess/source/ui/browser/dsEntriesNoExp.cxx
+++ b/dbaccess/source/ui/browser/dsEntriesNoExp.cxx
@@ -111,7 +111,7 @@ SbaTableQueryBrowser::EntryType SbaTableQueryBrowser::getEntryType(const weld::T
     return etQueryContainer;
 }
 
-void SbaTableQueryBrowser::select(weld::TreeIter* pEntry, bool bSelect)
+void SbaTableQueryBrowser::select(const weld::TreeIter* pEntry, bool bSelect)
 {
     if (pEntry)
     {
@@ -124,7 +124,7 @@ void SbaTableQueryBrowser::select(weld::TreeIter* pEntry, bool bSelect)
     }
 }
 
-void SbaTableQueryBrowser::selectPath(weld::TreeIter* pEntry, bool bSelect)
+void SbaTableQueryBrowser::selectPath(const weld::TreeIter* pEntry, bool bSelect)
 {
     if (!pEntry)
         return;
diff --git a/dbaccess/source/ui/browser/dsbrowserDnD.cxx b/dbaccess/source/ui/browser/dsbrowserDnD.cxx
index 597719f66618..7d51a5abf8fb 100644
--- a/dbaccess/source/ui/browser/dsbrowserDnD.cxx
+++ b/dbaccess/source/ui/browser/dsbrowserDnD.cxx
@@ -199,7 +199,7 @@ namespace dbaui
         return  ( eType == etTableOrView || eType == etQuery );
     }
 
-    void SbaTableQueryBrowser::copyEntry(weld::TreeIter& rEntry)
+    void SbaTableQueryBrowser::copyEntry(const weld::TreeIter& rEntry)
     {
         EntryType eType = getEntryType(rEntry);
         rtl::Reference<ODataClipboard> xTransfer(new ODataClipboard);
diff --git a/dbaccess/source/ui/browser/unodatbr.cxx b/dbaccess/source/ui/browser/unodatbr.cxx
index 26a8583230f3..2a6cbf9136b5 100644
--- a/dbaccess/source/ui/browser/unodatbr.cxx
+++ b/dbaccess/source/ui/browser/unodatbr.cxx
@@ -2488,7 +2488,7 @@ std::unique_ptr<weld::TreeIter> SbaTableQueryBrowser::implGetConnectionEntry(wel
     return xCurrentEntry;
 }
 
-bool SbaTableQueryBrowser::implSelect(weld::TreeIter* pEntry)
+bool SbaTableQueryBrowser::implSelect(const weld::TreeIter* pEntry)
 {
     if ( !pEntry )
         return false;
@@ -2957,7 +2957,7 @@ void SbaTableQueryBrowser::impl_releaseConnection( SharedConnection& _rxConnecti
         // will implicitly dispose if we have the ownership, since xConnection is a SharedConnection
 }
 
-void SbaTableQueryBrowser::disposeConnection(weld::TreeIter* pDSEntry)
+void SbaTableQueryBrowser::disposeConnection(const weld::TreeIter* pDSEntry)
 {
     OSL_ENSURE( pDSEntry, "SbaTableQueryBrowser::disposeConnection: invalid entry (NULL)!" );
     OSL_ENSURE( impl_isDataSourceEntry( pDSEntry ), "SbaTableQueryBrowser::disposeConnection: invalid entry (not top-level)!" );
diff --git a/dbaccess/source/ui/control/tabletree.cxx b/dbaccess/source/ui/control/tabletree.cxx
index b39f6e65319e..415cc97d5fd7 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -279,7 +279,7 @@ bool OTableTreeListBox::isWildcardChecked(const weld::TreeIter& rEntry)
     return m_xTreeView->get_text_emphasis(rEntry, 0);
 }
 
-void OTableTreeListBox::checkWildcard(weld::TreeIter& rEntry)
+void OTableTreeListBox::checkWildcard(const weld::TreeIter& rEntry)
 {
     if (!m_bShowToggles)
         return;
diff --git a/dbaccess/source/ui/inc/WCopyTable.hxx b/dbaccess/source/ui/inc/WCopyTable.hxx
index ca78c1a67985..6307234e89de 100644
--- a/dbaccess/source/ui/inc/WCopyTable.hxx
+++ b/dbaccess/source/ui/inc/WCopyTable.hxx
@@ -385,7 +385,7 @@ namespace dbaui
         void clearDestColumns();
 
         css::uno::Reference< css::beans::XPropertySet > returnTable();
-        css::uno::Reference< css::beans::XPropertySet > getTable();
+        css::uno::Reference< css::beans::XPropertySet > getTable() const;
         css::uno::Reference< css::beans::XPropertySet > createTable();
         css::uno::Reference< css::beans::XPropertySet > createView() const;
         sal_Int32 getMaxColumnNameLength() const;
diff --git a/dbaccess/source/ui/inc/tabletree.hxx b/dbaccess/source/ui/inc/tabletree.hxx
index 482800968dae..941ba2a1a80c 100644
--- a/dbaccess/source/ui/inc/tabletree.hxx
+++ b/dbaccess/source/ui/inc/tabletree.hxx
@@ -93,7 +93,7 @@ public:
         from checking the entry itself. The second is called 'wildcard' checking, 'cause in the resulting
         table filter it's represented by a wildcard.</p>
     */
-    void            checkWildcard(weld::TreeIter& rEntry);
+    void            checkWildcard(const weld::TreeIter& rEntry);
 
     /** determine if the given entry is 'wildcard checked'
         @see checkWildcard
diff --git a/dbaccess/source/ui/inc/unodatbr.hxx b/dbaccess/source/ui/inc/unodatbr.hxx
index ed035d068f3f..e147b44b9e02 100644
--- a/dbaccess/source/ui/inc/unodatbr.hxx
+++ b/dbaccess/source/ui/inc/unodatbr.hxx
@@ -236,9 +236,9 @@ namespace dbaui
         // returns <TRUE/> if the entry is selected (which means it's part of the selected path)
         bool isSelected(const weld::TreeIter& rEntry) const;
         // select the entry (and only the entry, not the whole path)
-        void        select(weld::TreeIter* pEntry, bool bSelect);
+        void        select(const weld::TreeIter* pEntry, bool bSelect);
         // select the path of the entry (which must be an entry without children)
-        void        selectPath(weld::TreeIter* pEntry, bool bSelect = true);
+        void        selectPath(const weld::TreeIter* pEntry, bool bSelect = true);
 
         virtual void loadMenu(const css::uno::Reference< css::frame::XFrame >& _xFrame) override;
 
@@ -282,7 +282,7 @@ namespace dbaui
         void unloadAndCleanup( bool _bDisposeConnection = true );
 
         // disposes the connection associated with the given entry (which must represent a data source)
-        void        disposeConnection(weld::TreeIter* xpDSEntry);
+        void        disposeConnection(const weld::TreeIter* xpDSEntry);
 
         /// flushes and disposes the given connection, and de-registers as listener
         void        impl_releaseConnection( SharedConnection& _rxConnection );
@@ -337,7 +337,7 @@ namespace dbaui
         void implRemoveStatusListeners();
 
         bool implSelect(const svx::ODataAccessDescriptor& _rDescriptor, bool _bSelectDirect = false);
-        bool implSelect(weld::TreeIter* pEntry);
+        bool implSelect(const weld::TreeIter* pEntry);
 
         /// selects the entry given and loads the grid control with the object's data
         bool implSelect(
@@ -417,7 +417,7 @@ namespace dbaui
 
         bool isEntryCopyAllowed(const weld::TreeIter& rEntry) const;
 
-        void copyEntry(weld::TreeIter& rEntry);
+        void copyEntry(const weld::TreeIter& rEntry);
 
         // remove all grid columns and dispose them
         static void clearGridColumns(const css::uno::Reference< css::container::XNameContainer >& _xColContainer);
diff --git a/dbaccess/source/ui/misc/WCopyTable.cxx b/dbaccess/source/ui/misc/WCopyTable.cxx
index f395a59d2ba9..373a17907952 100644
--- a/dbaccess/source/ui/misc/WCopyTable.cxx
+++ b/dbaccess/source/ui/misc/WCopyTable.cxx
@@ -1143,7 +1143,7 @@ Reference< XPropertySet > OCopyTableWizard::returnTable()
         return createTable();
 }
 
-Reference< XPropertySet > OCopyTableWizard::getTable()
+Reference< XPropertySet > OCopyTableWizard::getTable() const
 {
     Reference< XPropertySet > xTable;