diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-06-22 15:44:52 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-06-22 15:46:13 +0100 |
commit | 90134af864d46e45ae4a1c9836ef6f83d7dbbfd2 (patch) | |
tree | 132895ed8cafbce4df5aa16cfa79579947fc1aea /dbaccess | |
parent | 0ca8c07e3d9eb111997cf387836efcbcefea0a4a (diff) |
cppcheck: noExplicitConstructor
Change-Id: I913f983bb0f55e05bb5ec8994ee75a7e7d69bd1b
Diffstat (limited to 'dbaccess')
-rw-r--r-- | dbaccess/source/core/api/BookmarkSet.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/api/CacheSet.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/api/FilteredContainer.cxx | 4 | ||||
-rw-r--r-- | dbaccess/source/core/api/OptimisticSet.cxx | 4 | ||||
-rw-r--r-- | dbaccess/source/core/api/PrivateRow.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/api/RowSet.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/api/RowSetBase.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/api/RowSetRow.hxx | 4 | ||||
-rw-r--r-- | dbaccess/source/core/api/query.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/api/querydescriptor.hxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/dataaccess/ComponentDefinition.cxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/dataaccess/ModelImpl.cxx | 2 | ||||
-rw-r--r-- | dbaccess/source/core/dataaccess/ModelImpl.hxx | 8 |
13 files changed, 19 insertions, 19 deletions
diff --git a/dbaccess/source/core/api/BookmarkSet.hxx b/dbaccess/source/core/api/BookmarkSet.hxx index 2f86adcafa1b..70667a9b35a0 100644 --- a/dbaccess/source/core/api/BookmarkSet.hxx +++ b/dbaccess/source/core/api/BookmarkSet.hxx @@ -32,7 +32,7 @@ namespace dbaccess void updateColumn(sal_Int32 nPos,::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XRowUpdate > _xParameter,const connectivity::ORowSetValue& _rValue); public: - OBookmarkSet(sal_Int32 i_nMaxRows) : OCacheSet(i_nMaxRows) + explicit OBookmarkSet(sal_Int32 i_nMaxRows) : OCacheSet(i_nMaxRows) {} virtual ~OBookmarkSet() { diff --git a/dbaccess/source/core/api/CacheSet.hxx b/dbaccess/source/core/api/CacheSet.hxx index ad6293af1326..f6269e0b12e6 100644 --- a/dbaccess/source/core/api/CacheSet.hxx +++ b/dbaccess/source/core/api/CacheSet.hxx @@ -55,7 +55,7 @@ namespace dbaccess bool m_bDeleted; OUString m_sRowSetFilter; - OCacheSet(sal_Int32 i_nMaxRows); + explicit OCacheSet(sal_Int32 i_nMaxRows); virtual ~OCacheSet(); static void setParameter(sal_Int32 nPos diff --git a/dbaccess/source/core/api/FilteredContainer.cxx b/dbaccess/source/core/api/FilteredContainer.cxx index 4002ce9845fd..f0843dbebce3 100644 --- a/dbaccess/source/core/api/FilteredContainer.cxx +++ b/dbaccess/source/core/api/FilteredContainer.cxx @@ -103,8 +103,8 @@ sal_Int32 createWildCardVector(Sequence< OUString >& _rTableFilter, ::std::vecto OptionalString sSchema; OptionalString sName; - TableInfo( const OUString& _composedName ) - :sComposedName( _composedName ) + explicit TableInfo( const OUString& _composedName ) + : sComposedName( _composedName ) { } diff --git a/dbaccess/source/core/api/OptimisticSet.cxx b/dbaccess/source/core/api/OptimisticSet.cxx index 4a917821fcbf..0a5721f65dbd 100644 --- a/dbaccess/source/core/api/OptimisticSet.cxx +++ b/dbaccess/source/core/api/OptimisticSet.cxx @@ -483,7 +483,7 @@ namespace struct PositionFunctor : ::std::unary_function<SelectColumnsMetaData::value_type,bool> { sal_Int32 m_nPos; - PositionFunctor(sal_Int32 i_nPos) + explicit PositionFunctor(sal_Int32 i_nPos) : m_nPos(i_nPos) { } @@ -496,7 +496,7 @@ namespace struct TableNameFunctor : ::std::unary_function<SelectColumnsMetaData::value_type,bool> { OUString m_sTableName; - TableNameFunctor(const OUString& i_sTableName) + explicit TableNameFunctor(const OUString& i_sTableName) : m_sTableName(i_sTableName) { } diff --git a/dbaccess/source/core/api/PrivateRow.hxx b/dbaccess/source/core/api/PrivateRow.hxx index 016d5f082ec6..99583b73f53a 100644 --- a/dbaccess/source/core/api/PrivateRow.hxx +++ b/dbaccess/source/core/api/PrivateRow.hxx @@ -30,7 +30,7 @@ namespace dbaccess ORowSetValueVector::Vector m_aRow; sal_Int32 m_nPos; public: - OPrivateRow(const ORowSetValueVector::Vector& i_aRow) : m_aRow(i_aRow),m_nPos(0) + explicit OPrivateRow(const ORowSetValueVector::Vector& i_aRow) : m_aRow(i_aRow),m_nPos(0) { } virtual sal_Bool SAL_CALL wasNull( ) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/dbaccess/source/core/api/RowSet.hxx b/dbaccess/source/core/api/RowSet.hxx index 19e50f55ff52..d227476e8f57 100644 --- a/dbaccess/source/core/api/RowSet.hxx +++ b/dbaccess/source/core/api/RowSet.hxx @@ -244,7 +244,7 @@ namespace dbaccess virtual ~ORowSet(); public: - ORowSet(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >&); + explicit ORowSet(const css::uno::Reference<css::uno::XComponentContext>&); // com::sun::star::lang::XTypeProvider virtual ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Type > SAL_CALL getTypes() throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/dbaccess/source/core/api/RowSetBase.hxx b/dbaccess/source/core/api/RowSetBase.hxx index 3e111c1182e7..f5dd9541f511 100644 --- a/dbaccess/source/core/api/RowSetBase.hxx +++ b/dbaccess/source/core/api/RowSetBase.hxx @@ -374,7 +374,7 @@ namespace dbaccess @see ORowSetBase::doCancelModification */ - ORowSetNotifier( ORowSetBase* m_pRowSet ); + explicit ORowSetNotifier( ORowSetBase* m_pRowSet ); /** use this one to consturct an vector for change value notification */ diff --git a/dbaccess/source/core/api/RowSetRow.hxx b/dbaccess/source/core/api/RowSetRow.hxx index 22dee65b6b9a..6c4f1acc9306 100644 --- a/dbaccess/source/core/api/RowSetRow.hxx +++ b/dbaccess/source/core/api/RowSetRow.hxx @@ -39,7 +39,7 @@ namespace dbaccess ORowSetOldRowHelper(const ORowSetOldRowHelper& _rRh) SAL_DELETED_FUNCTION; public: ORowSetOldRowHelper(){} - ORowSetOldRowHelper(const ORowSetRow& _rRow) + explicit ORowSetOldRowHelper(const ORowSetRow& _rRow) : m_aRow(_rRow) {} @@ -54,7 +54,7 @@ namespace dbaccess { const ::com::sun::star::uno::Any& m_rAny; public: - ORowSetValueCompare(const ::com::sun::star::uno::Any& _rAny) : m_rAny(_rAny){} + explicit ORowSetValueCompare(const ::com::sun::star::uno::Any& _rAny) : m_rAny(_rAny){} bool operator ()(const ORowSetRow& _rRH) { diff --git a/dbaccess/source/core/api/query.hxx b/dbaccess/source/core/api/query.hxx index baf50c20b206..6204f766faa2 100644 --- a/dbaccess/source/core/api/query.hxx +++ b/dbaccess/source/core/api/query.hxx @@ -79,7 +79,7 @@ protected: { OQuery* m_pActor; public: - OAutoActionReset(OQuery* _pActor) : m_pActor(_pActor) { } + explicit OAutoActionReset(OQuery* _pActor) : m_pActor(_pActor) { } ~OAutoActionReset() { m_pActor->m_eDoingCurrently = NONE; } }; diff --git a/dbaccess/source/core/api/querydescriptor.hxx b/dbaccess/source/core/api/querydescriptor.hxx index cbf12e5d981e..dabc24f0807d 100644 --- a/dbaccess/source/core/api/querydescriptor.hxx +++ b/dbaccess/source/core/api/querydescriptor.hxx @@ -126,7 +126,7 @@ protected: virtual ~OQueryDescriptor(); public: OQueryDescriptor(); - OQueryDescriptor(const OQueryDescriptor_Base& _rSource); + explicit OQueryDescriptor(const OQueryDescriptor_Base& _rSource); virtual css::uno::Sequence<css::uno::Type> SAL_CALL getTypes() throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/dbaccess/source/core/dataaccess/ComponentDefinition.cxx b/dbaccess/source/core/dataaccess/ComponentDefinition.cxx index 41b39829965f..3c9d0b188172 100644 --- a/dbaccess/source/core/dataaccess/ComponentDefinition.cxx +++ b/dbaccess/source/core/dataaccess/ComponentDefinition.cxx @@ -60,7 +60,7 @@ class OColumnPropertyListener: protected: virtual ~OColumnPropertyListener(){} public: - OColumnPropertyListener(OComponentDefinition* _pComponent) : m_pComponent(_pComponent){} + explicit OColumnPropertyListener(OComponentDefinition* _pComponent) : m_pComponent(_pComponent){} // XPropertyChangeListener virtual void SAL_CALL propertyChange( const PropertyChangeEvent& /*_rEvent*/ ) throw (RuntimeException, std::exception) SAL_OVERRIDE { diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx b/dbaccess/source/core/dataaccess/ModelImpl.cxx index 40575e5f51b7..773b5b9ec0a8 100644 --- a/dbaccess/source/core/dataaccess/ModelImpl.cxx +++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx @@ -121,7 +121,7 @@ class DocumentStorageAccess : public ::cppu::WeakImplHelper2< XDocumentSubStor bool m_bDisposingSubStorages; public: - DocumentStorageAccess( ODatabaseModelImpl& _rModelImplementation ) + explicit DocumentStorageAccess( ODatabaseModelImpl& _rModelImplementation ) :m_pModelImplementation( &_rModelImplementation ) ,m_bPropagateCommitToRoot( true ) ,m_bDisposingSubStorages( false ) diff --git a/dbaccess/source/core/dataaccess/ModelImpl.hxx b/dbaccess/source/core/dataaccess/ModelImpl.hxx index d51070c641b1..f1f2d8acaf74 100644 --- a/dbaccess/source/core/dataaccess/ModelImpl.hxx +++ b/dbaccess/source/core/dataaccess/ModelImpl.hxx @@ -128,7 +128,7 @@ public: /** beware of life time: the mutex you pass here must live as least as long as the VosMutexFacade instance lives. */ - VosMutexFacade( ::osl::Mutex& _rMutex ); + explicit VosMutexFacade( ::osl::Mutex& _rMutex ); virtual void acquire() SAL_OVERRIDE; virtual void release() SAL_OVERRIDE; @@ -509,7 +509,7 @@ protected: mutable ::comphelper::SharedMutex m_aMutex; protected: - ModelDependentComponent( const ::rtl::Reference< ODatabaseModelImpl >& _model ); + explicit ModelDependentComponent( const ::rtl::Reference< ODatabaseModelImpl >& _model ); virtual ~ModelDependentComponent(); /** returns the component itself @@ -560,7 +560,7 @@ public: class ModifyLock { public: - ModifyLock( ModelDependentComponent& _component ) + explicit ModifyLock( ModelDependentComponent& _component ) :m_rComponent( _component ) { m_rComponent.lockModify(); @@ -594,7 +594,7 @@ public: @throws ::com::sun::star::lang::DisposedException If the given component is already disposed */ - ModelMethodGuard( const ModelDependentComponent& _component ) + explicit ModelMethodGuard( const ModelDependentComponent& _component ) :BaseMutexGuard( _component.getMutex( ModelDependentComponent::GuardAccess() ) ) { _component.checkDisposed(); |