diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2022-09-04 21:11:36 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-09-05 08:57:18 +0200 |
| commit | 08b923efcb22bae08c799ccc654797076468fa83 (patch) | |
| tree | 9701b5d88f13c0b7263a6c711b69f8e7f1e087f4 /dbaccess | |
| parent | 90f3182141d37407715254d5118aae907d559b41 (diff) | |
DataSourceMetaData doesn't need a pimpl
it is module private
Change-Id: Ib0817d7964e603157a9369d3ef0685e2b79f0aa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139376
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
| -rw-r--r-- | dbaccess/source/ui/inc/dsmeta.hxx | 3 | ||||
| -rw-r--r-- | dbaccess/source/ui/misc/dsmeta.cxx | 21 |
2 files changed, 3 insertions, 21 deletions
diff --git a/dbaccess/source/ui/inc/dsmeta.hxx b/dbaccess/source/ui/inc/dsmeta.hxx index 69b13ebb7965..0c8646a53cbd 100644 --- a/dbaccess/source/ui/inc/dsmeta.hxx +++ b/dbaccess/source/ui/inc/dsmeta.hxx @@ -42,7 +42,6 @@ namespace dbaui // DataSourceMetaData class FeatureSet; - class DataSourceMetaData_Impl; /** encapsulates meta data for a data source On the long run, this class should a) encapsulate *all* meta data which @@ -65,7 +64,7 @@ namespace dbaui static AuthenticationMode getAuthentication( const OUString& _sURL ); private: - std::shared_ptr< DataSourceMetaData_Impl > m_pImpl; + OUString m_sURL; }; // FeatureSet diff --git a/dbaccess/source/ui/misc/dsmeta.cxx b/dbaccess/source/ui/misc/dsmeta.cxx index 402bdd7bfa34..526a39ecbcff 100644 --- a/dbaccess/source/ui/misc/dsmeta.cxx +++ b/dbaccess/source/ui/misc/dsmeta.cxx @@ -140,26 +140,9 @@ namespace dbaui return s_aSupport[ _sURL ].eAuthentication; } - // DataSourceMetaData_Impl - class DataSourceMetaData_Impl - { - public: - explicit DataSourceMetaData_Impl(OUString sURL); - - const OUString& getType() const { return m_sURL; } - - private: - const OUString m_sURL; - }; - - DataSourceMetaData_Impl::DataSourceMetaData_Impl( OUString _sURL ) - :m_sURL(std::move( _sURL )) - { - } - // DataSourceMetaData DataSourceMetaData::DataSourceMetaData( const OUString& _sURL ) - :m_pImpl( std::make_shared<DataSourceMetaData_Impl>( _sURL ) ) + :m_sURL( _sURL ) { } @@ -169,7 +152,7 @@ namespace dbaui const FeatureSet& DataSourceMetaData::getFeatureSet() const { - return lcl_getFeatureSet( m_pImpl->getType() ); + return lcl_getFeatureSet( m_sURL ); } AuthenticationMode DataSourceMetaData::getAuthentication( const OUString& _sURL ) |