summaryrefslogtreecommitdiff
path: root/dbaccess
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2016-03-23 10:50:37 +0200
committerNoel Grandin <noel@peralex.com>2016-03-23 11:22:34 +0200
commit26d02747847a8ec9745713d7e2409c72b5fd7138 (patch)
tree0452c52a632896fd4d79ae2391e318912fa21656 /dbaccess
parent46377531593cf3484f4b48c5398a03bbaaf0d053 (diff)
loplugin:constantparam in dbaccess
Change-Id: I81c1385ec6881fe9b8f75b5506268f5e7b03e2cb
Diffstat (limited to 'dbaccess')
-rw-r--r--dbaccess/source/ui/inc/QueryDesignView.hxx2
-rw-r--r--dbaccess/source/ui/querydesign/QueryDesignView.cxx14
2 files changed, 8 insertions, 8 deletions
diff --git a/dbaccess/source/ui/inc/QueryDesignView.hxx b/dbaccess/source/ui/inc/QueryDesignView.hxx
index 82b1b6146c3f..743b33d9abeb 100644
--- a/dbaccess/source/ui/inc/QueryDesignView.hxx
+++ b/dbaccess/source/ui/inc/QueryDesignView.hxx
@@ -108,7 +108,7 @@ namespace dbaui
css::lang::Locale getLocale() const { return m_aLocale;}
OUString getDecimalSeparator() const { return m_sDecimalSep;}
- SqlParseError InsertField( const OTableFieldDescRef& rInfo, bool bVis = true, bool bActivate = true);
+ SqlParseError InsertField( const OTableFieldDescRef& rInfo, bool bActivate = true);
bool HasFieldByAliasName(const OUString& rFieldName, OTableFieldDescRef& rInfo) const;
// save the position of the table window and the pos of the splitters
// called when fields are deleted
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index 00d4b662fab3..bee37f84f928 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -2107,7 +2107,7 @@ namespace
OTableFieldDescRef aInfo = new OTableFieldDesc();
if (pTabWin->ExistsField( "*", aInfo ))
{
- eErrorCode = _pView->InsertField(aInfo, true, bFirstField);
+ eErrorCode = _pView->InsertField(aInfo, bFirstField);
bFirstField = false;
}
}
@@ -2165,7 +2165,7 @@ namespace
if (SQL_ISRULE(pColumnRef,column_ref))
{
InsertColumnRef(_pView,pColumnRef,aColumnName,aColumnAlias,aTableRange,aInfo,pTabList);
- eErrorCode = _pView->InsertField(aInfo, true, bFirstField);
+ eErrorCode = _pView->InsertField(aInfo, bFirstField);
bFirstField = false;
}
else if(SQL_ISRULEOR3(pColumnRef, general_set_fct, set_fct_spec, position_exp) ||
@@ -2244,7 +2244,7 @@ namespace
else
aInfo->SetFunctionType(nFunctionType|FKT_OTHER);
- eErrorCode = _pView->InsertField(aInfo, true, bFirstField);
+ eErrorCode = _pView->InsertField(aInfo, bFirstField);
bFirstField = false;
}
else
@@ -2272,7 +2272,7 @@ namespace
aInfo->SetFieldAlias(aColumnAlias);
aInfo->SetFunctionType(FKT_NUMERIC | FKT_OTHER);
- eErrorCode = _pView->InsertField(aInfo, true, bFirstField);
+ eErrorCode = _pView->InsertField(aInfo, bFirstField);
bFirstField = false;
}
@@ -2717,9 +2717,9 @@ bool OQueryDesignView::HasFieldByAliasName(const OUString& rFieldName, OTableFie
return m_pSelectionBox->HasFieldByAliasName( rFieldName, rInfo);
}
-SqlParseError OQueryDesignView::InsertField( const OTableFieldDescRef& rInfo, bool bVis, bool bActivate)
+SqlParseError OQueryDesignView::InsertField( const OTableFieldDescRef& rInfo, bool bActivate)
{
- return m_pSelectionBox->InsertField( rInfo, BROWSER_INVALIDID,bVis, bActivate ).is() ? eOk : eTooManyColumns;
+ return m_pSelectionBox->InsertField( rInfo, BROWSER_INVALIDID, true/*bVis*/, bActivate ).is() ? eOk : eTooManyColumns;
}
sal_Int32 OQueryDesignView::getColWidth(sal_uInt16 _nColPos) const
@@ -3139,7 +3139,7 @@ void OQueryDesignView::initByFieldDescriptions( const Sequence< PropertyValue >&
{
::rtl::Reference< OTableFieldDesc > pField( new OTableFieldDesc() );
pField->Load( *field, true );
- InsertField( pField, true, false );
+ InsertField( pField, false );
}
rController.ClearUndoManager();