summaryrefslogtreecommitdiff
path: root/dbaccess
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-12-04 14:20:26 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-12-05 07:32:46 +0100
commit9a06b99d2f53bd8d0a9ab0936efed9924a2abb88 (patch)
tree544f3e51a3978bd234a1c9fcdbf12d9b84352da4 /dbaccess
parenteaf89e477af94bd3977aca17d72dd442c7604e63 (diff)
loplugin:salcall fix non-virtual methods
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
-rw-r--r--dbaccess/source/core/api/KeySet.hxx2
-rw-r--r--dbaccess/source/core/dataaccess/ModelImpl.cxx6
-rw-r--r--dbaccess/source/core/dataaccess/datasource.cxx6
-rw-r--r--dbaccess/source/core/dataaccess/datasource.hxx4
-rw-r--r--dbaccess/source/core/dataaccess/intercept.cxx2
-rw-r--r--dbaccess/source/core/dataaccess/intercept.hxx2
-rw-r--r--dbaccess/source/core/inc/ModelImpl.hxx6
7 files changed, 14 insertions, 14 deletions
diff --git a/dbaccess/source/core/api/KeySet.hxx b/dbaccess/source/core/api/KeySet.hxx
index d72643385d87..45262f53d5d3 100644
--- a/dbaccess/source/core/api/KeySet.hxx
+++ b/dbaccess/source/core/api/KeySet.hxx
@@ -198,7 +198,7 @@ namespace dbaccess
virtual bool SAL_CALL previous( ) override;
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
- void SAL_CALL ensureRowForData( );
+ void ensureRowForData( );
virtual void SAL_CALL refreshRow( ) override;
// css::sdbcx::XRowLocate
virtual css::uno::Any SAL_CALL getBookmark() override;
diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 48643a9c4892..766eafdcb725 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -623,7 +623,7 @@ void ODatabaseModelImpl::reset()
}
}
-void SAL_CALL ODatabaseModelImpl::disposing( const css::lang::EventObject& Source )
+void ODatabaseModelImpl::disposing( const css::lang::EventObject& Source )
{
Reference<XConnection> xCon(Source.Source,UNO_QUERY);
if ( xCon.is() )
@@ -975,12 +975,12 @@ Reference< XModel > ODatabaseModelImpl::createNewModel_deliverOwnership()
return xModel;
}
-void SAL_CALL ODatabaseModelImpl::acquire()
+void ODatabaseModelImpl::acquire()
{
osl_atomic_increment(&m_refCount);
}
-void SAL_CALL ODatabaseModelImpl::release()
+void ODatabaseModelImpl::release()
{
if ( osl_atomic_decrement(&m_refCount) == 0 )
{
diff --git a/dbaccess/source/core/dataaccess/datasource.cxx b/dbaccess/source/core/dataaccess/datasource.cxx
index 2e5d452b616c..eeeb9850f68e 100644
--- a/dbaccess/source/core/dataaccess/datasource.cxx
+++ b/dbaccess/source/core/dataaccess/datasource.cxx
@@ -119,7 +119,7 @@ protected:
FlushNotificationAdapter( const Reference< XFlushable >& _rxBroadcaster, const Reference< XFlushListener >& _rxListener );
virtual ~FlushNotificationAdapter() override;
- void SAL_CALL impl_dispose();
+ void impl_dispose();
protected:
// XFlushListener
@@ -147,7 +147,7 @@ FlushNotificationAdapter::~FlushNotificationAdapter()
{
}
-void SAL_CALL FlushNotificationAdapter::impl_dispose()
+void FlushNotificationAdapter::impl_dispose()
{
Reference< XFlushListener > xKeepAlive( this );
@@ -1021,7 +1021,7 @@ Reference< XConnection > SAL_CALL ODatabaseSource::getIsolatedConnectionWithComp
return connectWithCompletion(_rxHandler,true);
}
-Reference< XConnection > SAL_CALL ODatabaseSource::connectWithCompletion( const Reference< XInteractionHandler >& _rxHandler,bool _bIsolated )
+Reference< XConnection > ODatabaseSource::connectWithCompletion( const Reference< XInteractionHandler >& _rxHandler,bool _bIsolated )
{
ModelMethodGuard aGuard( *this );
diff --git a/dbaccess/source/core/dataaccess/datasource.hxx b/dbaccess/source/core/dataaccess/datasource.hxx
index c513064a2dd5..7d6401922271 100644
--- a/dbaccess/source/core/dataaccess/datasource.hxx
+++ b/dbaccess/source/core/dataaccess/datasource.hxx
@@ -202,10 +202,10 @@ private:
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
- css::uno::Reference< css::sdbc::XConnection > SAL_CALL getConnection( const OUString& user, const OUString& password , bool _bIsolated);
+ css::uno::Reference< css::sdbc::XConnection > getConnection( const OUString& user, const OUString& password , bool _bIsolated);
/// @throws css::sdbc::SQLException
/// @throws css::uno::RuntimeException
- css::uno::Reference< css::sdbc::XConnection > SAL_CALL connectWithCompletion( const css::uno::Reference< css::task::XInteractionHandler >& handler , bool _bIsolated);
+ css::uno::Reference< css::sdbc::XConnection > connectWithCompletion( const css::uno::Reference< css::task::XInteractionHandler >& handler , bool _bIsolated);
protected:
using ::cppu::OPropertySetHelper::getFastPropertyValue;
diff --git a/dbaccess/source/core/dataaccess/intercept.cxx b/dbaccess/source/core/dataaccess/intercept.cxx
index aebd2df2600f..de566166743e 100644
--- a/dbaccess/source/core/dataaccess/intercept.cxx
+++ b/dbaccess/source/core/dataaccess/intercept.cxx
@@ -54,7 +54,7 @@ using namespace ::cppu;
#define DISPATCH_RELOAD 5
// the OSL_ENSURE in CTOR has to be changed too, when adding new defines
-void SAL_CALL OInterceptor::dispose()
+void OInterceptor::dispose()
{
EventObject aEvt( *this );
diff --git a/dbaccess/source/core/dataaccess/intercept.hxx b/dbaccess/source/core/dataaccess/intercept.hxx
index 39ed7fc428e5..cfb83676f5ab 100644
--- a/dbaccess/source/core/dataaccess/intercept.hxx
+++ b/dbaccess/source/core/dataaccess/intercept.hxx
@@ -45,7 +45,7 @@ public:
explicit OInterceptor( ODocumentDefinition* _pContentHolder );
/// @throws css::uno::RuntimeException
- void SAL_CALL dispose();
+ void dispose();
//XDispatch
virtual void SAL_CALL
diff --git a/dbaccess/source/core/inc/ModelImpl.hxx b/dbaccess/source/core/inc/ModelImpl.hxx
index 7a4931557bab..bf74d41adb08 100644
--- a/dbaccess/source/core/inc/ModelImpl.hxx
+++ b/dbaccess/source/core/inc/ModelImpl.hxx
@@ -277,7 +277,7 @@ public:
// XEventListener
/// @throws css::uno::RuntimeException
- void SAL_CALL disposing( const css::lang::EventObject& Source );
+ void disposing( const css::lang::EventObject& Source );
void setModified( bool bModified );
@@ -369,9 +369,9 @@ public:
const ::comphelper::SharedMutex& getSharedMutex() const { return m_aMutex; }
- void SAL_CALL acquire();
+ void acquire();
- void SAL_CALL release();
+ void release();
/// returns a all known data source settings, including their default values
static const AsciiPropertyValue* getDefaultDataSourceSettings();