Revert "new loplugin typedefparam"

This reverts commit 9865440d217d975206a3f91612f0666312bc8fd8.

This is not ready to land yet, seems like the latest update
of the logic reveals a bunch more places I need to fix before it can land.

5 files changed, 18 insertions, 13 deletions

diff --git a/dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx b/dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx
index ec5572667dea..89371c735c44 100644
--- a/dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx
+++ b/dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx
@@ -48,7 +48,7 @@ void HsqlBinaryNode::readChildren(HsqlRowInputStream const& input)
 }
 
 std::vector<css::uno::Any> HsqlBinaryNode::readRow(HsqlRowInputStream& input,
-                                                   const std::vector<ColumnDefinition>& aColTypes,
+                                                   const ColumnTypeVector& aColTypes,
                                                    sal_Int32 nIndexCount)
 {
     // skip first 4 bytes (size), and index nodes, 16 bytes each
diff --git a/dbaccess/source/filter/hsqldb/hsqlimport.cxx b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
index dc5b51cc07ce..b29889c1b6cd 100644
--- a/dbaccess/source/filter/hsqldb/hsqlimport.cxx
+++ b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
@@ -48,8 +48,12 @@ using namespace css::io;
 using namespace css::uno;
 using namespace css::sdbc;
 
-void lcl_setParams(const std::vector<Any>& row, Reference<XParameters> const& xParam,
-                   const std::vector<dbahsql::ColumnDefinition>& rColTypes)
+using ColumnTypeVector = std::vector<dbahsql::ColumnDefinition>;
+using RowVector = std::vector<Any>;
+using IndexVector = std::vector<sal_Int32>;
+
+void lcl_setParams(const RowVector& row, Reference<XParameters> const& xParam,
+                   const ColumnTypeVector& rColTypes)
 {
     assert(row.size() == rColTypes.size());
     size_t nColIndex = 0;
@@ -178,8 +182,7 @@ void lcl_setParams(const std::vector<Any>& row, Reference<XParameters> const& xP
     }
 }
 
-OUString lcl_createInsertStatement(const OUString& sTableName,
-                                   const std::vector<dbahsql::ColumnDefinition>& rColTypes)
+OUString lcl_createInsertStatement(const OUString& sTableName, const ColumnTypeVector& rColTypes)
 {
     assert(rColTypes.size() > 0);
     OUStringBuffer sql("INSERT INTO ");
@@ -218,8 +221,8 @@ HsqlImporter::HsqlImporter(Reference<XConnection>& rConnection, const Reference<
     m_xStorage.set(rStorage);
 }
 
-void HsqlImporter::insertRow(const std::vector<css::uno::Any>& xRows, const OUString& sTableName,
-                             const std::vector<ColumnDefinition>& rColTypes)
+void HsqlImporter::insertRow(const RowVector& xRows, const OUString& sTableName,
+                             const ColumnTypeVector& rColTypes)
 {
     OUString sStatement = lcl_createInsertStatement(sTableName, rColTypes);
     Reference<XPreparedStatement> xStatement = m_rConnection->prepareStatement(sStatement);
@@ -233,8 +236,8 @@ void HsqlImporter::insertRow(const std::vector<css::uno::Any>& xRows, const OUSt
 }
 
 void HsqlImporter::processTree(HsqlBinaryNode& rNode, HsqlRowInputStream& rStream,
-                               const std::vector<ColumnDefinition>& rColTypes,
-                               const OUString& sTableName, sal_Int32 nIndexCount)
+                               const ColumnTypeVector& rColTypes, const OUString& sTableName,
+                               sal_Int32 nIndexCount)
 {
     rNode.readChildren(rStream);
     sal_Int32 nNext = rNode.getLeft();
@@ -264,7 +267,7 @@ void HsqlImporter::processTree(HsqlBinaryNode& rNode, HsqlRowInputStream& rStrea
  * Balance: ?
  * Left/Right/Parent: File position of the Left/Right/Parent child
  */
-void HsqlImporter::parseTableRows(const std::vector<sal_Int32>& rIndexes,
+void HsqlImporter::parseTableRows(const IndexVector& rIndexes,
                                   const std::vector<ColumnDefinition>& rColTypes,
                                   const OUString& sTableName)
 {
diff --git a/dbaccess/source/filter/hsqldb/parseschema.cxx b/dbaccess/source/filter/hsqldb/parseschema.cxx
index be08037b7be5..e04998c80f28 100644
--- a/dbaccess/source/filter/hsqldb/parseschema.cxx
+++ b/dbaccess/source/filter/hsqldb/parseschema.cxx
@@ -167,7 +167,7 @@ void SchemaParser::parseSchema()
     }
 }
 
-std::vector<ColumnDefinition> SchemaParser::getTableColumnTypes(const OUString& sTableName) const
+ColumnTypeVector SchemaParser::getTableColumnTypes(const OUString& sTableName) const
 {
     return m_ColumnTypes.at(sTableName);
 }
diff --git a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
index 24448f627971..5a447cacb4f3 100644
--- a/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
+++ b/dbaccess/source/filter/hsqldb/rowinputbinary.cxx
@@ -134,6 +134,8 @@ using namespace css::io;
 using namespace boost::posix_time;
 using namespace boost::gregorian;
 
+typedef std::vector<ColumnDefinition> ColumnTypeVector;
+
 HsqlRowInputStream::HsqlRowInputStream() {}
 
 void HsqlRowInputStream::setInputStream(Reference<XInputStream> const& rStream)
@@ -237,7 +239,7 @@ bool HsqlRowInputStream::checkNull()
     return nNull == 0;
 }
 
-std::vector<Any> HsqlRowInputStream::readOneRow(const std::vector<ColumnDefinition>& nColTypes)
+std::vector<Any> HsqlRowInputStream::readOneRow(const ColumnTypeVector& nColTypes)
 {
     auto nLen = nColTypes.size();
     std::vector<Any> aData;
diff --git a/dbaccess/source/ui/misc/charsets.cxx b/dbaccess/source/ui/misc/charsets.cxx
index 9404d777cea5..e068c18f98ef 100644
--- a/dbaccess/source/ui/misc/charsets.cxx
+++ b/dbaccess/source/ui/misc/charsets.cxx
@@ -86,7 +86,7 @@ namespace dbaui
     {
     }
 
-    CharsetDisplayDerefHelper::CharsetDisplayDerefHelper(const ::dbtools::CharsetIteratorDerefHelper& _rBase, const OUString& _rDisplayName)
+    CharsetDisplayDerefHelper::CharsetDisplayDerefHelper(const CharsetDisplayDerefHelper_Base& _rBase, const OUString& _rDisplayName)
         :CharsetDisplayDerefHelper_Base(_rBase)
         ,m_sDisplayName(_rDisplayName)
     {