diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-29 08:15:20 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-29 09:35:30 +0200 |
| commit | 497e40ad03c27837978551ba15491c3fb2a0bf53 (patch) | |
| tree | baa53156ae5234b65f645e11e590c64e569c6284 /dbaccess | |
| parent | 71112060e0930fc58087c3762e836b1e12b60f75 (diff) | |
improve refcounting loplugin
to find ref-counted classes being managed via other smart pointer
classes.
Hopefully prevent needing fixes like
642ae256ea5b8083ba0b3c097ca8ea52304b9cdb
"ChangedUIEventListener is refcounted, mustn't be helt by unique_ptr"
Change-Id: I6b0c5f8f87ce3546a8a1104ce1000470c09459bd
Reviewed-on: https://gerrit.libreoffice.org/39378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'dbaccess')
| -rw-r--r-- | dbaccess/source/core/api/TableDeco.cxx | 2 | ||||
| -rw-r--r-- | dbaccess/source/core/inc/TableDeco.hxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/dbaccess/source/core/api/TableDeco.cxx b/dbaccess/source/core/api/TableDeco.cxx index fb747850163b..1bc5d1d3a7d1 100644 --- a/dbaccess/source/core/api/TableDeco.cxx +++ b/dbaccess/source/core/api/TableDeco.cxx @@ -566,7 +566,7 @@ void ODBTableDecorator::refreshColumns() OContainerMediator* pMediator = new OContainerMediator( pCol, m_xColumnDefinitions ); m_xColumnMediator = pMediator; pCol->setMediator( pMediator ); - m_pColumns.reset( pCol ); + m_pColumns = pCol; } else m_pColumns->reFill(aVector); diff --git a/dbaccess/source/core/inc/TableDeco.hxx b/dbaccess/source/core/inc/TableDeco.hxx index 79f28a014cfa..7958b7a23c07 100644 --- a/dbaccess/source/core/inc/TableDeco.hxx +++ b/dbaccess/source/core/inc/TableDeco.hxx @@ -74,7 +74,7 @@ namespace dbaccess // <properties> mutable sal_Int32 m_nPrivileges; // </properties> - std::unique_ptr<::connectivity::sdbcx::OCollection> m_pColumns; + rtl::Reference<::connectivity::sdbcx::OCollection> m_pColumns; // IColumnFactory virtual OColumn* createColumn(const OUString& _rName) const override; |