screenshots: unify dumping of dialog test batch file

Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2

1 files changed, 2 insertions, 74 deletions

diff --git a/desktop/qa/unit/desktop-dialogs-test.cxx b/desktop/qa/unit/desktop-dialogs-test.cxx
index 5768b43eec45..ff654ff44424 100644
--- a/desktop/qa/unit/desktop-dialogs-test.cxx
+++ b/desktop/qa/unit/desktop-dialogs-test.cxx
@@ -67,80 +67,8 @@ VclAbstractDialog* DesktopDialogsTest::createDialogByID(sal_uInt32 /*nID*/)
 
 void DesktopDialogsTest::openAnyDialog()
 {
-    /// example how to process an input file containing the UXMLDescriptions of the dialogs
-    /// to dump
-    if (true)
-    {
-        test::Directories aDirectories;
-        OUString aURL = aDirectories.getURLFromSrc("desktop/qa/unit/data/desktop-dialogs-test.txt");
-        SvFileStream aStream(aURL, StreamMode::READ);
-        OString aNextUIFile;
-        const OString aComment("#");
-
-        while (aStream.ReadLine(aNextUIFile))
-        {
-            if (!aNextUIFile.isEmpty() && !aNextUIFile.startsWith(aComment))
-            {
-                // first check if it's a known dialog
-                std::unique_ptr<VclAbstractDialog> pDlg(createDialogByName(aNextUIFile));
-
-                if (pDlg)
-                {
-                    // known dialog, dump screenshot to path
-                    dumpDialogToPath(*pDlg);
-                }
-                else
-                {
-                    // unknown dialog, try fallback to generic created
-                    // VclBuilder-generated instance. Keep in mind that Dialogs
-                    // using this mechanism will probably not be layouted well
-                    // since the setup/initialization part is missing. Thus,
-                    // only use for fallback when only the UI file is available.
-                    dumpDialogToPath(aNextUIFile);
-                }
-            }
-        }
-    }
-
-    /// example how to dump all known dialogs
-    if (false)
-    {
-        // example for SfxTabDialog: 5 -> "modules/sdraw/ui/drawpagedialog.ui"
-        // example for TabDialog: 22 -> "modules/simpress/ui/headerfooterdialog.ui"
-        // example for self-adapted wizard: 0 -> "modules/simpress/ui/publishingdialog.ui"
-        for (mapType::const_iterator i = getKnownDialogs().begin(); i != getKnownDialogs().end(); i++)
-        {
-            std::unique_ptr<VclAbstractDialog> pDlg(createDialogByID((*i).second));
-
-            if (pDlg)
-            {
-                // known dialog, dump screenshot to path
-                dumpDialogToPath(*pDlg);
-            }
-            else
-            {
-                // unknown dialog, should not happen in this basic loop.
-                // You have probably forgotten to add a case and
-                // implementastion to createDialogByID, please do this
-            }
-        }
-    }
-
-    /// example how to dump a dialog using fallback functionality
-    if (false)
-    {
-        // unknown dialog, try fallback to generic created
-        // VclBuilder-generated instance. Keep in mind that Dialogs
-        // using this mechanism will probably not be layouted well
-        // since the setup/initialization part is missing. Thus,
-        // only use for fallback when only the UI file is available.
-        //
-        // Take any example here, it's only for demonstration - using
-        // even a known one to demonstrate the fallback possibility
-        const OString aUIXMLDescription("desktop/ui/cmdlinehelp.ui");
-
-        dumpDialogToPath(aUIXMLDescription);
-    }
+    /// process input file containing the UXMLDescriptions of the dialogs to dump
+    processDialogBatchFile("desktop/qa/unit/data/desktop-dialogs-test.txt");
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopDialogsTest);