diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2024-10-06 21:38:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-10-07 09:31:09 +0200 |
| commit | 0d0f2e7b1f6851b07e65b42aca40f37a5f311deb (patch) | |
| tree | adb49d478fb387a4df33c50df7268759249be002 /desktop/source | |
| parent | 837c60d29f23bd69d048e47b8667f78885a4c48b (diff) | |
cid#1606611 Data race condition
and
cid#1607663 Data race condition
cid#1606843 Data race condition
cid#1608340 Check of thread-shared field evades lock acquisition
Change-Id: I97b82d4302ead6b96ae19c15502c427952df2ede
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174566
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'desktop/source')
| -rw-r--r-- | desktop/source/deployment/gui/dp_gui_dialog2.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx index 4fe7a9622545..2d978ce080f0 100644 --- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx +++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx @@ -839,9 +839,9 @@ void ExtMgrDialog::showProgress( bool _bStart ) void ExtMgrDialog::updateProgress( const tools::Long nProgress ) { + std::unique_lock aGuard( m_aMutex ); if ( m_nProgress != nProgress ) { - std::unique_lock aGuard( m_aMutex ); m_nProgress = nProgress; m_aIdle.Start(); } @@ -945,6 +945,7 @@ IMPL_LINK_NOARG(ExtMgrDialog, HandleUpdateBtn, weld::Button&, void) IMPL_LINK_NOARG(ExtMgrDialog, TimeOutHdl, Timer *, void) { + std::unique_lock aGuard( m_aMutex ); if ( m_bStopProgress ) { m_bHasProgress = false; |