New loplugin:external

...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
namespace { struct S2: S1 { int f() { return 1; } }; }
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
namespace { int f(S2 s) { return s.f(); } }
}
int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2 files changed, 3 insertions, 3 deletions

diff --git a/desktop/unx/source/pagein.c b/desktop/unx/source/pagein.c
index a401419fc162..03aa50d99c9d 100644
--- a/desktop/unx/source/pagein.c
+++ b/desktop/unx/source/pagein.c
@@ -45,7 +45,7 @@ static void do_pagein (const char * filename)
     file_image_close (&image);
 }
 
-int isRotational(char const * path)
+static int isRotational(char const * path)
 {
     int ret = 1;
 #ifdef LINUX
diff --git a/desktop/unx/source/start.c b/desktop/unx/source/start.c
index b32034517318..e3e5441bf97e 100644
--- a/desktop/unx/source/start.c
+++ b/desktop/unx/source/start.c
@@ -567,7 +567,7 @@ static void system_checks(void)
 #endif
 }
 
-void exec_pagein (Args *args)
+static void exec_pagein (Args *args)
 {
     rtl_String * path = ustr_to_str(args->pAppPath);
     pagein_execute(rtl_string_getStr(path), "pagein-common");
@@ -714,7 +714,7 @@ static void exec_javaldx(Args *args)
 // has to be a global :(
 static oslProcess * volatile g_pProcess = NULL;
 
-void sigterm_handler(int ignored)
+static void sigterm_handler(int ignored)
 {
     (void) ignored;