loplugin:stringviewparam check methods too

not just functions

Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 8 insertions, 8 deletions

diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index da8106bcc3e3..ca2d23fff9a6 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -362,7 +362,7 @@ void DialogHelper::openWebBrowser(const OUString& sURL, const OUString& sTitle)
     }
 }
 
-bool DialogHelper::installExtensionWarn(const OUString &rExtensionName)
+bool DialogHelper::installExtensionWarn(std::u16string_view rExtensionName)
 {
     const SolarMutexGuard guard;
 
@@ -535,7 +535,7 @@ void ExtMgrDialog::checkEntries()
     m_xExtensionBox->checkEntries();
 }
 
-bool ExtMgrDialog::removeExtensionWarn(const OUString &rExtensionName)
+bool ExtMgrDialog::removeExtensionWarn(std::u16string_view rExtensionName)
 {
     const SolarMutexGuard guard;
     incBusy();
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.hxx b/desktop/source/deployment/gui/dp_gui_dialog2.hxx
index 09f2a2e42a9f..fe0a953dc213 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.hxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.hxx
@@ -82,7 +82,7 @@ public:
     void            incBusy() { m_aBusy.incBusy(m_pWindow); }
     void            decBusy() { m_aBusy.decBusy(); }
     bool            isBusy() const { return m_aBusy.isBusy(); }
-    bool            installExtensionWarn(const OUString &rExtensionURL);
+    bool            installExtensionWarn(std::u16string_view rExtensionURL);
     bool            installForAllUsers(bool &bInstallForAll);
 };
 
@@ -123,7 +123,7 @@ class ExtMgrDialog : public weld::GenericDialogController
     std::unique_ptr<weld::ProgressBar> m_xProgressBar;
     std::unique_ptr<weld::Button> m_xCancelBtn;
 
-    bool removeExtensionWarn(const OUString &rExtensionTitle);
+    bool removeExtensionWarn(std::u16string_view rExtensionTitle);
 
     DECL_LINK( HandleOptionsBtn, weld::Button&, void );
     DECL_LINK( HandleAddBtn, weld::Button&, void );
diff --git a/desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx b/desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx
index f38a853de71f..bf15f687f0dd 100644
--- a/desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx
+++ b/desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx
@@ -232,7 +232,7 @@ void UpdateInstallDialog::updateDone()
 
 // make sure the solar mutex is locked before calling
 //sets an error message in the text area
-void UpdateInstallDialog::setError(INSTALL_ERROR err, OUString const & sExtension,
+void UpdateInstallDialog::setError(INSTALL_ERROR err, std::u16string_view sExtension,
     OUString const & exceptionMessage)
 {
     OUString sError;
diff --git a/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx b/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx
index 1acfd85508d2..7e970f7b346c 100644
--- a/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx
+++ b/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx
@@ -78,7 +78,7 @@ private:
         ERROR_INSTALLATION,
         ERROR_LICENSE_DECLINED
     };
-    void setError(INSTALL_ERROR err, OUString const & sExtension, OUString const & exceptionMessage);
+    void setError(INSTALL_ERROR err, std::u16string_view sExtension, OUString const & exceptionMessage);
     void setError(OUString const & exceptionMessage);
     const css::uno::Reference< css::deployment::XExtensionManager >& getExtensionManager() const
             { return m_xExtensionManager; }
diff --git a/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx b/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx
index 060d2918fb50..98a957c014e8 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx
@@ -64,7 +64,7 @@ class CommandEnvironmentImpl
 
     /// @throws RuntimeException
     void update_( Any const & Status );
-    void printLicense(const OUString & sName,const OUString& sLicense,
+    void printLicense(std::u16string_view sName,const OUString& sLicense,
                       bool & accept, bool & decline);
 
 public:
@@ -125,7 +125,7 @@ CommandEnvironmentImpl::~CommandEnvironmentImpl()
 
 //May throw exceptions
 void CommandEnvironmentImpl::printLicense(
-    const OUString & sName, const OUString& sLicense, bool & accept, bool &decline)
+    std::u16string_view sName, const OUString& sLicense, bool & accept, bool &decline)
 {
     OUString s1tmp(DpResId(RID_STR_UNOPKG_ACCEPT_LIC_1));
     OUString s1(s1tmp.replaceAll("$NAME", sName));