diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 07:47:33 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 14:34:59 +0200 |
| commit | 32ca870833a89ec16ed7e08296dcc573dcc64029 (patch) | |
| tree | be4eb8d0382db032b7ddfe22df6303fd86ac2c15 /desktop | |
| parent | 509c017f5a6ee6b7c1bb9b61b36aef58a06afd27 (diff) | |
clang-tidy performance-unnecessary-copy-init in dbaccess..drawinglayer
Change-Id: I49a152b2aea93d30b16192260f4f659c7e5fcaee
Reviewed-on: https://gerrit.libreoffice.org/62215
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'desktop')
| -rw-r--r-- | desktop/source/app/app.cxx | 2 | ||||
| -rw-r--r-- | desktop/source/deployment/gui/dp_gui_dialog2.cxx | 2 | ||||
| -rw-r--r-- | desktop/source/deployment/registry/dp_backend.cxx | 2 | ||||
| -rw-r--r-- | desktop/source/lib/init.cxx | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx index ba244fd8c268..0cc6c649e7e1 100644 --- a/desktop/source/app/app.cxx +++ b/desktop/source/app/app.cxx @@ -1257,7 +1257,7 @@ int Desktop::Main() CommandLineArgs& rCmdLineArgs = GetCommandLineArgs(); #if HAVE_FEATURE_DESKTOP - OUString aUnknown( rCmdLineArgs.GetUnknown() ); + const OUString& aUnknown( rCmdLineArgs.GetUnknown() ); if ( !aUnknown.isEmpty() ) { displayCmdlineHelp( aUnknown ); diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx index c31088a88a8f..b36f18d8f5dc 100644 --- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx +++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx @@ -674,7 +674,7 @@ bool ExtMgrDialog::acceptLicense( const uno::Reference< deployment::XPackage > & uno::Sequence< OUString > ExtMgrDialog::raiseAddPicker() { sfx2::FileDialogHelper aDlgHelper(ui::dialogs::TemplateDescription::FILEOPEN_SIMPLE, FileDialogFlags::NONE, GetFrameWeld()); - const uno::Reference<ui::dialogs::XFilePicker3> xFilePicker = aDlgHelper.GetFilePicker(); + const uno::Reference<ui::dialogs::XFilePicker3>& xFilePicker = aDlgHelper.GetFilePicker(); xFilePicker->setTitle( m_sAddPackages ); if ( !m_sLastFolderURL.isEmpty() ) diff --git a/desktop/source/deployment/registry/dp_backend.cxx b/desktop/source/deployment/registry/dp_backend.cxx index f6108abab34c..58049f46e9b9 100644 --- a/desktop/source/deployment/registry/dp_backend.cxx +++ b/desktop/source/deployment/registry/dp_backend.cxx @@ -218,7 +218,7 @@ OUString PackageRegistryBackend::createFolder( const OUString baseDir(sDataFolder); ::utl::TempFile aTemp(&baseDir, true); - const OUString url = aTemp.GetURL(); + const OUString& url = aTemp.GetURL(); return sDataFolder + url.copy(url.lastIndexOf('/')); } diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 6f080c5e0316..85b188b15e84 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2888,7 +2888,7 @@ static char* getFontSubset (const OString& aFontName) { FontCharMapRef xFontCharMap (new FontCharMap()); auto aDevice(VclPtr<VirtualDevice>::Create(nullptr, Size(1, 1), DeviceFormat::DEFAULT)); - vcl::Font aFont(pList->GetFontName(nItFont)); + const vcl::Font& aFont(pList->GetFontName(nItFont)); aDevice->SetFont(aFont); aDevice->GetFontCharMap(xFontCharMap); |