loplugin:unusedvarsglobal

tackle some read-only vars.
Mark some of them const to make it obvious they are not really used, and
to make the constantparam plugin see more data.

Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 4 insertions, 5 deletions

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 30116199123c..78f152166acd 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -720,22 +720,21 @@ std::string extractPrivateKey(const std::string & privateKey)
 
 OUString lcl_getCurrentDocumentMimeType(LibLODocument_Impl* pDocument)
 {
-    OUString aMimeType;
     SfxBaseModel* pBaseModel = dynamic_cast<SfxBaseModel*>(pDocument->mxComponent.get());
     if (!pBaseModel)
-        return aMimeType;
+        return "";
 
     SfxObjectShell* pObjectShell = pBaseModel->GetObjectShell();
     if (!pObjectShell)
-        return aMimeType;
+        return "";
 
     SfxMedium* pMedium = pObjectShell->GetMedium();
     if (!pMedium)
-        return aMimeType;
+        return "";
 
     auto pFilter = pMedium->GetFilter();
     if (!pFilter)
-        return aMimeType;
+        return "";
 
     return pFilter->GetMimeType();
 }