diff options
author | Noel <noel.grandin@collabora.co.uk> | 2021-01-28 20:29:16 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-01-29 09:25:12 +0100 |
commit | 1250aecd71fabde4dba990bfceb61bbe8e06b8ea (patch) | |
tree | 3c42ffdf68b7e81aba29228631a8cd34e2f11830 /desktop | |
parent | 4f3987e0b1a995431478769c898b5ef151745254 (diff) |
loplugin:stringviewparam extend to new..
O[U]StringBuffer methods
Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'desktop')
-rw-r--r-- | desktop/source/app/dispatchwatcher.cxx | 2 | ||||
-rw-r--r-- | desktop/source/deployment/gui/dp_gui_updatedialog.cxx | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/desktop/source/app/dispatchwatcher.cxx b/desktop/source/app/dispatchwatcher.cxx index 9ab77f399ec4..bde83bcd22d4 100644 --- a/desktop/source/app/dispatchwatcher.cxx +++ b/desktop/source/app/dispatchwatcher.cxx @@ -90,7 +90,7 @@ struct DispatchHolder Reference< XDispatch > xDispatch; }; -std::shared_ptr<const SfxFilter> impl_lookupExportFilterForUrl( std::u16string_view rUrl, const OUString& rFactory ) +std::shared_ptr<const SfxFilter> impl_lookupExportFilterForUrl( std::u16string_view rUrl, std::u16string_view rFactory ) { // create the list of filters OUStringBuffer sQuery(256); diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx index bea08615c459..42f63aa2e772 100644 --- a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx +++ b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx @@ -161,7 +161,7 @@ private: uno::Any const & exception) const; OUString getUpdateDisplayString( - dp_gui::UpdateData const & data, OUString const & version = OUString()) const; + dp_gui::UpdateData const & data, std::u16string_view version = std::u16string_view()) const; void prepareUpdateData( css::uno::Reference< css::xml::dom::XNode > const & updateInfo, @@ -332,7 +332,7 @@ void UpdateDialog::Thread::handleSpecificError( } OUString UpdateDialog::Thread::getUpdateDisplayString( - dp_gui::UpdateData const & data, OUString const & version) const + dp_gui::UpdateData const & data, std::u16string_view version) const { OSL_ASSERT(data.aInstalledPackage.is()); OUStringBuffer b(data.aInstalledPackage->getDisplayName()); @@ -343,7 +343,7 @@ OUString UpdateDialog::Thread::getUpdateDisplayString( b.append(m_dialog.m_version); } b.append(' '); - if (!version.isEmpty()) + if (!version.empty()) b.append(version); else b.append(data.updateVersion); |