summaryrefslogtreecommitdiff
path: root/desktop
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2015-06-24 17:35:37 +0100
committerCaolán McNamara <caolanm@redhat.com>2015-06-24 20:03:22 +0100
commitdf5ec49bcaa57aa0a137db45d7c0766733f7e508 (patch)
treea534ec9f3f73978e0cd18d47e17b1aa3671d52f3 /desktop
parent73d9cc8cb849e9dc51b0e363fc46d965bbcae250 (diff)
cppcheck: noExplicitConstructor
Change-Id: I80cd2975f17bb7fa57fa669873ef1dd8f3595a11
Diffstat (limited to 'desktop')
-rw-r--r--desktop/source/app/cmdlineargs.hxx2
-rw-r--r--desktop/source/app/desktopresid.hxx2
-rw-r--r--desktop/source/deployment/gui/dp_gui.h2
-rw-r--r--desktop/source/deployment/gui/dp_gui_dialog2.cxx4
-rw-r--r--desktop/source/deployment/gui/dp_gui_extlistbox.cxx2
-rw-r--r--desktop/source/deployment/gui/dp_gui_extlistbox.hxx6
-rw-r--r--desktop/source/deployment/gui/dp_gui_shared.hxx2
-rw-r--r--desktop/source/deployment/gui/dp_gui_updatedata.hxx2
-rw-r--r--desktop/source/deployment/gui/dp_gui_updatedialog.hxx2
-rw-r--r--desktop/source/deployment/manager/dp_commandenvironments.hxx6
-rw-r--r--desktop/source/deployment/manager/dp_extensionmanager.hxx2
-rw-r--r--desktop/source/deployment/manager/dp_informationprovider.cxx2
-rw-r--r--desktop/source/deployment/manager/dp_manager.cxx2
-rw-r--r--desktop/source/deployment/manager/dp_managerfac.cxx2
-rw-r--r--desktop/source/deployment/misc/dp_descriptioninfoset.cxx2
-rw-r--r--desktop/source/lib/init.cxx2
-rw-r--r--desktop/source/migration/services/oo3extensionmigration.hxx2
-rw-r--r--desktop/source/offacc/acceptor.hxx2
-rw-r--r--desktop/source/pkgchk/unopkg/unopkg_app.cxx4
-rw-r--r--desktop/source/pkgchk/unopkg/unopkg_shared.h2
-rw-r--r--desktop/source/splash/splash.cxx2
-rw-r--r--desktop/source/splash/unxsplash.hxx2
-rw-r--r--desktop/test/deployment/active/active_native.cxx4
-rw-r--r--desktop/test/deployment/passive/passive_native.cxx4
24 files changed, 32 insertions, 32 deletions
diff --git a/desktop/source/app/cmdlineargs.hxx b/desktop/source/app/cmdlineargs.hxx
index 7b8c0da62dff..fe8ea8b6fbaa 100644
--- a/desktop/source/app/cmdlineargs.hxx
+++ b/desktop/source/app/cmdlineargs.hxx
@@ -51,7 +51,7 @@ class CommandLineArgs: private boost::noncopyable
};
CommandLineArgs();
- CommandLineArgs( Supplier& supplier );
+ explicit CommandLineArgs( Supplier& supplier );
boost::optional< OUString > getCwdUrl() const { return m_cwdUrl; }
diff --git a/desktop/source/app/desktopresid.hxx b/desktop/source/app/desktopresid.hxx
index d07df7e88906..43114219f626 100644
--- a/desktop/source/app/desktopresid.hxx
+++ b/desktop/source/app/desktopresid.hxx
@@ -28,7 +28,7 @@ namespace desktop
class DesktopResId : public ResId
{
public:
- DesktopResId( sal_uInt16 nId );
+ explicit DesktopResId( sal_uInt16 nId );
};
}
diff --git a/desktop/source/deployment/gui/dp_gui.h b/desktop/source/deployment/gui/dp_gui.h
index 0de1148b66f0..b99099f91f2b 100644
--- a/desktop/source/deployment/gui/dp_gui.h
+++ b/desktop/source/deployment/gui/dp_gui.h
@@ -68,7 +68,7 @@ enum PackageState { REGISTERED, NOT_REGISTERED, AMBIGUOUS, NOT_AVAILABLE };
class SelectedPackage: public salhelper::SimpleReferenceObject {
public:
SelectedPackage() {}
- SelectedPackage( const ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage> &xPackage)
+ explicit SelectedPackage( const ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage> &xPackage)
: m_xPackage( xPackage )
{}
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index 2bea724819c0..86adb0289ff2 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -136,8 +136,8 @@ class ExtBoxWithBtns_Impl : public ExtensionBox_Impl
DECL_DLLPRIVATE_LINK( HandleRemoveBtn, void * );
public:
- ExtBoxWithBtns_Impl(vcl::Window* pParent);
- virtual ~ExtBoxWithBtns_Impl();
+ explicit ExtBoxWithBtns_Impl(vcl::Window* pParent);
+ virtual ~ExtBoxWithBtns_Impl();
virtual void dispose() SAL_OVERRIDE;
void InitFromDialog(ExtMgrDialog *pParentDialog);
diff --git a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx
index 35b62467d148..3ff477c7afbb 100644
--- a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx
+++ b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx
@@ -47,7 +47,7 @@ struct FindWeakRef
{
const uno::Reference<deployment::XPackage> m_extension;
- FindWeakRef( uno::Reference<deployment::XPackage> const & ext): m_extension(ext) {}
+ explicit FindWeakRef( uno::Reference<deployment::XPackage> const & ext): m_extension(ext) {}
bool operator () (uno::WeakReference< deployment::XPackage > const & ref);
};
diff --git a/desktop/source/deployment/gui/dp_gui_extlistbox.hxx b/desktop/source/deployment/gui/dp_gui_extlistbox.hxx
index 6a027c48ba12..0d5ca8f6e4cd 100644
--- a/desktop/source/deployment/gui/dp_gui_extlistbox.hxx
+++ b/desktop/source/deployment/gui/dp_gui_extlistbox.hxx
@@ -96,8 +96,8 @@ class ExtensionRemovedListener : public ::cppu::WeakImplHelper1<css::lang::XEven
public:
- ExtensionRemovedListener( ExtensionBox_Impl *pParent ) { m_pParent = pParent; }
- virtual ~ExtensionRemovedListener();
+ explicit ExtensionRemovedListener( ExtensionBox_Impl *pParent ) { m_pParent = pParent; }
+ virtual ~ExtensionRemovedListener();
// XEventListener
@@ -173,7 +173,7 @@ class ExtensionBox_Impl : public ::svt::IExtensionListBox
void Init();
public:
- ExtensionBox_Impl(vcl::Window* pParent);
+ explicit ExtensionBox_Impl(vcl::Window* pParent);
virtual ~ExtensionBox_Impl();
virtual void dispose() SAL_OVERRIDE;
diff --git a/desktop/source/deployment/gui/dp_gui_shared.hxx b/desktop/source/deployment/gui/dp_gui_shared.hxx
index 8d926c841ba1..bd175cb3bfa5 100644
--- a/desktop/source/deployment/gui/dp_gui_shared.hxx
+++ b/desktop/source/deployment/gui/dp_gui_shared.hxx
@@ -36,7 +36,7 @@ struct DeploymentGuiResMgr :
class DpGuiResId : public ResId
{
public:
- DpGuiResId( sal_uInt16 nId ):ResId( nId, *DeploymentGuiResMgr::get() ) {}
+ explicit DpGuiResId( sal_uInt16 nId ):ResId( nId, *DeploymentGuiResMgr::get() ) {}
};
#define DPGUI_RESSTR(i) DpGuiResId(i).toString()
diff --git a/desktop/source/deployment/gui/dp_gui_updatedata.hxx b/desktop/source/deployment/gui/dp_gui_updatedata.hxx
index c8ae7ab47d8e..ac12cc0eebc1 100644
--- a/desktop/source/deployment/gui/dp_gui_updatedata.hxx
+++ b/desktop/source/deployment/gui/dp_gui_updatedata.hxx
@@ -38,7 +38,7 @@ namespace dp_gui {
struct UpdateData
{
- UpdateData( ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage > const & aExt):
+ explicit UpdateData( ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage > const & aExt):
bIsShared(false), aInstalledPackage(aExt), aUpdateSource(NULL), m_nID(0), m_bIgnored(false){};
//When entries added to the listbox then there can be one for the user update and one
diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.hxx b/desktop/source/deployment/gui/dp_gui_updatedialog.hxx
index 18fa9de6ebde..76851b4301c1 100644
--- a/desktop/source/deployment/gui/dp_gui_updatedialog.hxx
+++ b/desktop/source/deployment/gui/dp_gui_updatedialog.hxx
@@ -115,7 +115,7 @@ private:
sal_uInt16 getItemCount() const;
private:
- CheckListBox(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION;
+ explicit CheckListBox(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION;
void operator =(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION;
virtual void MouseButtonDown(MouseEvent const & event) SAL_OVERRIDE;
diff --git a/desktop/source/deployment/manager/dp_commandenvironments.hxx b/desktop/source/deployment/manager/dp_commandenvironments.hxx
index d51d161591ed..b45c28ddd10b 100644
--- a/desktop/source/deployment/manager/dp_commandenvironments.hxx
+++ b/desktop/source/deployment/manager/dp_commandenvironments.hxx
@@ -44,7 +44,7 @@ protected:
public:
virtual ~BaseCommandEnv();
BaseCommandEnv();
- BaseCommandEnv(
+ explicit BaseCommandEnv(
css::uno::Reference< css::task::XInteractionHandler> const & handler);
// XCommandEnvironment
@@ -70,7 +70,7 @@ class TmpRepositoryCommandEnv : public BaseCommandEnv
{
public:
TmpRepositoryCommandEnv();
- TmpRepositoryCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
+ explicit TmpRepositoryCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
// XInteractionHandler
virtual void SAL_CALL handle(
@@ -111,7 +111,7 @@ class NoLicenseCommandEnv : public BaseCommandEnv
public:
NoLicenseCommandEnv(){};
- NoLicenseCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
+ explicit NoLicenseCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler);
// XInteractionHandler
virtual void SAL_CALL handle(
diff --git a/desktop/source/deployment/manager/dp_extensionmanager.hxx b/desktop/source/deployment/manager/dp_extensionmanager.hxx
index 47a3e963292c..1c2cea9147bb 100644
--- a/desktop/source/deployment/manager/dp_extensionmanager.hxx
+++ b/desktop/source/deployment/manager/dp_extensionmanager.hxx
@@ -44,7 +44,7 @@ class ExtensionManager : private ::dp_misc::MutexHolder,
public ::cppu::WeakComponentImplHelper1< css::deployment::XExtensionManager >
{
public:
- ExtensionManager( css::uno::Reference< css::uno::XComponentContext >const& xContext);
+ explicit ExtensionManager( css::uno::Reference< css::uno::XComponentContext >const& xContext);
virtual ~ExtensionManager();
static css::uno::Sequence< OUString > getServiceNames();
diff --git a/desktop/source/deployment/manager/dp_informationprovider.cxx b/desktop/source/deployment/manager/dp_informationprovider.cxx
index be263726fb03..b550f091482d 100644
--- a/desktop/source/deployment/manager/dp_informationprovider.cxx
+++ b/desktop/source/deployment/manager/dp_informationprovider.cxx
@@ -63,7 +63,7 @@ class PackageInformationProvider :
{
public:
- PackageInformationProvider( uno::Reference< uno::XComponentContext >const& xContext);
+ explicit PackageInformationProvider( uno::Reference< uno::XComponentContext >const& xContext);
virtual ~PackageInformationProvider();
// XPackageInformationProvider
diff --git a/desktop/source/deployment/manager/dp_manager.cxx b/desktop/source/deployment/manager/dp_manager.cxx
index 0610d0e35bf4..c7a44295d34b 100644
--- a/desktop/source/deployment/manager/dp_manager.cxx
+++ b/desktop/source/deployment/manager/dp_manager.cxx
@@ -78,7 +78,7 @@ namespace dp_manager {
struct MatchTempDir
{
OUString m_str;
- MatchTempDir( OUString const & str ) : m_str( str ) {}
+ explicit MatchTempDir( OUString const & str ) : m_str( str ) {}
bool operator () ( ActivePackages::Entries::value_type const & v ) const {
return v.second.temporaryName.equalsIgnoreAsciiCase( m_str );
}
diff --git a/desktop/source/deployment/manager/dp_managerfac.cxx b/desktop/source/deployment/manager/dp_managerfac.cxx
index 49238f948209..06a5acd4227b 100644
--- a/desktop/source/deployment/manager/dp_managerfac.cxx
+++ b/desktop/source/deployment/manager/dp_managerfac.cxx
@@ -56,7 +56,7 @@ protected:
public:
virtual ~PackageManagerFactoryImpl();
- PackageManagerFactoryImpl(
+ explicit PackageManagerFactoryImpl(
Reference<XComponentContext> const & xComponentContext );
// XPackageManagerFactory
diff --git a/desktop/source/deployment/misc/dp_descriptioninfoset.cxx b/desktop/source/deployment/misc/dp_descriptioninfoset.cxx
index 292d0bfd724d..dab93e30f576 100644
--- a/desktop/source/deployment/misc/dp_descriptioninfoset.cxx
+++ b/desktop/source/deployment/misc/dp_descriptioninfoset.cxx
@@ -148,7 +148,7 @@ class FileDoesNotExistFilter
public:
virtual ~FileDoesNotExistFilter();
- FileDoesNotExistFilter(
+ explicit FileDoesNotExistFilter(
const css::uno::Reference< css::ucb::XCommandEnvironment >& xCmdEnv);
bool exist() { return m_bExist;}
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index c043e04a22a0..ee47cd864774 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -229,7 +229,7 @@ struct LibLODocument_Impl : public _LibreOfficeKitDocument
uno::Reference<css::lang::XComponent> mxComponent;
shared_ptr< LibreOfficeKitDocumentClass > m_pDocumentClass;
- LibLODocument_Impl(const uno::Reference <css::lang::XComponent> &xComponent) :
+ explicit LibLODocument_Impl(const uno::Reference <css::lang::XComponent> &xComponent) :
mxComponent( xComponent )
{
if (!(m_pDocumentClass = gDocumentClass.lock()))
diff --git a/desktop/source/migration/services/oo3extensionmigration.hxx b/desktop/source/migration/services/oo3extensionmigration.hxx
index 33b080946b9d..ad04d8318ddd 100644
--- a/desktop/source/migration/services/oo3extensionmigration.hxx
+++ b/desktop/source/migration/services/oo3extensionmigration.hxx
@@ -87,7 +87,7 @@ namespace migration
void migrateExtension( const OUString& sSourceDir );
public:
- OO3ExtensionMigration(::com::sun::star::uno::Reference<
+ explicit OO3ExtensionMigration(::com::sun::star::uno::Reference<
::com::sun::star::uno::XComponentContext > const & ctx);
virtual ~OO3ExtensionMigration();
diff --git a/desktop/source/offacc/acceptor.hxx b/desktop/source/offacc/acceptor.hxx
index a7c35ae761fe..2881bf9df05f 100644
--- a/desktop/source/offacc/acceptor.hxx
+++ b/desktop/source/offacc/acceptor.hxx
@@ -71,7 +71,7 @@ private:
bool m_bDying;
public:
- Acceptor( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
+ explicit Acceptor( const css::uno::Reference< css::uno::XComponentContext >& rxContext );
virtual ~Acceptor();
void run();
diff --git a/desktop/source/pkgchk/unopkg/unopkg_app.cxx b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
index dc79adce6534..cb37894d7a07 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
@@ -56,7 +56,7 @@ namespace {
struct ExtensionName
{
OUString m_str;
- ExtensionName( OUString const & str ) : m_str( str ) {}
+ explicit ExtensionName( OUString const & str ) : m_str( str ) {}
bool operator () ( Reference<deployment::XPackage> const & e ) const
{
if (m_str.equals(dp_misc::getIdentifier(e))
@@ -127,7 +127,7 @@ class DialogClosedListenerImpl :
osl::Condition & m_rDialogClosedCondition;
public:
- DialogClosedListenerImpl( osl::Condition & rDialogClosedCondition )
+ explicit DialogClosedListenerImpl( osl::Condition & rDialogClosedCondition )
: m_rDialogClosedCondition( rDialogClosedCondition ) {}
// XEventListener (base of XDialogClosedListener)
diff --git a/desktop/source/pkgchk/unopkg/unopkg_shared.h b/desktop/source/pkgchk/unopkg/unopkg_shared.h
index 26a047aada96..5c25fbccade4 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_shared.h
+++ b/desktop/source/pkgchk/unopkg/unopkg_shared.h
@@ -49,7 +49,7 @@ struct OptionInfo
struct LockFileException : public css::uno::Exception
{
- LockFileException(OUString const & sMessage) :
+ explicit LockFileException(OUString const & sMessage) :
css::uno::Exception(sMessage, css::uno::Reference< css::uno::XInterface > ()) {}
};
diff --git a/desktop/source/splash/splash.cxx b/desktop/source/splash/splash.cxx
index b00c632ff1b2..8de8c298ce56 100644
--- a/desktop/source/splash/splash.cxx
+++ b/desktop/source/splash/splash.cxx
@@ -54,7 +54,7 @@ class SplashScreenWindow : public IntroWindow
public:
SplashScreen *pSpl;
ScopedVclPtr<VirtualDevice> _vdev;
- SplashScreenWindow(SplashScreen *);
+ explicit SplashScreenWindow(SplashScreen *);
virtual ~SplashScreenWindow() { disposeOnce(); }
virtual void dispose() SAL_OVERRIDE;
// workwindow
diff --git a/desktop/source/splash/unxsplash.hxx b/desktop/source/splash/unxsplash.hxx
index 901e3278b798..e7123344efe4 100644
--- a/desktop/source/splash/unxsplash.hxx
+++ b/desktop/source/splash/unxsplash.hxx
@@ -48,7 +48,7 @@ private:
FILE *m_pOutFd;
public:
- UnxSplashScreen( const css::uno::Reference< css::uno::XComponentContext >& xCtx );
+ explicit UnxSplashScreen( const css::uno::Reference< css::uno::XComponentContext >& xCtx );
// XStatusIndicator
virtual void SAL_CALL start( const OUString& aText, sal_Int32 nRange ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE;
diff --git a/desktop/test/deployment/active/active_native.cxx b/desktop/test/deployment/active/active_native.cxx
index c88e19184da3..06da72a3b274 100644
--- a/desktop/test/deployment/active/active_native.cxx
+++ b/desktop/test/deployment/active/active_native.cxx
@@ -74,7 +74,7 @@ public:
static_getSupportedServiceNames();
private:
- Provider(
+ explicit Provider(
css::uno::Reference< css::uno::XComponentContext > const & context):
context_(context) { assert(context.is()); }
@@ -166,7 +166,7 @@ public:
{ return css::uno::Sequence< rtl::OUString >(); }
private:
- Dispatch(
+ explicit Dispatch(
css::uno::Reference< css::uno::XComponentContext > const & context):
context_(context) { assert(context.is()); }
diff --git a/desktop/test/deployment/passive/passive_native.cxx b/desktop/test/deployment/passive/passive_native.cxx
index b7325f629057..70b11ccebc03 100644
--- a/desktop/test/deployment/passive/passive_native.cxx
+++ b/desktop/test/deployment/passive/passive_native.cxx
@@ -71,7 +71,7 @@ public:
static_getSupportedServiceNames();
private:
- Provider(
+ explicit Provider(
css::uno::Reference< css::uno::XComponentContext > const & context):
context_(context) { assert(context.is()); }
@@ -163,7 +163,7 @@ public:
{ return css::uno::Sequence< rtl::OUString >(); }
private:
- Dispatch(
+ explicit Dispatch(
css::uno::Reference< css::uno::XComponentContext > const & context):
context_(context) { assert(context.is()); }