summaryrefslogtreecommitdiff
path: root/desktop
diff options
context:
space:
mode:
authorGiuseppe Bilotta <giuseppe.bilotta@gmail.com>2016-04-22 10:09:40 +0200
committerMarkus Mohrhard <markus.mohrhard@googlemail.com>2016-05-07 22:33:28 +0000
commit1ca277fad69d8a53788a5d457a2dd99bd50b6910 (patch)
tree2e8a0c8569c9dd3e976b19f24d7d0a883f98500a /desktop
parentc327bb5c88573c96f22e9a8cfc4b8a733ae6b671 (diff)
tdf#84394: xls load: delay cell-anchoring of object groups
When cell-anchored object groups are loaded, their anchoring must be delayed until all nested objects have been loaded, lest the invalid rectangle dimensions lead to incorrect positioning of the object. To achieve this, we keep track of the DffObjectData of the pending group, and move the anchoring to a FinalizeObj() method. Since DffObjectData has a const reference to a DffRecordHeader (which we need when setting the object anchoring) whose scope has closed by the time we call FinalizeObj() on the parent object, the stack of pending DffObjectData has references to clones of the original DffRecordHeader held in shared pointers. (This is to minimize the invasiveness of this patch wrt the Import* API.) Change-Id: Id23f5549dbc82306271cc02afc750f37eeea3ca2 Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/24292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Diffstat (limited to 'desktop')
0 files changed, 0 insertions, 0 deletions