summaryrefslogtreecommitdiff
path: root/download.lst
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2016-12-14 20:09:14 +0300
committerTor Lillqvist <tml@collabora.com>2016-12-14 19:03:56 +0000
commit5ecd7ebbdf752eac48442006137d62426bf63c84 (patch)
tree37fbe3acbaeccccaf76fc9b7cd0edf99f32b2df0 /download.lst
parentd50c9221a50160ae38aa72ad87a1ad70a16b6b4c (diff)
Partially fix VBATest::testMiscOLEStuff for Win64
On Windows x64 there are two ODBCs - one for each bitness. A 64-bit build gets 64-bit ODBC, and there is no provider named "Microsoft Excel Driver (*.xls)", no normally the test is simply skipped. But if MS Excel is installed, then it installs provider "Microsoft Excel Driver (*.xls, *.xlsx, *.xlsm, *.xlsb)", that was detected by previous code, but not used inside the VBAs. So, VBAs tried to use "Microsoft Excel Driver (*.xls)" unavailable to them. This patch allows using Excel's provider as well, thus allowing developer to test against 64-bit-specific regressions. However, the last test uses Microsoft.Jet.OLEDB.4.0 provider, that is unavailable on Win64. There are substitutions - Microsoft.ACE.OLEDB.12.0 and Microsoft.ACE.OLEDB.15.0, but there is no easy way to test if they are installed. Thus, that test is disabled on Win64 for now. Also, possible buffer overflow fixed, when byte count was passed to SQLGetInstalledDriversW instead of char count. Change-Id: Ib5c55251f0e92b3078a46aee173b5061439445ae Reviewed-on: https://gerrit.libreoffice.org/32019 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
Diffstat (limited to 'download.lst')
0 files changed, 0 insertions, 0 deletions