tdf#69977: uno::Sequence is expensive

when used as a mutable data-structure. Plain std::vector halves the time
taken to display the chart dialog

Create a class to represent the std::vector we are going to be passing
around, and move some of the utility methods into it to make the code
prettier.
Also create an optimised append(&&) method for the common case of
appending small temporaries.

Change-Id: I7f5b43fb4a8a84e40e6a52fcb7e9f974091b4485

1 files changed, 4 insertions, 4 deletions

diff --git a/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx b/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx
index b845602c4fb9..0f663a4345f2 100644
--- a/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx
@@ -163,9 +163,9 @@ namespace drawinglayer
 {
     namespace primitive2d
     {
-        Primitive2DSequence DiscreteShadowPrimitive2D::create2DDecomposition(const geometry::ViewInformation2D& /*rViewInformation*/) const
+        Primitive2DContainer DiscreteShadowPrimitive2D::create2DDecomposition(const geometry::ViewInformation2D& /*rViewInformation*/) const
         {
-            Primitive2DSequence xRetval;
+            Primitive2DContainer xRetval;
 
             if(!getDiscreteShadow().getBitmapEx().IsEmpty())
             {
@@ -178,7 +178,7 @@ namespace drawinglayer
                 const double fBigLenX((fBorderX * 2.0) + fSingleX);
                 const double fBigLenY((fBorderY * 2.0) + fSingleY);
 
-                xRetval.realloc(8);
+                xRetval.resize(8);
 
                 // TopLeft
                 xRetval[0] = Primitive2DReference(
@@ -266,7 +266,7 @@ namespace drawinglayer
                         getTransform(),
                         xRetval));
 
-                xRetval = Primitive2DSequence(&xTransformed, 1);
+                xRetval = Primitive2DContainer { xTransformed };
             }
 
             return xRetval;