diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-03-08 10:47:12 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-03-08 10:44:29 +0100 |
| commit | b8fe96f1da2c42c04a8094ca8c57d49763b7bded (patch) | |
| tree | d2b1852c89f1776ef8ee25bbb99c6bd74a1ae984 /drawinglayer/source | |
| parent | 7960ccb41db49a7883afa036b820a7b7ffcb4a89 (diff) | |
loplugin:constantparam in desktop..i18npool
Change-Id: Ie2e1004c1ccc03777a8da9cb1144e89eb28ff313
Reviewed-on: https://gerrit.libreoffice.org/50928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'drawinglayer/source')
| -rw-r--r-- | drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx | 21 |
1 files changed, 7 insertions, 14 deletions
diff --git a/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx b/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx index 612dd4254802..9876cac985fb 100644 --- a/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx +++ b/drawinglayer/source/primitive3d/sdrextrudelathetools3d.cxx @@ -204,8 +204,7 @@ namespace void impCreateInBetweenNormals( basegfx::B3DPolyPolygon& rPolA, - basegfx::B3DPolyPolygon& rPolB, - bool bSmoothHorizontalNormals) + basegfx::B3DPolyPolygon& rPolB) { OSL_ENSURE(rPolA.count() == rPolB.count(), "sdrExtrudePrimitive3D: unequally sized polygons (!)"); const sal_uInt32 nPolygonCount(std::min(rPolA.count(), rPolB.count())); @@ -249,7 +248,7 @@ namespace // create left normal const basegfx::B3DVector aNormalLeft(aDepth.getPerpendicular(aLeft)); - if(bSmoothHorizontalNormals) + // smooth horizontal normals { // vector to right (correct for non-closed lines) const bool bLastAndNotClosed(!bClosed && b + 1 == nPointCount); @@ -267,12 +266,6 @@ namespace aSubA.setNormal(b, aNewNormal); aSubB.setNormal(b, aNewNormal); } - else - { - // set aNormalLeft as new normal at polygons - aSubA.setNormal(b, aNormalLeft); - aSubB.setNormal(b, aNormalLeft); - } // prepare next step aPrevA = aCurrA; @@ -646,7 +639,7 @@ namespace drawinglayer { if(bCreateNormals) { - impCreateInBetweenNormals(aPolB, aPolA, true/*bSmoothHorizontalNormals*/); + impCreateInBetweenNormals(aPolB, aPolA); } { @@ -678,7 +671,7 @@ namespace drawinglayer if(bHasSlant) { - impCreateInBetweenNormals(aPolAA, aPrev, true/*bSmoothHorizontalNormals*/); + impCreateInBetweenNormals(aPolAA, aPrev); if(bSmoothNormals) { @@ -741,7 +734,7 @@ namespace drawinglayer { if(bCreateNormals && bSmoothNormals && (nIndPrev != a + 1)) { - impCreateInBetweenNormals(aPolAA, aPrev, true/*bSmoothHorizontalNormals*/); + impCreateInBetweenNormals(aPolAA, aPrev); impMixNormals(aPolA, aPolAA, 0.5); } } @@ -770,7 +763,7 @@ namespace drawinglayer if(bHasSlant) { - impCreateInBetweenNormals(aNext, aPolBB, true/*bSmoothHorizontalNormals*/); + impCreateInBetweenNormals(aNext, aPolBB); if(bSmoothNormals) { @@ -832,7 +825,7 @@ namespace drawinglayer { if(bCreateNormals && bSmoothNormals && (nIndNext != a)) { - impCreateInBetweenNormals(aNext, aPolBB, true/*bSmoothHorizontalNormals*/); + impCreateInBetweenNormals(aNext, aPolBB); impMixNormals(aPolB, aPolBB, 0.5); } } |