diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2018-09-24 15:41:53 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2018-09-24 17:22:05 +0200 |
commit | 928b1b04adc1cd49cc5d00069084e03675a320f3 (patch) | |
tree | 8710687a4a66a628bd12c5482d7d93cc27f8996a /dtrans/source/win32/dnd/dndentry.cxx | |
parent | ec709a8d5e808b970a8930a389c0a5a6f61fe8c7 (diff) |
loplugin:external (clang-cl)
Including:
* expanding STDAPI to its definition (as per
<https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add
__declspec(dllexport) into its middle, in
extensions/source/activex/so_activex.cxx; as discussed in the comments at
<https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in
setup_native, use __declspec(dllexport)", having a function both listed in a
.def file EXPORTS and marking it dllexport is OK, and the latter helps the
heuristics of loplugin:external; however, the relevant functions in
extensions/source/activex/so_activex.cxx probably don't even need to be
exported in the first place?
* follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx
Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191
Reviewed-on: https://gerrit.libreoffice.org/60938
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'dtrans/source/win32/dnd/dndentry.cxx')
-rw-r--r-- | dtrans/source/win32/dnd/dndentry.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/dtrans/source/win32/dnd/dndentry.cxx b/dtrans/source/win32/dnd/dndentry.cxx index 9a06cbc6f3b9..58ec08f45858 100644 --- a/dtrans/source/win32/dnd/dndentry.cxx +++ b/dtrans/source/win32/dnd/dndentry.cxx @@ -30,13 +30,13 @@ using namespace ::com::sun::star::registry ; using namespace ::cppu ; using namespace ::com::sun::star::lang; -Reference< XInterface > createDragSource( const Reference< XMultiServiceFactory >& rServiceManager ) +static Reference< XInterface > createDragSource( const Reference< XMultiServiceFactory >& rServiceManager ) { DragSource* pSource= new DragSource( comphelper::getComponentContext(rServiceManager) ); return Reference<XInterface>( static_cast<XInitialization*>(pSource), UNO_QUERY); } -Reference< XInterface > createDropTarget( const Reference< XMultiServiceFactory >& rServiceManager ) +static Reference< XInterface > createDropTarget( const Reference< XMultiServiceFactory >& rServiceManager ) { DropTarget* pTarget= new DropTarget( comphelper::getComponentContext(rServiceManager) ); return Reference<XInterface>( static_cast<XInitialization*>(pTarget), UNO_QUERY); |