diff options
author | Michael Stahl <michael.stahl@allotropia.de> | 2023-02-10 15:18:46 +0100 |
---|---|---|
committer | Michael Stahl <michael.stahl@allotropia.de> | 2023-02-24 07:32:10 +0000 |
commit | 7e7b69829db63e64b8aed8d03c6eaed6d8f1a27c (patch) | |
tree | 8e43564f5a951cfc41616341eed6eaf7626e6ca5 /editeng/CppunitTest_editeng_borderline.mk | |
parent | afdee56418182b7250eb61269dd26cbacc56f87f (diff) |
editeng: split SvxLRSpaceItem into 1 class per attribute
The tricky part is that there are actually 2 different kinds of left
margins:
Those on entities that aren't paragraphs are simple, so class
SvxLeftMarginItem is simple.
Those on paragraphs are entangled with the first-line-offset,
because there is a left margin value (same as for everything else)
and a text-left-margin value, which includes a negative
first-line-offset; the text-left-margin value is exported as API
property so stored as-is in the item, and the left-margin is computed on
demand (based on corresponding first-line-offset) in
SvxTextLeftMarginItem::GetLeft().
Separate classes for these is a better separation than what commit
a0875d09d9eeb368e9e319f3f2f29ec3be71b56c did.
(some functions aren't implemented because the SvxLRSpaceItem did
nothing for these cases; not sure if that's intended.)
Change-Id: Iae5cd4bf8167754eec65d2585430f5fe3d00839f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147023
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Diffstat (limited to 'editeng/CppunitTest_editeng_borderline.mk')
0 files changed, 0 insertions, 0 deletions