pvs-studio: V794 The assignment operator should be protected

Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669
Reviewed-on: https://gerrit.libreoffice.org/62166
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

2 files changed, 24 insertions, 21 deletions

diff --git a/editeng/source/items/frmitems.cxx b/editeng/source/items/frmitems.cxx
index 910de8dcd434..976084b13b3c 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -2262,26 +2262,26 @@ SvxBoxInfoItem::SvxBoxInfoItem( const SvxBoxInfoItem& rCpy ) :
 {
 }
 
-
 SvxBoxInfoItem::~SvxBoxInfoItem()
 {
 }
 
-
 SvxBoxInfoItem &SvxBoxInfoItem::operator=( const SvxBoxInfoItem& rCpy )
 {
-    pHori.reset( rCpy.GetHori() ? new SvxBorderLine( *rCpy.GetHori() ) : nullptr );
-    pVert.reset( rCpy.GetVert() ? new SvxBorderLine( *rCpy.GetVert() ) : nullptr );
-    mbEnableHor = rCpy.mbEnableHor;
-    mbEnableVer = rCpy.mbEnableVer;
-    bDist       = rCpy.IsDist();
-    bMinDist    = rCpy.IsMinDist();
-    nValidFlags = rCpy.nValidFlags;
-    nDefDist    = rCpy.GetDefDist();
+    if (this != &rCpy)
+    {
+        pHori.reset( rCpy.GetHori() ? new SvxBorderLine( *rCpy.GetHori() ) : nullptr );
+        pVert.reset( rCpy.GetVert() ? new SvxBorderLine( *rCpy.GetVert() ) : nullptr );
+        mbEnableHor = rCpy.mbEnableHor;
+        mbEnableVer = rCpy.mbEnableVer;
+        bDist       = rCpy.IsDist();
+        bMinDist    = rCpy.IsMinDist();
+        nValidFlags = rCpy.nValidFlags;
+        nDefDist    = rCpy.GetDefDist();
+    }
     return *this;
 }
 
-
 bool SvxBoxInfoItem::operator==( const SfxPoolItem& rAttr ) const
 {
     assert(SfxPoolItem::operator==(rAttr));
diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index b674d2685246..d96fa16b0901 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -718,17 +718,20 @@ SvxNumRule::~SvxNumRule()
 
 SvxNumRule& SvxNumRule::operator=( const SvxNumRule& rCopy )
 {
-    nLevelCount          = rCopy.nLevelCount;
-    nFeatureFlags        = rCopy.nFeatureFlags;
-    bContinuousNumbering = rCopy.bContinuousNumbering;
-    eNumberingType       = rCopy.eNumberingType;
-    for(sal_uInt16 i = 0; i < SVX_MAX_NUM; i++)
+    if (this != &rCopy)
     {
-        if(rCopy.aFmts[i])
-            aFmts[i].reset( new SvxNumberFormat(*rCopy.aFmts[i]) );
-        else
-            aFmts[i].reset();
-        aFmtsSet[i] = rCopy.aFmtsSet[i];
+        nLevelCount          = rCopy.nLevelCount;
+        nFeatureFlags        = rCopy.nFeatureFlags;
+        bContinuousNumbering = rCopy.bContinuousNumbering;
+        eNumberingType       = rCopy.eNumberingType;
+        for(sal_uInt16 i = 0; i < SVX_MAX_NUM; i++)
+        {
+            if(rCopy.aFmts[i])
+                aFmts[i].reset( new SvxNumberFormat(*rCopy.aFmts[i]) );
+            else
+                aFmts[i].reset();
+            aFmtsSet[i] = rCopy.aFmtsSet[i];
+        }
     }
     return *this;
 }