diff options
| author | Eike Rathke <erack@redhat.com> | 2016-09-22 22:20:48 +0200 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2016-09-23 15:14:03 +0000 |
| commit | 7d8196ea2f4ec3634dbad7367345e62c4ea9893d (patch) | |
| tree | 4550d4ccc4205ae5ca9f134d29927b202e10fb70 /editeng | |
| parent | 751689283c9f3010f7978b6576b25ffc579202ef (diff) | |
perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related
There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.
To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.
For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.
Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Diffstat (limited to 'editeng')
| -rw-r--r-- | editeng/source/editeng/impedit5.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/editeng/source/editeng/impedit5.cxx b/editeng/source/editeng/impedit5.cxx index e360c0ad3c00..e091a142cec2 100644 --- a/editeng/source/editeng/impedit5.cxx +++ b/editeng/source/editeng/impedit5.cxx @@ -24,7 +24,7 @@ #include <impedit.hxx> #include <editeng/editeng.hxx> #include <editdbg.hxx> -#include <svl/smplhint.hxx> +#include <svl/hint.hxx> #include <editeng/lrspitem.hxx> void ImpEditEngine::SetStyleSheetPool( SfxStyleSheetPool* pSPool ) @@ -153,10 +153,10 @@ void ImpEditEngine::Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) pStyle = static_cast<SfxStyleSheet*>( pStyleSheetHint->GetStyleSheet() ); nId = pStyleSheetHint->GetHint(); } - else if ( dynamic_cast<const SfxSimpleHint*>(&rHint) && dynamic_cast< const SfxStyleSheet* >(&rBC) != nullptr ) + else if ( dynamic_cast< const SfxStyleSheet* >(&rBC) != nullptr ) { pStyle = static_cast<SfxStyleSheet*>(&rBC); - nId = dynamic_cast<const SfxSimpleHint*>(&rHint)->GetId(); + nId = rHint.GetId(); } if ( pStyle ) |