tdf#149248 sw offapi xmloff: add option to not hyphenate last word

Add option to disable automatic hyphenation of the last word of
paragraphs for better typography.

Note: the same option used e.g. in Adobe InDesign, and a
similar one in CSS Text Module Level 4 (hyphenate-limit-last).

* Add checkbox to Text Flow in paragraph dialog
* Store property in paragraph model (com::sun::star::style::ParagraphProperties::ParaHyphenationNoLastWord)
* Add ODF import/export
* Add ODF unit test
* Add layout test

Follow-up to commit 72bd0df107ee47c4d54fa88b4960d32ea03e9f69
"tdf#121658 Add option to not hyphenate words in CAPS".

Change-Id: Ida29c65b5a7cbfd7c399c342781531a6fb86f639
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134985
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

3 files changed, 63 insertions, 50 deletions

diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx
index b0df5683b03a..0b8e41f48976 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -164,6 +164,7 @@ const SfxItemInfo aItemInfos[EDITITEMCOUNT] = {
         { SID_ATTR_NUMBERING_RULE, true },         // EE_PARA_NUMBULL
         { 0, true },                               // EE_PARA_HYPHENATE
         { 0, true },                               // EE_PARA_HYPHENATE_NO_CAPS
+        { 0, true },                               // EE_PARA_HYPHENATE_NO_LAST_WORD
         { 0, true },                               // EE_PARA_BULLETSTATE
         { 0, true },                               // EE_PARA_OUTLLRSPACE
         { SID_ATTR_PARA_OUTLLEVEL, true },         // EE_PARA_OUTLLEVEL
diff --git a/editeng/source/editeng/eerdll.cxx b/editeng/source/editeng/eerdll.cxx
index 0002d68caafb..b7120bd1befd 100644
--- a/editeng/source/editeng/eerdll.cxx
+++ b/editeng/source/editeng/eerdll.cxx
@@ -89,59 +89,60 @@ DefItems::DefItems()
     rDefItems[5]  = new SvxNumBulletItem( aDefaultNumRule, EE_PARA_NUMBULLET );
     rDefItems[6]  = new SfxBoolItem( EE_PARA_HYPHENATE, false );
     rDefItems[7]  = new SfxBoolItem( EE_PARA_HYPHENATE_NO_CAPS, false );
-    rDefItems[8]  = new SfxBoolItem( EE_PARA_BULLETSTATE, true );
-    rDefItems[9]  = new SvxLRSpaceItem( EE_PARA_OUTLLRSPACE );
-    rDefItems[10]  = new SfxInt16Item( EE_PARA_OUTLLEVEL, -1 );
-    rDefItems[11] = new SvxBulletItem( EE_PARA_BULLET );
-    rDefItems[12] = new SvxLRSpaceItem( EE_PARA_LRSPACE );
-    rDefItems[13] = new SvxULSpaceItem( EE_PARA_ULSPACE );
-    rDefItems[14] = new SvxLineSpacingItem( 0, EE_PARA_SBL );
-    rDefItems[15] = new SvxAdjustItem( SvxAdjust::Left, EE_PARA_JUST );
-    rDefItems[16] = new SvxTabStopItem( 0, 0, SvxTabAdjust::Left, EE_PARA_TABS );
-    rDefItems[17] = new SvxJustifyMethodItem( SvxCellJustifyMethod::Auto, EE_PARA_JUST_METHOD );
-    rDefItems[18] = new SvxVerJustifyItem( SvxCellVerJustify::Standard, EE_PARA_VER_JUST );
+    rDefItems[8]  = new SfxBoolItem( EE_PARA_HYPHENATE_NO_LAST_WORD, false );
+    rDefItems[9]  = new SfxBoolItem( EE_PARA_BULLETSTATE, true );
+    rDefItems[10]  = new SvxLRSpaceItem( EE_PARA_OUTLLRSPACE );
+    rDefItems[11]  = new SfxInt16Item( EE_PARA_OUTLLEVEL, -1 );
+    rDefItems[12] = new SvxBulletItem( EE_PARA_BULLET );
+    rDefItems[13] = new SvxLRSpaceItem( EE_PARA_LRSPACE );
+    rDefItems[14] = new SvxULSpaceItem( EE_PARA_ULSPACE );
+    rDefItems[15] = new SvxLineSpacingItem( 0, EE_PARA_SBL );
+    rDefItems[16] = new SvxAdjustItem( SvxAdjust::Left, EE_PARA_JUST );
+    rDefItems[17] = new SvxTabStopItem( 0, 0, SvxTabAdjust::Left, EE_PARA_TABS );
+    rDefItems[18] = new SvxJustifyMethodItem( SvxCellJustifyMethod::Auto, EE_PARA_JUST_METHOD );
+    rDefItems[19] = new SvxVerJustifyItem( SvxCellVerJustify::Standard, EE_PARA_VER_JUST );
 
     // Character attributes:
-    rDefItems[19] = new SvxColorItem( COL_AUTO, EE_CHAR_COLOR );
-    rDefItems[20] = new SvxFontItem( EE_CHAR_FONTINFO );
-    rDefItems[21] = new SvxFontHeightItem( 240, 100, EE_CHAR_FONTHEIGHT );
-    rDefItems[22] = new SvxCharScaleWidthItem( 100, EE_CHAR_FONTWIDTH );
-    rDefItems[23] = new SvxWeightItem( WEIGHT_NORMAL, EE_CHAR_WEIGHT );
-    rDefItems[24] = new SvxUnderlineItem( LINESTYLE_NONE, EE_CHAR_UNDERLINE );
-    rDefItems[25] = new SvxCrossedOutItem( STRIKEOUT_NONE, EE_CHAR_STRIKEOUT );
-    rDefItems[26] = new SvxPostureItem( ITALIC_NONE, EE_CHAR_ITALIC );
-    rDefItems[27] = new SvxContourItem( false, EE_CHAR_OUTLINE );
-    rDefItems[28] = new SvxShadowedItem( false, EE_CHAR_SHADOW );
-    rDefItems[29] = new SvxEscapementItem( 0, 100, EE_CHAR_ESCAPEMENT );
-    rDefItems[30] = new SvxAutoKernItem( false, EE_CHAR_PAIRKERNING );
-    rDefItems[31] = new SvxKerningItem( 0, EE_CHAR_KERNING );
-    rDefItems[32] = new SvxWordLineModeItem( false, EE_CHAR_WLM );
-    rDefItems[33] = new SvxLanguageItem( LANGUAGE_DONTKNOW, EE_CHAR_LANGUAGE );
-    rDefItems[34] = new SvxLanguageItem( LANGUAGE_DONTKNOW, EE_CHAR_LANGUAGE_CJK );
-    rDefItems[35] = new SvxLanguageItem( LANGUAGE_DONTKNOW, EE_CHAR_LANGUAGE_CTL );
-    rDefItems[36] = new SvxFontItem( EE_CHAR_FONTINFO_CJK );
-    rDefItems[37] = new SvxFontItem( EE_CHAR_FONTINFO_CTL );
-    rDefItems[38] = new SvxFontHeightItem( 240, 100, EE_CHAR_FONTHEIGHT_CJK );
-    rDefItems[39] = new SvxFontHeightItem( 240, 100, EE_CHAR_FONTHEIGHT_CTL );
-    rDefItems[40] = new SvxWeightItem( WEIGHT_NORMAL, EE_CHAR_WEIGHT_CJK );
-    rDefItems[41] = new SvxWeightItem( WEIGHT_NORMAL, EE_CHAR_WEIGHT_CTL );
-    rDefItems[42] = new SvxPostureItem( ITALIC_NONE, EE_CHAR_ITALIC_CJK );
-    rDefItems[43] = new SvxPostureItem( ITALIC_NONE, EE_CHAR_ITALIC_CTL );
-    rDefItems[44] = new SvxEmphasisMarkItem( FontEmphasisMark::NONE, EE_CHAR_EMPHASISMARK );
-    rDefItems[45] = new SvxCharReliefItem( FontRelief::NONE, EE_CHAR_RELIEF );
-    rDefItems[46] = new SfxVoidItem( EE_CHAR_RUBI_DUMMY );
-    rDefItems[47] = new SvXMLAttrContainerItem( EE_CHAR_XMLATTRIBS );
-    rDefItems[48] = new SvxOverlineItem( LINESTYLE_NONE, EE_CHAR_OVERLINE );
-    rDefItems[49] = new SvxCaseMapItem( SvxCaseMap::NotMapped, EE_CHAR_CASEMAP );
-    rDefItems[50] = new SfxGrabBagItem( EE_CHAR_GRABBAG );
-    rDefItems[51] = new SvxColorItem( COL_AUTO, EE_CHAR_BKGCOLOR );
+    rDefItems[20] = new SvxColorItem( COL_AUTO, EE_CHAR_COLOR );
+    rDefItems[21] = new SvxFontItem( EE_CHAR_FONTINFO );
+    rDefItems[22] = new SvxFontHeightItem( 240, 100, EE_CHAR_FONTHEIGHT );
+    rDefItems[23] = new SvxCharScaleWidthItem( 100, EE_CHAR_FONTWIDTH );
+    rDefItems[24] = new SvxWeightItem( WEIGHT_NORMAL, EE_CHAR_WEIGHT );
+    rDefItems[25] = new SvxUnderlineItem( LINESTYLE_NONE, EE_CHAR_UNDERLINE );
+    rDefItems[26] = new SvxCrossedOutItem( STRIKEOUT_NONE, EE_CHAR_STRIKEOUT );
+    rDefItems[27] = new SvxPostureItem( ITALIC_NONE, EE_CHAR_ITALIC );
+    rDefItems[28] = new SvxContourItem( false, EE_CHAR_OUTLINE );
+    rDefItems[29] = new SvxShadowedItem( false, EE_CHAR_SHADOW );
+    rDefItems[30] = new SvxEscapementItem( 0, 100, EE_CHAR_ESCAPEMENT );
+    rDefItems[31] = new SvxAutoKernItem( false, EE_CHAR_PAIRKERNING );
+    rDefItems[32] = new SvxKerningItem( 0, EE_CHAR_KERNING );
+    rDefItems[33] = new SvxWordLineModeItem( false, EE_CHAR_WLM );
+    rDefItems[34] = new SvxLanguageItem( LANGUAGE_DONTKNOW, EE_CHAR_LANGUAGE );
+    rDefItems[35] = new SvxLanguageItem( LANGUAGE_DONTKNOW, EE_CHAR_LANGUAGE_CJK );
+    rDefItems[36] = new SvxLanguageItem( LANGUAGE_DONTKNOW, EE_CHAR_LANGUAGE_CTL );
+    rDefItems[37] = new SvxFontItem( EE_CHAR_FONTINFO_CJK );
+    rDefItems[38] = new SvxFontItem( EE_CHAR_FONTINFO_CTL );
+    rDefItems[39] = new SvxFontHeightItem( 240, 100, EE_CHAR_FONTHEIGHT_CJK );
+    rDefItems[40] = new SvxFontHeightItem( 240, 100, EE_CHAR_FONTHEIGHT_CTL );
+    rDefItems[41] = new SvxWeightItem( WEIGHT_NORMAL, EE_CHAR_WEIGHT_CJK );
+    rDefItems[42] = new SvxWeightItem( WEIGHT_NORMAL, EE_CHAR_WEIGHT_CTL );
+    rDefItems[43] = new SvxPostureItem( ITALIC_NONE, EE_CHAR_ITALIC_CJK );
+    rDefItems[44] = new SvxPostureItem( ITALIC_NONE, EE_CHAR_ITALIC_CTL );
+    rDefItems[45] = new SvxEmphasisMarkItem( FontEmphasisMark::NONE, EE_CHAR_EMPHASISMARK );
+    rDefItems[46] = new SvxCharReliefItem( FontRelief::NONE, EE_CHAR_RELIEF );
+    rDefItems[47] = new SfxVoidItem( EE_CHAR_RUBI_DUMMY );
+    rDefItems[48] = new SvXMLAttrContainerItem( EE_CHAR_XMLATTRIBS );
+    rDefItems[49] = new SvxOverlineItem( LINESTYLE_NONE, EE_CHAR_OVERLINE );
+    rDefItems[50] = new SvxCaseMapItem( SvxCaseMap::NotMapped, EE_CHAR_CASEMAP );
+    rDefItems[51] = new SfxGrabBagItem( EE_CHAR_GRABBAG );
+    rDefItems[52] = new SvxColorItem( COL_AUTO, EE_CHAR_BKGCOLOR );
     // Features
-    rDefItems[52] = new SfxVoidItem( EE_FEATURE_TAB );
-    rDefItems[53] = new SfxVoidItem( EE_FEATURE_LINEBR );
-    rDefItems[54] = new SvxColorItem( COL_RED, EE_FEATURE_NOTCONV );
-    rDefItems[55] = new SvxFieldItem( SvxFieldData(), EE_FEATURE_FIELD );
+    rDefItems[53] = new SfxVoidItem( EE_FEATURE_TAB );
+    rDefItems[54] = new SfxVoidItem( EE_FEATURE_LINEBR );
+    rDefItems[55] = new SvxColorItem( COL_RED, EE_FEATURE_NOTCONV );
+    rDefItems[56] = new SvxFieldItem( SvxFieldData(), EE_FEATURE_FIELD );
 
-    assert(EDITITEMCOUNT == 56 && "ITEMCOUNT changed, adjust DefItems!");
+    assert(EDITITEMCOUNT == 57 && "ITEMCOUNT changed, adjust DefItems!");
 
     // Init DefFonts:
     GetDefaultFonts( *static_cast<SvxFontItem*>(rDefItems[EE_CHAR_FONTINFO - EE_ITEMS_START]),
diff --git a/editeng/source/items/paraitem.cxx b/editeng/source/items/paraitem.cxx
index 6f5e5f9acd80..56d9628276b3 100644
--- a/editeng/source/items/paraitem.cxx
+++ b/editeng/source/items/paraitem.cxx
@@ -555,6 +555,7 @@ SvxHyphenZoneItem::SvxHyphenZoneItem( const bool bHyph, const sal_uInt16 nId ) :
     bHyphen(bHyph),
     bPageEnd(true),
     bNoCapsHyphenation(false),
+    bNoLastWordHyphenation(false),
     nMinLead(0),
     nMinTrail(0),
     nMaxHyphens(255)
@@ -582,6 +583,9 @@ bool    SvxHyphenZoneItem::QueryValue( uno::Any& rVal, sal_uInt8 nMemberId ) con
         case MID_HYPHEN_NO_CAPS:
             rVal <<= bNoCapsHyphenation;
         break;
+        case MID_HYPHEN_NO_LAST_WORD:
+            rVal <<= bNoLastWordHyphenation;
+        break;
     }
     return true;
 }
@@ -591,9 +595,12 @@ bool SvxHyphenZoneItem::PutValue( const uno::Any& rVal, sal_uInt8 nMemberId )
     nMemberId &= ~CONVERT_TWIPS;
     sal_Int16 nNewVal = 0;
 
-    if( nMemberId != MID_IS_HYPHEN && nMemberId != MID_HYPHEN_NO_CAPS )
+    if( nMemberId != MID_IS_HYPHEN && nMemberId != MID_HYPHEN_NO_CAPS &&
+                nMemberId != MID_HYPHEN_NO_LAST_WORD )
+    {
         if(!(rVal >>= nNewVal))
             return false;
+    }
 
     switch(nMemberId)
     {
@@ -612,6 +619,9 @@ bool SvxHyphenZoneItem::PutValue( const uno::Any& rVal, sal_uInt8 nMemberId )
         case MID_HYPHEN_NO_CAPS:
             bNoCapsHyphenation = Any2Bool(rVal);
         break;
+        case MID_HYPHEN_NO_LAST_WORD:
+            bNoLastWordHyphenation = Any2Bool(rVal);
+        break;
     }
     return true;
 }
@@ -624,6 +634,7 @@ bool SvxHyphenZoneItem::operator==( const SfxPoolItem& rAttr ) const
     const SvxHyphenZoneItem& rItem = static_cast<const SvxHyphenZoneItem&>(rAttr);
     return ( rItem.bHyphen == bHyphen
             && rItem.bNoCapsHyphenation == bNoCapsHyphenation
+            && rItem.bNoLastWordHyphenation == bNoLastWordHyphenation
             && rItem.bPageEnd == bPageEnd
             && rItem.nMinLead == nMinLead
             && rItem.nMinTrail == nMinTrail