diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-14 17:14:18 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-06-11 11:38:15 +0200 |
| commit | 1f08bff31238d5818c54a0b86570689644dff087 (patch) | |
| tree | d4d6f4b62a3c48ddeb85ba89818247c17f2578c8 /editeng | |
| parent | ff130af9661a57d290dbf89b54a4c0ce8d0f71ea (diff) | |
new loplugin:shouldreturnbool
look for methods returning only 1 and/or 0, which (most of the time)
should be returning bool.
Off by default, because some of this is a matter of taste
Change-Id: Ib17782e629888255196e89d4a178618a9612a0de
Reviewed-on: https://gerrit.libreoffice.org/54379
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'editeng')
| -rw-r--r-- | editeng/source/editeng/impedit.hxx | 2 | ||||
| -rw-r--r-- | editeng/source/editeng/impedit4.cxx | 4 | ||||
| -rw-r--r-- | editeng/source/outliner/outlvw.cxx | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx index 56ff504827b7..741fa77b3da0 100644 --- a/editeng/source/editeng/impedit.hxx +++ b/editeng/source/editeng/impedit.hxx @@ -657,7 +657,7 @@ private: EditPaM ReadHTML( SvStream& rInput, const OUString& rBaseURL, EditSelection aSel, SvKeyValueIterator* pHTTPHeaderAttrs ); ErrCode WriteText( SvStream& rOutput, EditSelection aSel ); ErrCode WriteRTF( SvStream& rOutput, EditSelection aSel ); - sal_uInt32 WriteXML(SvStream& rOutput, const EditSelection& rSel); + void WriteXML(SvStream& rOutput, const EditSelection& rSel); void WriteItemAsRTF( const SfxPoolItem& rItem, SvStream& rOutput, sal_Int32 nPara, sal_Int32 nPos, std::vector<SvxFontItem*>& rFontTable, SvxColorList& rColorList ); diff --git a/editeng/source/editeng/impedit4.cxx b/editeng/source/editeng/impedit4.cxx index 8fcf39508d33..a19876928bb4 100644 --- a/editeng/source/editeng/impedit4.cxx +++ b/editeng/source/editeng/impedit4.cxx @@ -268,13 +268,11 @@ static void lcl_FindValidAttribs( ItemList& rLst, ContentNode* pNode, sal_Int32 } } -sal_uInt32 ImpEditEngine::WriteXML(SvStream& rOutput, const EditSelection& rSel) +void ImpEditEngine::WriteXML(SvStream& rOutput, const EditSelection& rSel) { ESelection aESel = CreateESel(rSel); SvxWriteXML( *GetEditEnginePtr(), rOutput, aESel ); - - return 0; } ErrCode ImpEditEngine::WriteRTF( SvStream& rOutput, EditSelection aSel ) diff --git a/editeng/source/outliner/outlvw.cxx b/editeng/source/outliner/outlvw.cxx index 42222d14119f..82c3da7f4d96 100644 --- a/editeng/source/outliner/outlvw.cxx +++ b/editeng/source/outliner/outlvw.cxx @@ -371,7 +371,7 @@ void OutlinerView::ImpToggleExpand( Paragraph const * pPara ) pEditView->ShowCursor(); } -sal_Int32 OutlinerView::Select( Paragraph const * pParagraph, bool bSelect ) +void OutlinerView::Select( Paragraph const * pParagraph, bool bSelect ) { sal_Int32 nPara = pOwner->pParaList->GetAbsPos( pParagraph ); sal_Int32 nEnd = 0; @@ -380,7 +380,6 @@ sal_Int32 OutlinerView::Select( Paragraph const * pParagraph, bool bSelect ) ESelection aSel( nPara, 0, nPara, nEnd ); pEditView->SetSelection( aSel ); - return 1; } |