diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-01-22 10:41:10 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-01-22 10:50:10 +0100 |
| commit | fb509502995aea38e71bb189a8b9e7dc6e9d442b (patch) | |
| tree | 48de52b3fb476e9bf4fdefbe00c7034134877f88 /editeng | |
| parent | 65698ffa0e9274812df7fc997f9c3db7bb760ae2 (diff) | |
Further uninitialized SvxNumberFormat::mbNumAdjustChanged fixing
The uninitialized read during CppunitTest_sd_html_export_tests mentioned in
d90a20833a815362c344b82fc16b4bbcff0ebf07 "Missing initialization of
SvxNumberFormat::mbNumAdjustChanged" is rather caused by the SvxNumberFormat
copy ctor callling the SvxNumberFormat copy assignment op, which calls
SvxNumberFormat::SetNumberingType before assigning mbNumAdjustChanged.
What is probably wanted here is to simply copy the nNumType member without doing
the eNumAdjust adjustments anyway. But a rather brittle design, that.
Change-Id: Ic587687038f1ea71173461412350e6b2dee13aa4
Diffstat (limited to 'editeng')
| -rw-r--r-- | editeng/source/items/numitem.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx index b44c9241fe29..40bdebb0717a 100644 --- a/editeng/source/items/numitem.cxx +++ b/editeng/source/items/numitem.cxx @@ -336,7 +336,7 @@ SvxNumberFormat& SvxNumberFormat::operator=( const SvxNumberFormat& rFormat ) { if (& rFormat == this) { return *this; } - SetNumberingType(rFormat.GetNumberingType()); + SvxNumberType::SetNumberingType(rFormat.GetNumberingType()); eNumAdjust = rFormat.eNumAdjust ; mbNumAdjustChanged = rFormat.mbNumAdjustChanged; nInclUpperLevels = rFormat.nInclUpperLevels ; |