Improved loplugin:stringconstant (now that GCC 7 supports it): editeng

Change-Id: Id1ed8953803dde7ed0709d999ef8efe4eb055176
Reviewed-on: https://gerrit.libreoffice.org/76682
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

10 files changed, 32 insertions, 32 deletions

diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index 151002ff71e5..e832dffd39d6 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -815,7 +815,7 @@ public:
 
     virtual OUString CalcFieldValue( const SvxFieldItem&, sal_Int32, sal_Int32, boost::optional<Color>&, boost::optional<Color>& ) override
     {
-        return OUString("jim@bob.com"); // a sophisticated view of value:
+        return "jim@bob.com"; // a sophisticated view of value:
     }
 };
 
diff --git a/editeng/source/accessibility/AccessibleContextBase.cxx b/editeng/source/accessibility/AccessibleContextBase.cxx
index c08a7f25a48c..8dc73b04f8ca 100644
--- a/editeng/source/accessibility/AccessibleContextBase.cxx
+++ b/editeng/source/accessibility/AccessibleContextBase.cxx
@@ -388,7 +388,7 @@ void SAL_CALL AccessibleContextBase::removeAccessibleEventListener (
 // XServiceInfo
 OUString SAL_CALL AccessibleContextBase::getImplementationName()
 {
-    return OUString("AccessibleContextBase");
+    return "AccessibleContextBase";
 }
 
 sal_Bool SAL_CALL AccessibleContextBase::supportsService (const OUString& sServiceName)
@@ -476,7 +476,7 @@ void AccessibleContextBase::SetAccessibleName (
 
 OUString AccessibleContextBase::CreateAccessibleName()
 {
-    return OUString("Empty Name");
+    return "Empty Name";
 }
 
 
diff --git a/editeng/source/accessibility/AccessibleEditableTextPara.cxx b/editeng/source/accessibility/AccessibleEditableTextPara.cxx
index 7914e65383a5..01c0f274a0b9 100644
--- a/editeng/source/accessibility/AccessibleEditableTextPara.cxx
+++ b/editeng/source/accessibility/AccessibleEditableTextPara.cxx
@@ -2694,7 +2694,7 @@ namespace accessibility
     OUString SAL_CALL AccessibleEditableTextPara::getImplementationName()
     {
 
-        return OUString("AccessibleEditableTextPara");
+        return "AccessibleEditableTextPara";
     }
 
     sal_Bool SAL_CALL AccessibleEditableTextPara::supportsService (const OUString& sServiceName)
diff --git a/editeng/source/accessibility/AccessibleImageBullet.cxx b/editeng/source/accessibility/AccessibleImageBullet.cxx
index 1063e2a347a5..b596e292cb0d 100644
--- a/editeng/source/accessibility/AccessibleImageBullet.cxx
+++ b/editeng/source/accessibility/AccessibleImageBullet.cxx
@@ -348,7 +348,7 @@ namespace accessibility
     OUString SAL_CALL AccessibleImageBullet::getImplementationName()
     {
 
-        return OUString("AccessibleImageBullet");
+        return "AccessibleImageBullet";
     }
 
     sal_Bool SAL_CALL AccessibleImageBullet::supportsService (const OUString& sServiceName)
diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx
index 73a356054741..576dcfbbb4d9 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -2121,10 +2121,10 @@ sal_Int32 EditDoc::Count() const
 OUString EditDoc::GetSepStr( LineEnd eEnd )
 {
     if ( eEnd == LINEEND_CR )
-        return OUString("\015"); // 0x0d
+        return "\015"; // 0x0d
     if ( eEnd == LINEEND_LF )
-        return OUString("\012"); // 0x0a
-    return OUString("\015\012"); // 0x0d, 0x0a
+        return "\012"; // 0x0a
+    return "\015\012"; // 0x0d, 0x0a
 }
 
 OUString EditDoc::GetText( LineEnd eEnd ) const
diff --git a/editeng/source/uno/unofield.cxx b/editeng/source/uno/unofield.cxx
index 5a30627a3d7b..ab1b0927dceb 100644
--- a/editeng/source/uno/unofield.cxx
+++ b/editeng/source/uno/unofield.cxx
@@ -619,39 +619,39 @@ OUString SAL_CALL SvxUnoTextField::getPresentation( sal_Bool bShowCommand )
         switch (mnServiceId)
         {
             case text::textfield::Type::DATE:
-                return OUString("Date");
+                return "Date";
             case text::textfield::Type::URL:
-                return OUString("URL");
+                return "URL";
             case text::textfield::Type::PAGE:
-                return OUString("Page");
+                return "Page";
             case text::textfield::Type::PAGES:
-                return OUString("Pages");
+                return "Pages";
             case text::textfield::Type::TIME:
-                return OUString("Time");
+                return "Time";
             case text::textfield::Type::DOCINFO_TITLE:
-                return OUString("File");
+                return "File";
             case text::textfield::Type::TABLE:
-                return OUString("Table");
+                return "Table";
             case text::textfield::Type::EXTENDED_TIME:
-                return OUString("ExtTime");
+                return "ExtTime";
             case text::textfield::Type::EXTENDED_FILE:
-                return OUString("ExtFile");
+                return "ExtFile";
             case text::textfield::Type::AUTHOR:
-                return OUString("Author");
+                return "Author";
             case text::textfield::Type::MEASURE:
-                return OUString("Measure");
+                return "Measure";
             case text::textfield::Type::PRESENTATION_HEADER:
-                return OUString("Header");
+                return "Header";
             case text::textfield::Type::PRESENTATION_FOOTER:
-                return OUString("Footer");
+                return "Footer";
             case text::textfield::Type::PRESENTATION_DATE_TIME:
-                return OUString("DateTime");
+                return "DateTime";
             case text::textfield::Type::PAGE_NAME:
-                return OUString("PageName");
+                return "PageName";
             case text::textfield::Type::DOCINFO_CUSTOM:
-                return OUString("Custom");
+                return "Custom";
             default:
-                return OUString("Unknown");
+                return "Unknown";
         }
     }
     else
@@ -818,7 +818,7 @@ void SvxUnoTextField::disposing()
 // lang::XServiceInfo
 OUString SAL_CALL SvxUnoTextField::getImplementationName()
 {
-    return OUString("SvxUnoTextField");
+    return "SvxUnoTextField";
 }
 
 uno::Sequence< OUString > SAL_CALL SvxUnoTextField::getSupportedServiceNames()
diff --git a/editeng/source/uno/unonrule.cxx b/editeng/source/uno/unonrule.cxx
index e469d63f9ac4..3f2f344d9179 100644
--- a/editeng/source/uno/unonrule.cxx
+++ b/editeng/source/uno/unonrule.cxx
@@ -155,7 +155,7 @@ Reference< XCloneable > SAL_CALL SvxUnoNumberingRules::createClone(  )
 
 OUString SAL_CALL SvxUnoNumberingRules::getImplementationName(  )
 {
-    return OUString( "SvxUnoNumberingRules" );
+    return "SvxUnoNumberingRules";
 }
 
 sal_Bool SAL_CALL SvxUnoNumberingRules::supportsService( const OUString& ServiceName )
diff --git a/editeng/source/uno/unopracc.cxx b/editeng/source/uno/unopracc.cxx
index 4c50307dcc43..9207839c711c 100644
--- a/editeng/source/uno/unopracc.cxx
+++ b/editeng/source/uno/unopracc.cxx
@@ -83,7 +83,7 @@ uno::Sequence< sal_Int8 > SAL_CALL SvxAccessibleTextPropertySet::getImplementati
 // XServiceInfo
 OUString SAL_CALL SAL_CALL SvxAccessibleTextPropertySet::getImplementationName()
 {
-    return OUString("SvxAccessibleTextPropertySet");
+    return "SvxAccessibleTextPropertySet";
 }
 
 sal_Bool SAL_CALL SvxAccessibleTextPropertySet::supportsService (const OUString& sServiceName)
diff --git a/editeng/source/uno/unotext.cxx b/editeng/source/uno/unotext.cxx
index 07c27d701e57..fc83f3fff196 100644
--- a/editeng/source/uno/unotext.cxx
+++ b/editeng/source/uno/unotext.cxx
@@ -1592,7 +1592,7 @@ uno::Reference< text::XText > SAL_CALL SvxUnoTextRange::getText()
 // lang::XServiceInfo
 OUString SAL_CALL SvxUnoTextRange::getImplementationName()
 {
-    return OUString("SvxUnoTextRange");
+    return "SvxUnoTextRange";
 }
 
 
@@ -2155,7 +2155,7 @@ void SvxUnoTextBase::copyText(
 // lang::XServiceInfo
 OUString SAL_CALL SvxUnoTextBase::getImplementationName()
 {
-    return OUString("SvxUnoTextBase");
+    return "SvxUnoTextBase";
 }
 
 uno::Sequence< OUString > SAL_CALL SvxUnoTextBase::getSupportedServiceNames(  )
diff --git a/editeng/source/uno/unotext2.cxx b/editeng/source/uno/unotext2.cxx
index 5d0fda71f07a..ba9c66f3c37f 100644
--- a/editeng/source/uno/unotext2.cxx
+++ b/editeng/source/uno/unotext2.cxx
@@ -357,7 +357,7 @@ void SAL_CALL SvxUnoTextContent::setPropertyToDefault( const OUString& PropertyN
 
 OUString SAL_CALL SvxUnoTextContent::getImplementationName()
 {
-    return OUString("SvxUnoTextContent");
+    return "SvxUnoTextContent";
 }
 
 uno::Sequence< OUString > SAL_CALL SvxUnoTextContent::getSupportedServiceNames()
@@ -633,7 +633,7 @@ void SAL_CALL SvxUnoTextCursor::setString( const OUString& aString )
 // lang::XServiceInfo
 OUString SAL_CALL SvxUnoTextCursor::getImplementationName()
 {
-    return OUString("SvxUnoTextCursor");
+    return "SvxUnoTextCursor";
 }
 
 sal_Bool SAL_CALL SvxUnoTextCursor::supportsService( const OUString& ServiceName )